On 21/04/2015 16:04, Michael McMahon wrote:
:
http://cr.openjdk.java.net/~michaelm/8078276/webrev.1/
Before you push this, shouldn't the test have copyright Red Hat? There's
an example in the same directory.
-Alan
Hello,
As the next step of implementing "Proposed new policies for JDK 9
regression tests: tiered testing, intermittent failures, and randomness"
[1], please review this changeset which adds a "randomness" jtreg
keyword and tags 240 regression tests in the jdk repository with the
keyword:
On 4/21/2015 11:41 AM, Sean Mullan wrote:
On 04/21/2015 02:20 PM, Mandy Chung wrote:
OK. I think it's better to follow up this after further discussion for
the deprivileging work and understand what can or can't be done in
editing the policy files. For now, we should keep existing behavior to
On 04/21/2015 02:20 PM, Mandy Chung wrote:
OK. I think it's better to follow up this after further discussion for
the deprivileging work and understand what can or can't be done in
editing the policy files. For now, we should keep existing behavior to
grant jdk.xml.dom AllPermissions. How does
On 04/21/2015 10:48 AM, Sean Mullan wrote:
On 04/21/2015 01:36 PM, Mandy Chung wrote:
Good point. They are all interfaces that don't require any permission.
Ah, ok. Never mind then.
I'm inclined to suggest the client, e.g. implementation classes,
requiring jdk.xml.dom should configure pro
Thanks, John.
Best regards,
Vladimir Ivanov
On 4/21/15 8:46 PM, John Rose wrote:
Reviewed. Nice find.
– John
On Apr 21, 2015, at 10:37 AM, Vladimir Ivanov
wrote:
http://cr.openjdk.java.net/~vlivanov/8078290/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8078290
Customization logic i
On 04/21/2015 01:36 PM, Mandy Chung wrote:
Good point. They are all interfaces that don't require any permission.
Ah, ok. Never mind then.
I'm inclined to suggest the client, e.g. implementation classes,
requiring jdk.xml.dom should configure proper permissions for itself as
well as permissi
Reviewed. Nice find.
– John
> On Apr 21, 2015, at 10:37 AM, Vladimir Ivanov
> wrote:
>
> http://cr.openjdk.java.net/~vlivanov/8078290/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8078290
>
> Customization logic introduced in [1] doesn't work as expected for
> MH.invoke() when asTyp
Good point. They are all interfaces that don't require any permission.
I'm inclined to suggest the client, e.g. implementation classes,
requiring jdk.xml.dom should configure proper permissions for itself as
well as permissions required by jdk.xml.dom. Otherwise it would require
AllPermission
http://cr.openjdk.java.net/~vlivanov/8078290/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8078290
Customization logic introduced in [1] doesn't work as expected for
MH.invoke() when asType() conversion happens and cached MH is used.
Generic invoker LambdaForm looks like:
invoke_002_MT=
Do we also need to change the java.policy file to grant specific
permissions to the jdk.xml.dom module?
--Sean
On 04/21/2015 01:19 PM, huizhe wang wrote:
Thanks Mandy, Alan.
Fixed the issues. Here's the updated webrev:
http://cr.openjdk.java.net/~joehw/jdk9/8078139/webrev/
-Joe
On 4/21/2015
Thanks Mandy, Alan.
Fixed the issues. Here's the updated webrev:
http://cr.openjdk.java.net/~joehw/jdk9/8078139/webrev/
-Joe
On 4/21/2015 10:10 AM, Alan Bateman wrote:
On 21/04/2015 17:54, huizhe wang wrote:
Hi,
By JDK-8042244, we moved several org.w3c.dom packages to a module
called jdk.xm
On 21/04/2015 17:54, huizhe wang wrote:
Hi,
By JDK-8042244, we moved several org.w3c.dom packages to a module
called jdk.xml.dom. This new module shall be loaded by the ext class
loader. Please review the patch for the change.
http://cr.openjdk.java.net/~joehw/jdk9/8078139/webrev/
Looks oka
On 04/21/2015 09:54 AM, huizhe wang wrote:
Hi,
By JDK-8042244, we moved several org.w3c.dom packages to a module
called jdk.xml.dom. This new module shall be loaded by the ext class
loader. Please review the patch for the change.
http://cr.openjdk.java.net/~joehw/jdk9/8078139/webrev/
Look
Hi,
By JDK-8042244, we moved several org.w3c.dom packages to a module called
jdk.xml.dom. This new module shall be loaded by the ext class loader.
Please review the patch for the change.
http://cr.openjdk.java.net/~joehw/jdk9/8078139/webrev/
Thanks,
Joe
On 04/21/2015 07:36 PM, huizhe wang wrote:
On 4/21/2015 5:14 AM, Aleksej Efimov wrote:
Hi Joe,
Thank you for you comments - I have modified the test [1] to avoid
multiple file open operations - now the test reads the file content
one time after each call to schemagen tool.
Ok.
Golden/expe
On 4/21/2015 5:14 AM, Aleksej Efimov wrote:
Hi Joe,
Thank you for you comments - I have modified the test [1] to avoid
multiple file open operations - now the test reads the file content
one time after each call to schemagen tool.
Ok.
Golden/expected output is a good suggestion, but we'll
On 4/21/2015 5:14 AM, Aleksej Efimov wrote:
Hi Joe,
Thank you for you comments - I have modified the test [1] to avoid
multiple file open operations - now the test reads the file content
one time after each call to schemagen tool.
Ok.
Golden/expected output is a good suggestion, but we'll
Hi Thomas,
Good point and more robust.
Thanks, Roger
On 4/21/2015 11:49 AM, Thomas Stüfe wrote:
Hi Roger,
small remark, I see you at a number of places using the same pattern
when reading information from /proc:
342 ret = fread(&psinfo, 1, (sizeof psinfo), fp);
343 fclose(fp);
On Apr 21, 2015, at 5:20 PM, Roger Riggs wrote:
> Hi Paul,
>
> The onExit() @implNote recommends the subclass delegate to the underlying
> process.
I know, but is that recommendation just for our (Oracle's) JDK? Is it subject
to change? What if another JDK vendor decides to have a different
Hi Roger,
small remark, I see you at a number of places using the same pattern when
reading information from /proc:
342 ret = fread(&psinfo, 1, (sizeof psinfo), fp);
343 fclose(fp);
344 if (ret < 0) {
345 return;
346 }
A better way would be to check for the whole siz
Hi Paul,
The onExit() @implNote recommends the subclass delegate to the
underlying process.
For a simple subclass acting as a proxy or decorator that will provide
the best implementation.
I'll add the onExit() method to the class level recommendation for
Subclasses of Process.
Thanks, Rog
On 21/04/2015 16:04, Michael McMahon wrote:
On 21/04/15 14:56, Alan Bateman wrote:
:
Can the test be moved to jdk/test/com/sun/jndi/dns as that seems to
be where the other tests are? Also I assume this will need a
copyright header before it is pushed.
-Alan
I had pushed it already. So, I
+1
On 4/21/2015 11:04 AM, Michael McMahon wrote:
On 21/04/15 14:56, Alan Bateman wrote:
On 20/04/2015 18:32, Severin Gehwolf wrote:
:
OK fixed:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/
FWIW, I don't think the test needs IP addresses of DNS servers to be
functional,
On 21/04/15 14:56, Alan Bateman wrote:
On 20/04/2015 18:32, Severin Gehwolf wrote:
:
OK fixed:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/
FWIW, I don't think the test needs IP addresses of DNS servers to be
functional, though. All it really does is passing it to
InetAd
On 20/04/2015 18:32, Severin Gehwolf wrote:
:
OK fixed:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/
FWIW, I don't think the test needs IP addresses of DNS servers to be
functional, though. All it really does is passing it to
InetAddress.getByName(). Prior this patch DnsC
On Apr 21, 2015, at 2:57 PM, Roger Riggs wrote:
> Hi Paul,
>
> On 4/21/2015 8:29 AM, Paul Sandoz wrote:
>> There are statements in Process about the specified behavior of Processes
>> created by ProcessBuilder. That's why I included them in the @implSpec
>> clause. If @implSpec is only for th
Your fix looks good to me. Thanks for contributing the patch.
> On 25 Mar 2015, at 14:47, Stanislav Baiduzhyi
> wrote:
>
> On Tuesday 10 March 2015 17:18:06 Stanislav Baiduzhyi wrote:
>> Hi All,
>>
>> Please review the patch for LdapURL. Patch fixes the parsing of query part
>> of LDAP URL, l
Hi Paul,
On 4/21/2015 8:29 AM, Paul Sandoz wrote:
There are statements in Process about the specified behavior of
Processes created by ProcessBuilder. That's why I included them in the
@implSpec clause. If @implSpec is only for the specifics of the method
itself then where should the behavior
On Apr 20, 2015, at 8:42 PM, Roger Riggs wrote:
> Hi Paul,
>
> On 4/20/2015 2:26 PM, Paul Sandoz wrote:
>> On Apr 20, 2015, at 7:33 PM, Roger Riggs wrote:
>>
>>> Hi Paul,
>>>
>>> There are statements in Process about the specified behavior of Processes
>>> created by ProcessBuilder. That's
Hi Joe,
Thank you for you comments - I have modified the test [1] to avoid
multiple file open operations - now the test reads the file content one
time after each call to schemagen tool.
Golden/expected output is a good suggestion, but we'll depend here on a
format of generated schema file - i
On 20/04/15 18:32, Severin Gehwolf wrote:
On Mon, 2015-04-20 at 12:24 -0400, Andrew Hughes wrote:
- Original Message -
Adding in net-dev.
On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote:
Hi,
Could I please get a review and a sponsor for the following patch?
The issue is tha
On 21 Apr 2015, at 03:00, David Holmes wrote:
> On 21/04/2015 1:24 AM, Chris Hegarty wrote:
>>
>> On 20/04/15 16:17, Lance Andersen wrote:
>>> Hi Pavel,
>>>
>>> So we are just documenting/clarifying the current behavior from what I
>>> can tell from the change?
>>
>> Looking at the testcase, i
33 matches
Mail list logo
