Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Mandy, > However I have trouble for > Finalizer.printFinalizationQueue method that doesn’t belong there. > What are the other alternatives you have explored? Other alternatives could be to do all hashing/sorting/printing on native layer i.e. implement printFinalizationQueue inside VM. Both optio

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

> On May 18, 2015, at 5:17 AM, Dmitry Samersoff > wrote: > > Please review updated version of the fix: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ > > > Most important part of the fix provided by Peter Leva

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

Hi Roger, On 5/19/2015 7:25 PM, Roger Riggs wrote: Hi Joe, Thanks, I was pondering on what to do. The intermittent keyword was not already on this test though it has been failing intermittently. I agree that it is useful for the keyword to remain as a reminder that it was intermittent unt

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

Hi Joe, Thanks, I was pondering on what to do. The intermittent keyword was not already on this test though it has been failing intermittently. I agree that it is useful for the keyword to remain as a reminder that it was intermittent until there is some evidence about long term stability.

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

On 5/19/2015 7:14 PM, Martin Buchholz wrote: Thanks, Roger. This is a much better test now (but still not actually a good one...) Probably want to be optimistic and delete + * @key intermittent That is an interesting (and as yet unresolved) policy question: how should removal of intermitten

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

Thanks, Roger. This is a much better test now (but still not actually a good one...) Probably want to be optimistic and delete + * @key intermittent On Tue, May 19, 2015 at 6:50 PM, Roger Riggs wrote: > Hi, > > Ok, how about this: > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-l

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

Hi, Ok, how about this: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-lots-8078582/ Thanks, Roger On 5/19/15 7:55 PM, Martin Buchholz wrote: LotsOfOutput is a lousy test. totalMemory can grow with any quantum. Better would be watching usedMemory = Runtime.getRuntime().totalMemory() -

Re: JDK 9 RFR of JDK-8080711: Prepare sun/nio/cs/FindEncoderBugs.java to find intermittent failures

Hi Joe, Looks fine. Roger On 5/19/15 6:04 PM, joe darcy wrote: Hello, The test sun/nio/cs/FindEncoderBugs.java has some intermittent failures; I'd like to update it to use the random number library to help track those failures down. Patch below. Thanks, -Joe diff -r b1a68681ccac test/s

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

LotsOfOutput is a lousy test. totalMemory can grow with any quantum. Better would be watching usedMemory = Runtime.getRuntime().totalMemory() - Runtime.getRuntime().freeMemory(); as suggested at http://stackoverflow.com/questions/3571203/what-is-the-exact-meaning-of-runtime-getruntime-totalmemory-a

Re: RFR: 8080608: Missing archive name from jdeps -v -e output if no dependency on other JAR

On 05/19/2015 10:02 AM, Daniel Fuchs wrote: Hi, Please find below a patch for jdeps: http://cr.openjdk.java.net/~dfuchs/webrev_8080608/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8080608 : The fix will make sure that jdeps prints instead: indirect2.jar -> dist/unsafe.jar use.indir

Re: RFR 9: 8077350 Process API Updates Implementation Review

On 19.05.2015 23:15, Roger Riggs wrote: The webrev, javadoc, and specdiffs have been updated to address recent recommendations: Please review and comment: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-ph/ (May 19) src/java.base/windows/classes/java/lang/ProcessImpl.java : 37 import ja

Re: JDK 9 RFR of JDK-8075284: fix up miscellaneous TM constructions

Hi Joe, I just wanted to keep this changeset focused on the TM issues, but I don't oppose the other improvements you've suggested being made. Thanks, -Joe On 5/19/2015 1:09 PM, huizhe wang wrote: Hi Joe, Looks good to me. You might also change the followings if you want: src/jdk.jdi/share

JDK 9 RFR of JDK-8080711: Prepare sun/nio/cs/FindEncoderBugs.java to find intermittent failures

Hello, The test sun/nio/cs/FindEncoderBugs.java has some intermittent failures; I'd like to update it to use the random number library to help track those failures down. Patch below. Thanks, -Joe diff -r b1a68681ccac test/sun/nio/cs/FindEncoderBugs.java --- a/test/sun/nio/cs/FindEncoderBug

RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

Please review this update to a test to make it resilient to small allocations that may bump the total memory. The test will also collect more data if it fails again. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-xx/ Issue: https://bugs.openjdk.java.net/browse/JDK-8078582 Thanks, Rog

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

On 5/18/15 8:17 AM, Dmitry Samersoff wrote: Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix provided by Peter Levart, so all credentials belongs to him. -Dmitry Looks good to me. I also pinged M

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On 5/19/15 3:07 AM, Paul Sandoz wrote: Since this method transfers control it seems a little mean to place such a restriction on the returned Iterator. Although, there is no clear means of stating to the caller whether such an iterator supports removal or not, but that seems to be generally th

Re: RFR [9] 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader

On 15/05/2015 16:13, Miroslav Kos wrote: Hi everybody, this is review request for: 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader The JAX-B API changed a little bit - proprietary ServiceLoader-like code has been replaced by java.util.ServiceLoader. This change is required by

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

On May 18, 2015, at 8:17 AM, Dmitry Samersoff wrote: > > Everyone, > > Please review updated version of the fix: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ > > Most important part of the fix provided by Peter Levart, so all > credentials belongs to him. > > -Dmitry Lo

Re: JDK 9 RFR of JDK-8075284: fix up miscellaneous TM constructions

Hi Lance, Well spotted! I'll push a corrected version with -is included in the JavaTM -Standard Edition (Java SETM), version 7. +is included in the Java™ Standard Edition (Java SE™), version 7. (From a quick grep, there weren't any other "&trae" typos in the patch. Thanks, -Joe On 5/19/20

RFR 9: 8077350 Process API Updates Implementation Review

The webrev, javadoc, and specdiffs have been updated to address recent recommendations: Please review and comment: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-ph/ (May 19) javadoc: http://cr.openjdk.java.net/~rriggs/ph-apidraft/ (May 19) Diffs of the spec/javadoc from previous draft: ht

Re: JDK 9 RFR of JDK-8075284: fix up miscellaneous TM constructions

Hi Joe, Looks good to me. You might also change the followings if you want: src/jdk.jdi/share/classes/com/sun/jdi/request/AccessWatchpointRequest.java @@ -29,12 +29,11 @@ /** * Request for notification when the conte

Re: JDK 9 RFR of JDK-8075284: fix up miscellaneous TM constructions

Hi Joe, Looks like a typo in src/java.sql/share/classes/java/sql/package.html: -is included in the JavaTM -Standard Edition (Java SETM), version 7. +is included in the Java&trae; I believe there were just two occurrences of the above typo. The rest looks ok Best Lance On May 19, 2015, at 3:4

JDK 9 RFR of JDK-8075284: fix up miscellaneous TM constructions

Hello, Please review these changes for JDK-8075284: fix up miscellaneous TM constructions http://cr.openjdk.java.net/~darcy/8075284.0/ which replace convoluted HTML markup for expressing a trademark sign with the HTML ™ --- build and docs build pass with the changes Thanks, -Joe

Re: RFR (XXS) 8080535: (ch) Expected size of Character.UnicodeBlock.map is not optimal

Hi everyone! What about this variant: http://cr.openjdk.java.net/~igerasim/8080535/02/webrev/ No named constant. A comment in the code about initial capacity. In the test, we use the same constant to check if it were sufficient to hold the final number of entries. If someone evil shrinks the

Re: RFR: 8077822: javac does not recognize '*.java' as file if '-J' option is specified

Thanks Kumar, I'll alter (& build / test) it before pushing. -Rob On 19/05/15 19:22, Kumar Srinivasan wrote: Hi Rob, Looks good, except a small nit, I would've written this with a positive check +/* Copy the non-vm args */ +for (i = 0; i < nargc ; i++) { +const char *a

Re: RFR: 8077822: javac does not recognize '*.java' as file if '-J' option is specified

Hi Rob, Looks good, except a small nit, I would've written this with a positive check +/* Copy the non-vm args */ +for (i = 0; i < nargc ; i++) { +const char *arg = stdargs[i].arg; +if (arg[0] != '-' || arg[1] != 'J') { +argv = (StdArg*) JLI_MemRealloc(argv,

Re: [8] RFR of 8066985: Java Webstart downloading packed files can result in Timezone set to UTC

Hi there, I reverted the last change, now test uses native unpacker as before. But I fixed the test other way, now I warm up native unpacker to make it initialized on native level before the main part of test: http://cr.openjdk.java.net/~mcherkas/8066985/webrev.11/test/tools/pack200/DefaultTime

Re: RFR 8080623 CPU overhead in FJ due to spinning in awaitWork

On 19 May 2015, at 18:55, Paul Sandoz wrote: > Hi, > > https://bugs.openjdk.java.net/browse/JDK-8080623 > > diff -r ea3ca5cfc3c6 > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java > --- a/src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java > Tue May 19 20

RFR 8080623 CPU overhead in FJ due to spinning in awaitWork

Hi, https://bugs.openjdk.java.net/browse/JDK-8080623 diff -r ea3ca5cfc3c6 src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java --- a/src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java Tue May 19 20:04:29 2015 +0300 +++ b/src/java.base/share/classes/java/util

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On May 19, 2015, at 6:13 PM, Daniel Fuchs wrote: > On 19/05/15 12:07, Paul Sandoz wrote: >>> Should anything be said also about default remove() method inherited from >>> Iterator interface? Are custom asIterator() implementations allowed to >>> return an Iterator that implements remove() in a

RFR: 8080608: Missing archive name from jdeps -v -e output if no dependency on other JAR

Hi, Please find below a patch for jdeps: http://cr.openjdk.java.net/~dfuchs/webrev_8080608/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8080608 The issue is described in JDK-8080608 as follows: I have 2 jars: indirect2.jar: class use.indirect2.UseUnsafeIndirectly2 {

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On 19 May 2015, at 17:13, Daniel Fuchs wrote: > On 19/05/15 12:07, Paul Sandoz wrote: >>> Should anything be said also about default remove() method inherited from >>> Iterator interface? Are custom asIterator() implementations allowed to >>> return an Iterator that implements remove() in a wa

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On 19/05/15 12:07, Paul Sandoz wrote: Should anything be said also about default remove() method inherited from Iterator interface? Are custom asIterator() implementations allowed to return an Iterator that implements remove() in a way that actually removes elements? > Since this method transf

Re: RFR(XS) : 8055269 : java/lang/invoke/MethodHandles/CatchExceptionTest.java fails intermittently

Looks good then! Best regards, Vladimir Ivanov On 5/19/15 12:35 PM, Igor Ignatyev wrote: Vladimir, thank you for review. regarding slot consumption calculation, to get parameters limited by slot number, the test uses Helper.getParams method which implements this calculation (test/lib/testlibr

Re: RFR 9: 8077350 Process API Updates Implementation Review

Hi Peter, On 5/19/2015 4:34 AM, Peter Levart wrote: Hi Roger, On 05/18/2015 11:49 PM, Roger Riggs wrote: The earlier spec specifically used the common pool but from a specification point of view it allows more flexibility in the implementation not to bind onExit to the commonPool. Its not cle

Re: JDK 9 RFR of JDK-8080658: Update FindDecoderBugs.java to use random number generator library

On 5/19/2015 8:42 AM, Martin Buchholz wrote: Thanks. We believe there is a bug in the JDK revealed by FindDecoderBugs - so actually find that bug and provide a repro recipe! Yes, the random number library in the jtreg directory prints out the seed used, which should make reproducing the failu

Re: JDK 9 RFR of JDK-8080658: Update FindDecoderBugs.java to use random number generator library

Thanks. We believe there is a bug in the JDK revealed by FindDecoderBugs - so actually find that bug and provide a repro recipe! On Tue, May 19, 2015 at 4:27 AM, Amy Lu wrote: > sun/nio/cs/FindDecoderBugs.java > > This test uses randomness and has been observed to intermittently fail. > This pa

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On 5/19/15 1:04 AM, Paul Sandoz wrote: On May 19, 2015, at 12:45 AM, Stuart Marks wrote: OK, good. I tweaked it somewhat to say "if any method is called" instead of "operated on" to make it absolutely clear that the underlying Enumeration shouldn't be touched after the call to asIterator().

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On May 19, 2015, at 3:46 PM, Tomasz Kowalczewski wrote: > Are you talking about ClassLoader::{findResources, getBootstrapResources, > getResources, getSystemResources} and NetworkInterface::{getInetAddresses, > getNetworkInterfaces, getSubInterfaces}? Yes, all those are potential candidates to

RFR: 8077822: javac does not recognize '*.java' as file if '-J' option is specified

Hi folks, Because of platform specifics the Java launcher contains some extra wildcard expansion processing on Windows. As part of this processing the list of args received by CreateApplicationArgs (java_md.c) is compared to the original list in the java launchers main method. Unfortunatel

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

Are you talking about ClassLoader::{findResources, getBootstrapResources, getResources, getSystemResources} and NetworkInterface::{getInetAddresses, getNetworkInterfaces, getSubInterfaces}? On Tue, May 19, 2015 at 2:26 PM, Paul Sandoz wrote: > On May 19, 2015, at 12:41 PM, Tomasz Kowalczewski <

Re: RFR 9: 8077350 Process API Updates Implementation Review

Hi Paul, a couple of followup responses... On 5/18/2015 5:16 PM, Paul Sandoz wrote: 251 /** 252 * Kills the subprocess forcibly. The subprocess represented by this 253 * {@code Process} object is forcibly terminated. 254 * Forcible process destruction is defined as

Re: JDK 9 RFR of JDK-8080658: Update FindDecoderBugs.java to use random number generator library

Hi Amy, Looks fine. Roger On 5/19/2015 7:27 AM, Amy Lu wrote: sun/nio/cs/FindDecoderBugs.java This test uses randomness and has been observed to intermittently fail. This patch is to update the test to use the random number testing library, to better identify the cause of any future failu

Re: RFR 8072002: The spec on javax.script.Compilable contains a typo and confusing inconsistency

+1 > On May 19, 2015, at 2:15 PM, A. Sundararajan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8072002/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8072002 > > Thanks, > -Sundar

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On May 19, 2015, at 12:41 PM, Tomasz Kowalczewski wrote: > Is there a plan to override the default method asIterator() in specific > implementations of Enumeration to avoid creating new object? JarFile::entries > already returns JarEntryIterator which is both. > I suppose one could, it's easy

Re: RFR 8072002: The spec on javax.script.Compilable contains a typo and confusing inconsistency

+1 > On 19 May 2015, at 14:15, A. Sundararajan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8072002/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8072002 > > Thanks, > -Sundar

RFR 8072002: The spec on javax.script.Compilable contains a typo and confusing inconsistency

Please review http://cr.openjdk.java.net/~sundar/8072002/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8072002 Thanks, -Sundar

JDK 9 RFR of JDK-8080658: Update FindDecoderBugs.java to use random number generator library

sun/nio/cs/FindDecoderBugs.java This test uses randomness and has been observed to intermittently fail. This patch is to update the test to use the random number testing library, to better identify the cause of any future failures. Please review the patch. I also need a sponsor for this chang

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

Any specific implementations can always be added later. As far as I can see, the spec for `asIterator()` does not specify any identity/state properties of the returned object. -Pavel > On 19 May 2015, at 11:41, Tomasz Kowalczewski > wrote: > > Is there a plan to override the default method asI

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

Is there a plan to override the default method asIterator() in specific implementations of Enumeration to avoid creating new object? JarFile::entries already returns JarEntryIterator which is both. To be fair I did some tests and when I wrap Enumerable into simple Iterator adapter it will almost a

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On May 19, 2015, at 11:17 AM, Peter Levart wrote: > Hi, > > On 05/18/2015 12:20 PM, Paul Sandoz wrote: >> Hi Stuart, >> >> I would like to suggest some tweaks to the specification to get across this >> method is transitioning control of traversal from enumeration to iterator. >> How about: >

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Hi Dmitry, This looks good. Just alignment of new code in Finalizer seems a little wobbly. Regards, Peter On 05/18/2015 02:17 PM, Dmitry Samersoff wrote: Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part o

RFR [9] 8080502: Changing accessing module resources

Hi everybody, this is a review request for 8080502: Changing accessing module resources. This change adapts to Jigsaw JDK runtime - it isn't possible to access module resource using Class::getResource() any more. JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.

Re: RFR(XS) : 8055269 : java/lang/invoke/MethodHandles/CatchExceptionTest.java fails intermittently

Vladimir, thank you for review. regarding slot consumption calculation, to get parameters limited by slot number, the test uses Helper.getParams method which implements this calculation (test/lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java:133-148) -- Igor On 05/18/2015 09

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

Hi, On 05/18/2015 12:20 PM, Paul Sandoz wrote: Hi Stuart, I would like to suggest some tweaks to the specification to get across this method is transitioning control of traversal from enumeration to iterator. How about: Returns an iterator that traverses the remaining elements covered by

Re: RFR (XXS) 8080535: (ch) Expected size of Character.UnicodeBlock.map is not optimal

On May 18, 2015, at 8:52 PM, Martin Buchholz wrote: > On Fri, May 15, 2015 at 5:59 PM, Ivan Gerasimov > wrote: > >> >> >> On 16.05.2015 2:18, Martin Buchholz wrote: >> >> I wouldn't bother defining the constant. >> >> >> I only need it in the regression test, to check whether it was >> su

RE: Patch to improve primitives Array.sort()

An updated patch has been published to cr.openjdk via Paul: http://cr.openjdk.java.net/~psandoz/tmp/gs/sort/webrev.2/ Updates: The testcase has been updated to clone the array The redundant constant MAX_RUN_LENGTH has been removed. From: Paul Sandoz [mailto:paul.san...@oracle.com] Sent: 16 May 2

Re: RFR 9: 8077350 Process API Updates Implementation Review

Hi Roger, On 05/18/2015 11:49 PM, Roger Riggs wrote: The earlier spec specifically used the common pool but from a specification point of view it allows more flexibility in the implementation not to bind onExit to the commonPool. Its not clear that the attributes of threads used to handle outpu

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On 18 May 2015, at 23:45, Stuart Marks wrote: > …. > > http://cr.openjdk.java.net/~smarks/reviews/8072726/webrev.1/ This update looks better. -Chris. > Changes include: > > - updates to spec & examples per above > - converted NOTE in class doc to @apiNote > - Rémi's suggested simplifi

Re: Review Request for 8074431: Remove native2ascii tool

Looks good to me. /Erik On 2015-05-19 00:45, Mandy Chung wrote: This patch removes native2ascii command-line tool from JDK 9 as proposed in March [1]. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074431/webrev.00/ Jon - A langtools test is updated to use a new Native2Ascii.jav

Re: RFR(XS): JDK-8077866: [TESTBUG] Some of java.lang tests cannot be run on compact profiles 1, 2

On 19/05/2015 08:53, David Holmes wrote: Hi Denis, Looks okay to me. For now this is okay but I hope we can completely remove this unmaintainable section of the TEST.groups file once jtreg has support for selecting tests based on the run-time under test. -Alan

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

On May 19, 2015, at 12:45 AM, Stuart Marks wrote: > On 5/18/15 3:20 AM, Paul Sandoz wrote: >> I would like to suggest some tweaks to the specification to get across this >> method is transitioning control of traversal from enumeration to iterator. >> How about: >> >> Returns an iterator that

Re: RFR(XS): JDK-8077866: [TESTBUG] Some of java.lang tests cannot be run on compact profiles 1, 2

Hi Denis, Looks okay to me. Thanks, David On 18/05/2015 11:03 PM, denis kononenko wrote: Hi All, Please review the very small change in TEST.groups file. Webrev link: http://cr.openjdk.java.net/~skovalev/dkononen/8077866/webrev.00/ Bug id: JDK-8077866

Re: RFR(s): 8072726: add adapter to convert Enumeration to Iterator

Thumb up for me :) Rémi On 05/19/2015 12:45 AM, Stuart Marks wrote: On 5/18/15 3:20 AM, Paul Sandoz wrote: I would like to suggest some tweaks to the specification to get across this method is transitioning control of traversal from enumeration to iterator. How about: Returns an iter

Re: Review Request for 8074431: Remove native2ascii tool

On 18/05/2015 23:45, Mandy Chung wrote: This patch removes native2ascii command-line tool from JDK 9 as proposed in March [1]. Looks good. -Alan