Re: Review Request: 8080815: Update 8u jdeps list of internal APIs

On 21/05/15 02:57, Mandy Chung wrote: This is 8u only fix. https://bugs.openjdk.java.net/browse/JDK-8080815 https://bugs.openjdk.java.net/browse/JDK-8080815 Webrev: http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8080815/webrev.00/

Re: RFR (XXS) 8080535: (ch) Expected size of Character.UnicodeBlock.map is not optimal

On May 20, 2015, at 7:32 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Just had an idea... I believe static intializers are executed in textual order. So you could have a static code block after all static UnicodeBlock instances have been defined that asserts the size == 510 (or is =

Re: RFR: 8080608: Missing archive name from jdeps -v -e output if no dependency on other JAR

On 05/21/2015 07:25 AM, Daniel Fuchs wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8080608/webrev.02/ Looks good. It's fine to consider refactoring out the test library later on. Thanks Mandy

Re: RFR [9] 8080502: Changing accessing module resources

On 19/05/2015 10:38, Miroslav Kos wrote: : JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.01/index.html testing: JAX-WS unit test; basically it is fix for existing tests (JCK, ...) One thing that isn't obvious in this code is where

Re: RFR: JDK-8080248 Coding regression in HKSCS charsets

Looks good! I might add another sweeping random-based test to FindEncoderBugs like this: try to encode A + B where A and B are randomly chosen single chars or surrogate pairs, and check that encode(A + B) == encode(A) + encode(B) On Thu, May 21, 2015 at 12:51 PM, Xueming Shen

RFR 9: 8074818: Resolve disabled warnings for libjava

Please review these native code and build changes to clear compilation warnings. Most are due to mixing unsigned types with signed types or providing the correct type to an invoked function. Webrev: http://bussund0416.us.oracle.com/~rriggs/webrev/webrev-fix-all-warnings-8074818/ Issues:

Re: RFR: 8080608: Missing archive name from jdeps -v -e output if no dependency on other JAR

On 21/05/15 02:09, Mandy Chung wrote: Actually - I think the test should be type != Type.SUMMARY rather than type == Type.VERBOSE. jdeps has -filter:none option. $ jdeps -s -filter:none -e use.unsafe.UseUnsafeClass *.jar When -filter:none is used, I think it’s right for the summary page

JDK 9 RFR of JDK-8080901: Replace package.html files with package-info.java in the java.base module

Hello, Please review these changes to replace old-style package.html files with package-info.java files in the base module: JDK-8080901: Replace package.html files with package-info.java in the java.base module http://cr.openjdk.java.net/~darcy/8080901.0/ (The package.html file for

JEP 255: Merge Selected Xerces 2.11.0 Updates into JAXP

New JEP Candidate: http://openjdk.java.net/jeps/255 - Mark

Re: JDK 9 RFR of JDK-8080901: Replace package.html files with package-info.java in the java.base module

Hi Joe, I think this is OK. Best Lance On May 21, 2015, at 6:57 PM, joe darcy joe.da...@oracle.com wrote: Hello, Please review these changes to replace old-style package.html files with package-info.java files in the base module: JDK-8080901: Replace package.html files with

RE: Patch to improve primitives Array.sort()

Thanks Paul. Your proposed changes make sense to us and they have no discernable impact on the performance. Thanks Moh -Original Message- From: Paul Sandoz [mailto:paul.san...@oracle.com] Sent: Thursday, May 21, 2015 12:43 PM To: core-libs-dev@openjdk.java.net Libs Cc: Chan, Sunny

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

Oops, got the wrong host: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-fix-all-warnings-8074818/ Issues: 8074818: Resolve disabled warnings for libjava 8080007: Stop ignoring warnings for libjava Thanks, Roger On 5/21/15 8:34 PM, Ivan Gerasimov wrote: Hi Roger On 22.05.2015

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

Hi Roger On 22.05.2015 0:09, Roger Riggs wrote: Please review these native code and build changes to clear compilation warnings. Most are due to mixing unsigned types with signed types or providing the correct type to an invoked function. The code changes look good! Webrev:

RFR: JDK-8080248 Coding regression in HKSCS charsets

Hi Martin, Would you please help review this change ? Issue: https://bugs.openjdk.java.net/browse/JDK-8080248 webrev: http://cr.openjdk.java.net/~sherman/8080248/ Thanks! -Sherman

Re: RFR 8080640: Reduce copying when reading JAR/ZIP entries

On 05/20/2015 10:57 AM, Xueming Shen wrote: On 05/18/2015 06:44 PM, Staffan Friberg wrote: Hi, Wanted to get reviews and feedback on this performance improvement for reading from JAR/ZIP files during classloading by reducing unnecessary copying and reading the entry in one go instead of in

Re: Patch to improve primitives Array.sort()

Hi, I finally got some time to better understand the patch and more generally this area of code. I applied the patch and ran the existing sorting test [1] for both short and long runs and there was no issue. SortingPrimitiveTest -- I think this test should be placed under java/util/Arrays