Re: RFR: 8098547: (tz) Support tzdata2015e

FWIW, he do have one new test failure in Nashorn now, it seems related. Can you confirm it is caused by your changes? [testng] Test test/script/basic/NASHORN-627.js failed at line 1 - [testng] expected: 'Sun Dec 21 1969 00:00:00 GMT+0100 (CET) -95400 1969-12-20T23:00:00.000Z'

Re: [9] RFR of 8042377: BufferedWriter and FilteredOutputStream.close throw IAE if flush and close throw equal exceptions

On 24/06/2015 20:04, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8042377 Patch: http://cr.openjdk.java.net/~bpb/8042377/webrev.00/ The use of try-with-resources in FilteredOutputStream.close() is replaced with explicit handling

Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

Hi Joe, On 06/25/2015 07:30 PM, joe darcy wrote: Hi Zoltán, The changes to the wrapper classes (java.lang.Integer, java.lang.Double, ...), the Math and StrictMath libraries, and the new annotation type look fine. thank you for the review! Best regards, Zoltán Thanks, -Joe On

Re: RFR: 8098547: (tz) Support tzdata2015e

Attila, Yes - this looks strange to me too. I checked the tzdata releases and there was no changes to Europe/Vienna since the 2014g (http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f7de7da2eb58). And as Sean stated the 2015e wasn't pushed to 9-dev repo yet. But, this one [1] was pushed just today

[9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

Hi, please review the patch for JDK-8076112. Bug: https://bugs.openjdk.java.net/browse/JDK-8076112 Problem: There is need to indicate Java methods that are potentially intrinsified by JVM. Solution: Mark intrinsified methods with the jdk.internal.HotSpotIntrinsicCandidate annotation. Add

Re: RFR: 8098547: (tz) Support tzdata2015e

Yeah, basically instantiating a JavaScript native Date object with (70, 0, -10) and confirming it ends up being 10 days before epoch… This test failure happened tonight with jdk9, see http://sthci.se.oracle.com/job/nashorn/ http://sthci.se.oracle.com/job/nashorn/, so I presumed it has to be

Re: RFR/RFA (8u-dev) 8080524: [TESTBUG] java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails on compact profiles

On 25.06.2015 15:58, Alan Bateman wrote: On 25/06/2015 11:29, Ivan Gerasimov wrote: Hi David! The test fails when reading content of existing jsse.jar, which belongs to compact3 profile. When the test loads classes from this jar and tries to access their fields, it hits the types that

Re: [8u60] RFA 8129120 Terminal operation properties should not be back-propagated to upstream operations

On 23/06/15 13:13, Paul Sandoz wrote: On Jun 23, 2015, at 10:53 AM, Seán Coffey sean.cof...@oracle.com wrote: Hi Paul, Best to get a peer review on this before pushing to jdk8u-dev. Ok, including core-libs. The backport changes look good. Keeping the code in sync with 9 makes sense.

Re: RFR: 8098547: (tz) Support tzdata2015e

That looks like a strange failure Attila. The timezone in use for that testcase is Europe/Vienna. 2015e tzdata changes haven't been pushed to jdk9-dev forest yet. Where the 1969 date coming from ? Is there some rollover calculation happening ? Regards, Sean. On 25/06/2015 09:05, Attila

Re: RFR/RFA (8u-dev) 8080524: [TESTBUG] java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails on compact profiles

On 25/06/2015 11:29, Ivan Gerasimov wrote: Hi David! The test fails when reading content of existing jsse.jar, which belongs to compact3 profile. When the test loads classes from this jar and tries to access their fields, it hits the types that are not included in compact[12], thus

Re: RFR/RFA (8u-dev) 8080524: [TESTBUG] java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails on compact profiles

Hi David! The test fails when reading content of existing jsse.jar, which belongs to compact3 profile. When the test loads classes from this jar and tries to access their fields, it hits the types that are not included in compact[12], thus NoClassDefFoundError. I'm not certain, if it is a

Re: RFR: 8076139: [TEST_BUG] test/javax/xml/ws/8046817/GenerateEnumSchema.java creates files in test.src

Hi, Any comments on this changes? With Best Regards, Aleksej On 06/23/2015 07:02 PM, Aleksej Efimov wrote: Hi, Please, review, comment and approve GenerateEnumSchema.java test bug fix [1]. It solves the following problem: test launches schemagen tool from a 'test.src' folder and in cases

Re: RFR: 8098547: (tz) Support tzdata2015e

Hi Attila, Looks like it's a regression caused by the fix to 8008577, where the default locale data switched to Unicode Consortium's CLDR. Would you please file an issue? Naoto On 6/25/15 5:49 AM, Attila Szegedi wrote: Yeah, basically instantiating a JavaScript native Date object with (70,

Re: RFR: 8076139: [TEST_BUG] test/javax/xml/ws/8046817/GenerateEnumSchema.java creates files in test.src

Hi Aleksej! Would it make sense to use jdk.testlibrary.JDKToolLauncher to run schemagen? This way the test would become somewhat shorter. Sincerely yours, Ivan On 25.06.2015 17:31, Aleksej Efimov wrote: Hi, Any comments on this changes? With Best Regards, Aleksej On 06/23/2015 07:02 PM,

Re: RFR: 8098547: (tz) Support tzdata2015e

Sure; filed https://bugs.openjdk.java.net/browse/JDK-8129881 https://bugs.openjdk.java.net/browse/JDK-8129881. (Removed Seán Coffey from the recipient list as this is not a JDK8 issue.) Attila. On Jun 25, 2015, at 5:16 PM, Naoto Sato naoto.s...@oracle.com wrote: Hi Attila, Looks like

RfR: 8129880 - Cleanup usage of Class.getResource in jaxp

Hi, Please find below a cleanup patch for jaxp: https://bugs.openjdk.java.net/browse/JDK-8129880 8129880 - Cleanup usage of getResource in jaxp Class.getResource(classFile) was used for printing the class location for debuging purposes. CodeSource.getLocation() is a better fit for that.

Re: RFR/RFA (8u-dev) 8080524: [TESTBUG] java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails on compact profiles

On 25/06/2015 14:08, Ivan Gerasimov wrote: Yes. This is it! Would it make sense then to simply skip jsse.jar when executing the test in compact[12]? I guess It should be possible to determine that by checking the properties profile.compact1 and profile.compact2 aren't nulls. There aren't any

JDK 9 RFR of JDK-8129624: Move jdk_rmi test group from tier 2 to tier 3

Hello, As a follow-up to recent discussions on jdk9-dev, http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html please view the patch below to move the rmi test group from tier 2 to tier 3. Thanks, -Joe diff -r 65f38133842d test/TEST.groups --- a/test/TEST.groupsThu Jun

Re: JDK 9 RFR of JDK-8129624: Move jdk_rmi test group from tier 2 to tier 3

On 25/06/2015 17:52, joe darcy wrote: Hello, As a follow-up to recent discussions on jdk9-dev, http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html please view the patch below to move the rmi test group from tier 2 to tier 3. This looks okay to me. Hopefully some day it

Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

Hi Zoltán, The changes to the wrapper classes (java.lang.Integer, java.lang.Double, ...), the Math and StrictMath libraries, and the new annotation type look fine. Thanks, -Joe On 6/25/2015 4:49 AM, Zoltán Majó wrote: Hi, please review the patch for JDK-8076112. Bug:

Re: RFR 6415680 handle windows EXCEPTION_IN_PAGE_ERROR just as SIGBUS is handled

bcc'ing core-libs and cc'ing hotspot-runtime (even though the issue is filed under hotspot-compiler). On 24/06/2015 4:30 PM, Alan Bateman wrote: On 23/06/2015 23:14, Kirk Shoop (MS OPEN TECH) wrote: Hi, webrev http://cr.openjdk.java.net/~kshoop/6415680/ bug:

Re: RFR: JDK-8080679: Include jline in JDK for Java and JavaScript REPLs

Hello, Based on the feedback I've received so far, I've uploaded an updated version of the patch: http://cr.openjdk.java.net/~jlahoda/8080679/webrev.01/full/ Notable changes: -avoided the dependency on java.desktop and java.datatransfer -adjusted the native library build script as per Erik's

Re: RFR: JDK-8080679: Include jline in JDK for Java and JavaScript REPLs

On 25/06/2015 17:25, Jan Lahoda wrote: Hello, Based on the feedback I've received so far, I've uploaded an updated version of the patch: http://cr.openjdk.java.net/~jlahoda/8080679/webrev.01/full/ Notable changes: -avoided the dependency on java.desktop and java.datatransfer -adjusted the

Re: RfR: 8129880 - Cleanup usage of Class.getResource in jaxp

On Jun 25, 2015, at 8:46 AM, Daniel Fuchs daniel.fu...@oracle.com wrote: Hi, Please find below a cleanup patch for jaxp: https://bugs.openjdk.java.net/browse/JDK-8129880 8129880 - Cleanup usage of getResource in jaxp Class.getResource(classFile) was used for printing the class

Re: RfR: 8129880 - Cleanup usage of Class.getResource in jaxp

+1 Thanks, Joe On 6/25/2015 8:46 AM, Daniel Fuchs wrote: Hi, Please find below a cleanup patch for jaxp: https://bugs.openjdk.java.net/browse/JDK-8129880 8129880 - Cleanup usage of getResource in jaxp Class.getResource(classFile) was used for printing the class location for debuging

Re: JDK 9 RFR of JDK-8129624: Move jdk_rmi test group from tier 2 to tier 3

On 6/25/15 9:56 AM, Alan Bateman wrote: On 25/06/2015 17:52, joe darcy wrote: As a follow-up to recent discussions on jdk9-dev, http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html please view the patch below to move the rmi test group from tier 2 to tier 3. This looks

Re: [9] RFR of 8042377: BufferedWriter and FilteredOutputStream.close throw IAE if flush and close throw equal exceptions

Hi Peter, Thanks for the code change suggestion. I have modified the patch to use its logic and to revert to the original boolean instance variable instead of the contentious AtomicBoolean: http://cr.openjdk.java.net/~bpb/8042377/webrev.02/ The test passes unchanged. Push will be withheld

Re: RFR: 8076139: [TEST_BUG] test/javax/xml/ws/8046817/GenerateEnumSchema.java creates files in test.src

Hi Ivan! Thanks for suggestions. Also I took an opportunity and rewrote it to testNG format + cleaned it up and modified schema content check logic. Now test looks more readable: http://cr.openjdk.java.net/~aefimov/8076139/9/01 With Best Regards, Aleksej On 06/25/2015 05:54 PM, Ivan

Re: [9] RFR of 8042377: BufferedWriter and FilteredOutputStream.close throw IAE if flush and close throw equal exceptions

Hi Brian, On 06/24/2015 09:04 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8042377 Patch: http://cr.openjdk.java.net/~bpb/8042377/webrev.00/ The use of try-with-resources in FilteredOutputStream.close() is replaced with

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

Hi Frank, I could push it for you. -- daniel On 6/25/15 5:05 AM, Frank Yuan wrote: So, would you like to push the code for me? Best Regards Frank -Original Message- From: huizhe wang [mailto:huizhe.w...@oracle.com] Sent: Thursday, June 25, 2015 12:57 AM To: Daniel Fuchs Cc: Frank

RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

Alright, thanks a lot! :) Best Regards Frank -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Sent: Thursday, June 25, 2015 2:34 PM To: Frank Yuan; 'huizhe wang' Cc: 'core-libs-dev'; 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti';