Re: @Finalized

2015-08-26 Thread Andrew Dinn
On 26/08/15 20:01, Aleksey Shipilev wrote: > On 08/26/2015 06:07 PM, Doug Lea wrote: >> On 08/26/2015 10:12 AM, Andrew Haley wrote: >>> On 08/26/2015 03:01 PM, Doug Lea wrote: This is an issue of large importance to a small audience, and is at the moment an orphan. To work out, I think it

Re: @Finalized

2015-08-26 Thread Aleksey Shipilev
On 08/26/2015 06:07 PM, Doug Lea wrote: > On 08/26/2015 10:12 AM, Andrew Haley wrote: >> On 08/26/2015 03:01 PM, Doug Lea wrote: >>> This is an issue of large importance to a small audience, >>> and is at the moment an orphan. To work out, I think it >>> requires at least some involvement from comp

Re: U60 change makes annotations visible in synthesized methods, causes CDI to see lambdas as observer methods

2015-08-26 Thread Brian Goetz
> On Wed, Aug 26, 2015 at 4:28 PM, Remi Forax wrote: >> IMO, it seems to be a bug of the CDI implementation, >> as you said the method corresponding to the lambda body is synthetized so it >> should be ignored by the CDI implementation, no ? I concur with Remi’s prescription; CDI should be ignor

Re: jtreg test failure

2015-08-26 Thread Maurizio Cimadamore
Thanks for investigating this! Maurizio On 26/08/15 17:48, Naoto Sato wrote: Turned out it was indeed failing in Ireland locale. Filed the following bug, and the review request will follow. https://bugs.openjdk.java.net/browse/JDK-8134520 Naoto On 8/25/15 10:51 AM, Naoto Sato wrote: On 8/2

Re: [9] RFR: 8134520: Bug8134250 test fails in en_IE locale

2015-08-26 Thread Lance Andersen
Looks OK Naoto Best Lnace On Aug 26, 2015, at 12:52 PM, Naoto Sato wrote: > Hello, > > Please review a simple fix for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8134520 > > The proposed change is located at: > > http://cr.openjdk.java.net/~naoto/8134520/webrev.00/ > >

[9] RFR: 8134520: Bug8134250 test fails in en_IE locale

2015-08-26 Thread Naoto Sato
Hello, Please review a simple fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8134520 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8134520/webrev.00/ The fix is to simply set the en_US locale to the formatter. Naoto

Re: jtreg test failure

2015-08-26 Thread Naoto Sato
Turned out it was indeed failing in Ireland locale. Filed the following bug, and the review request will follow. https://bugs.openjdk.java.net/browse/JDK-8134520 Naoto On 8/25/15 10:51 AM, Naoto Sato wrote: On 8/25/15 10:14 AM, Maurizio Cimadamore wrote: On 25/08/15 18:04, Naoto Sato wrote

Re: U60 change makes annotations visible in synthesized methods, causes CDI to see lambdas as observer methods

2015-08-26 Thread arjan tijms
Hi, On Wed, Aug 26, 2015 at 4:28 PM, Remi Forax wrote: > IMO, it seems to be a bug of the CDI implementation, > as you said the method corresponding to the lambda body is synthetized so it > should be ignored by the CDI implementation, no ? Yes I agree that might be another possibility. I'll br

Re: @Finalized

2015-08-26 Thread Doug Lea
On 08/26/2015 10:12 AM, Andrew Haley wrote: On 08/26/2015 03:01 PM, Doug Lea wrote: This is an issue of large importance to a small audience, and is at the moment an orphan. To work out, I think it requires at least some involvement from compiler and/or IDE developers. If you are or know of some

Re: U60 change makes annotations visible in synthesized methods, causes CDI to see lambdas as observer methods

2015-08-26 Thread Remi Forax
IMO, it seems to be a bug of the CDI implementation, as you said the method corresponding to the lambda body is synthetized so it should be ignored by the CDI implementation, no ? BTW, it's the wrong list, lambdas are delivered so you should have use core-lib-dev instead (in CC). cheers, Rémi

Re: @Finalized

2015-08-26 Thread Andrew Haley
On 08/26/2015 03:01 PM, Doug Lea wrote: > This is an issue of large importance to a small audience, > and is at the moment an orphan. To work out, I think it > requires at least some involvement from compiler and/or IDE > developers. If you are or know of someone who might be interested > in pursui

@Finalized

2015-08-26 Thread Doug Lea
In the course of JEP 188/193 related efforts, it has been pointed out a few times that, as part of these efforts, finally adding method reachabilityFence(ref) with tentative spec pasted below should be the first of two steps in helping developers avoid premature finalization and reclamation. Th

Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-26 Thread Alan Bateman
On 25/08/2015 20:30, Lance Andersen wrote: Ok, to keep things simple for now, I removed the dependency on the java/sql BaseTest webrev has been updated Okay although my comment about the previous iteration was mostly just pointing out that generic infrastructure should be in the sql direct