Re: RFR 8135248: Add utility methods to check indexes and ranges

On 24 Sep 2015, at 08:40, Paul Sandoz wrote: > On 23 Sep 2015, at 18:11, Rémi Forax wrote: >>> >>> Because i want to support the simple cases without pulling in indy. >> >> and what about using an anonymous class instead ? >> > > Not an anonymous

Re: RFR 8135248: Add utility methods to check indexes and ranges

On 24 Sep 2015, at 11:06, Chris Hegarty wrote: > On 24 Sep 2015, at 08:40, Paul Sandoz wrote: > >> On 23 Sep 2015, at 18:11, Rémi Forax wrote: Because i want to support the simple cases without pulling in indy.

Re: RFR [9] 8133651: replace some tags (obsolete in html5) in core-libs docs

Hello Martin, Thank you for review and for the notes! > I'm biased of course, but I like the approach I took with blessed-modifier-order: > - make the change completely automated > - leave "human editing" for a separate change > - publish the code used to make the automated change (in my

specdiff Re: RFR: jsr166 openjdk9 integration

On 23 Sep 2015, at 23:41, Paul Sandoz wrote: >> If you generate a public specdiff (as I believe only Oracle folks can), it >> would be easier for all of us to review the spec changes. >> > > Yes, Roger also suggested the same to me off list. May happen tomorrow. >

Re: RFR 8135248: Add utility methods to check indexes and ranges

On 23 Sep 2015, at 18:11, Rémi Forax wrote: >> >> Because i want to support the simple cases without pulling in indy. > > and what about using an anonymous class instead ? > Not an anonymous one, but i think i know what you mean :-) Also, i don’t want to impose a null

[9] RFR: 8061466 - RELAX NG API visible but not accessible

Hi everybody, I'd like to ask for review of following fix: RELAX NG API visible but not accessible JBS: https://bugs.openjdk.java.net/browse/JDK-8061466 webrev: http://cr.openjdk.java.net/~mkos/8061466/jaxws.01/index.html - org.relaxng.* classes in jdk.xml.bind module are not repackaged, but

RFR 9: 8129744 : Documentation in Month refers to quarters

Please review two java.time editorial changes: - 8129744: a trivial editorial change in java.time.Month javadoc. - 8129556: TemporalAdjusters dayOfWeekInMonth wrongly says "in the same month" Webrev: http://cr.openjdk.java.net/~rriggs/webrev-months-8129744/ Issue:

Re: RFR: jsr166 openjdk9 integration

I ran the patches through JPRT. I am noticing one test failure that i cannot reproduce locally but reproduces on some test machines. java.lang.Exception: Stack trace at java.lang.Thread.dumpStack(Thread.java:1335) at FlakyThreadFactory.fail(FlakyThreadFactory.java:93) at

Re: RFR [9] 8137056: Move SharedSecrets and interface friends out of sun.misc

Hi Chris, Looks ok. Roger On 9/24/2015 10:16 AM, Chris Hegarty wrote: In preparation for JEP 260 "Encapsulate Most Internal APIs” [1], SharedSecrets and friend interfaces should be moved out of 'sun.misc’ [2] and located in a truly private package. This is so that they are not part of the

Re: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of strerr in getLastErrorString

Hi folks, Uploaded a newer version: http://cr.openjdk.java.net/~robm/8133249/webrev.02/ To address Rogers question, this needed to be separate from getLastErrorString because of the return type and the err arg, but I like the idea of avoiding the creation of a new file. Also, all of the

RFR [9] 8137056: Move SharedSecrets and interface friends out of sun.misc

In preparation for JEP 260 "Encapsulate Most Internal APIs” [1], SharedSecrets and friend interfaces should be moved out of 'sun.misc’ [2] and located in a truly private package. This is so that they are not part of the proposed to be exported ‘sun.misc' package.

Re: RFR [9] 8137056: Move SharedSecrets and interface friends out of sun.misc

On 24 Sep 2015, at 15:37, Alan Bateman wrote: > On 24/09/2015 15:16, Chris Hegarty wrote: >> In preparation for JEP 260 "Encapsulate Most Internal APIs” [1], >> SharedSecrets and friend interfaces should be moved out of >> 'sun.misc’ [2] and located in a truly private

Re: [9] RFR: 8061466 - RELAX NG API visible but not accessible

Miran, Did you use 'hg mv’? if so, then webrev ( without a file.list ) typically picks up that the file has moved and only highlights the differences. This typically helps with the review. -Chris. On 24 Sep 2015, at 14:57, Miroslav Kos wrote: > Hi everybody, > > I'd

Re: RFR 9: 8129744 : Documentation in Month refers to quarters

The changes look good to me Roger. -Chris. On 24 Sep 2015, at 14:23, Roger Riggs wrote: > Please review two java.time editorial changes: > - 8129744: a trivial editorial change in java.time.Month javadoc. > - 8129556: TemporalAdjusters dayOfWeekInMonth wrongly says

Re: [9] RFR: 8061466 - RELAX NG API visible but not accessible

On 24/09/2015 14:57, Miroslav Kos wrote: Hi everybody, I'd like to ask for review of following fix: RELAX NG API visible but not accessible JBS: https://bugs.openjdk.java.net/browse/JDK-8061466 webrev: http://cr.openjdk.java.net/~mkos/8061466/jaxws.01/index.html - org.relaxng.* classes in

Re: RFR 9: 8129744 : Documentation in Month refers to quarters

+1 Stephen On 24 September 2015 at 14:23, Roger Riggs wrote: > Please review two java.time editorial changes: > - 8129744: a trivial editorial change in java.time.Month javadoc. > - 8129556: TemporalAdjusters dayOfWeekInMonth wrongly says "in the same > month" > >

Re: RFR [9] 8137056: Move SharedSecrets and interface friends out of sun.misc

On 24/09/2015 15:16, Chris Hegarty wrote: In preparation for JEP 260 "Encapsulate Most Internal APIs” [1], SharedSecrets and friend interfaces should be moved out of 'sun.misc’ [2] and located in a truly private package. This is so that they are not part of the proposed to be exported ‘sun.misc'

RFR: 8135124 - com/sun/jndi/ldap/LdapTimeoutTest.java failed intermittently

Hi folks, I'd like to comment the ReadTimeoutTest part of this test for now as it appears to be causing intermittent failures. (on the understanding that these failures will be investigated separately) http://cr.openjdk.java.net/~robm/8135124/webrev.01/ -Rob

Re: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of strerr in getLastErrorString

On Sep 24, 3:10pm, rob.mcke...@oracle.com (Rob McKenna) wrote: -- Subject: Re: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of str | Hi folks, | | Uploaded a newer version: | | http://cr.openjdk.java.net/~robm/8133249/webrev.02/ | | To address Rogers question, this needed to be

Re: RFR [9] 8137056: Move SharedSecrets and interface friends out of sun.misc

On 24/09/2015 15:56, Chris Hegarty wrote: : Ah ha, good catch. Fixed and webrev updated in-place. Looks okay. Offline, Paul queried whether the modules now using jdk.internal.misc still require access to sun.misc. They do, all but one java.sql. I updated the modules.xml to reflect this.

Re: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of strerr in getLastErrorString

Thanks Rob! The webrev looks cleaner. jni_util.h: Wouldn't it be better to move this block directly to the jni_util_md.c file? 390 #if defined(LINUX) && (defined(_GNU_SOURCE) || \ 391 (defined(_POSIX_C_SOURCE) && _POSIX_C_SOURCE < 200112L \ 392 && defined(_XOPEN_SOURCE)

Re: RFR: 8135124 - com/sun/jndi/ldap/LdapTimeoutTest.java failed intermittently

+1 On 9/24/2015 11:03 AM, Rob McKenna wrote: Hi folks, I'd like to comment the ReadTimeoutTest part of this test for now as it appears to be causing intermittent failures. (on the understanding that these failures will be investigated separately)

Re: RFR [9] 8137056: Move SharedSecrets and interface friends out of sun.misc

On 24 Sep 2015, at 16:16, Chris Hegarty wrote: > In preparation for JEP 260 "Encapsulate Most Internal APIs” [1], > SharedSecrets and friend interfaces should be moved out of > 'sun.misc’ [2] and located in a truly private package. This is so that > they are not part

Re: RFR: jsr166 openjdk9 integration

On 24 Sep 2015, at 00:22, Martin Buchholz wrote: > > On Wed, Sep 23, 2015 at 2:41 PM, Paul Sandoz wrote: > On 23 Sep 2015, at 21:33, Martin Buchholz wrote: >> >> >> In Helpers: >> >> 121 private static String

Re: RFR: jsr166 openjdk9 integration

FlakyThreadFactory fixed: (It would be nice if hotspot was consistent about the way it failed, regardless of platform) "Write once, fail anywhere" Index: src/test/jtreg/util/concurrent/ThreadPoolExecutor/FlakyThreadFactory.java ===

JEP 254: Compact Strings thoughts: character ranges outside ASCII + EASCII blocks

[Some of this is may simple or prohibitively tricksy depending on alignment constraints (even though it's restricted to Prime Multilingual Plane :-) ] For some not un-realistic use cases, the most significant bytes for all the characters in a string are identical, even if the string is non-latin.

Re: RFR: jsr166 openjdk9 integration

I changed my export script to also publish my mercurial queues patches directory. Find it at http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/patches/