Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

On 17/02/2016 21:21, Rachel Protacio wrote: Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is most likely. There is currently a compatibility request in the approval process. Here is

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

On 18/02/2016 1:49 AM, Roger Riggs wrote: Hi David, On 2/17/2016 3:33 AM, David Holmes wrote: Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks for those tweaks. I'm still perplexed by th

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

Hi Rachel, On 18/02/2016 7:21 AM, Rachel Protacio wrote: Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is most likely. There is currently a compatibility request in the approval process.

Re: RFR: JDK-8149925 We don't need jdk.internal.ref.Cleaner any more

> On Feb 17, 2016, at 4:06 AM, Peter Levart wrote: > > Hi Kim, > > Thanks for looking into this. Answers inline… Peter, Thanks for the explanations. > On 02/17/2016 01:20 AM, Kim Barrett wrote: >>> However, I recall Roger saying there were existing tests that >> failed when certain uses of su

Re: RFR (JAXP) 8146237: PREFER from Features API taking precedence over catalog file

Thanks Lance! On 2/17/2016 12:46 PM, Lance Andersen wrote: looks OK Joe On Feb 16, 2016, at 8:31 PM, huizhe wang > wrote: Hi, Please review a fix on missing property settings read from catalog files. Values from catalog files shall override any other settings

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is most likely. There is currently a compatibility request in the approval process. Here is the updated code, which builds properly and stil

Re: RFR (JAXP) 8146237: PREFER from Features API taking precedence over catalog file

looks OK Joe On Feb 16, 2016, at 8:31 PM, huizhe wang wrote: > Hi, > > Please review a fix on missing property settings read from catalog files. > Values from catalog files shall override any other settings including those > through the API, e.g. builder().with(CatalogFeatures.Feature.PREFER,

Re: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

Hi Langer, Thanks for working on the patch. On 2/17/2016 8:27 AM, Langer, Christoph wrote: Hi Joe, here's my next version, trying to implement your suggestions: http://cr.openjdk.java.net/~clanger/webrevs/8149915.1/ Looks good in general. I also took the chance to do some cleanups and typ

Re: Review Request: 8074069: Move JDK-specific API to jdk.* module

On 17/02/2016 19:31, Mandy Chung wrote: This patch prepares to move closed JDK-specific APIs from java.base to jdk.net module as specified in the design principles in JEP 200 that standard modules should not non-standard APIs. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074069

Review Request: 8074069: Move JDK-specific API to jdk.* module

This patch prepares to move closed JDK-specific APIs from java.base to jdk.net module as specified in the design principles in JEP 200 that standard modules should not non-standard APIs. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074069/webrev.00/index.html Mandy

Re: JDK 9 RFR of JDK-8149920: Remove intermittent key from jdk_core tests

Hi Amy, Looks fine; thanks, -Joe On 2/17/2016 5:09 AM, Amy Lu wrote: sun/nio/cs/FindEncoderBugs.java sun/nio/cs/FindDecoderBugs.java java/util/concurrent/Phaser/Basic.java java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java java/net/SocketPermission/SocketPermissionTest.java ja

RE: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

Hi Joe, here's my next version, trying to implement your suggestions: http://cr.openjdk.java.net/~clanger/webrevs/8149915.1/ I also took the chance to do some cleanups and type check fixes. Hope that's ok? I'm also wondering why some files have a copyright header like this, e.g. src/java.xml/s

Re: RFR: JDK-8149925 We don't need jdk.internal.ref.Cleaner any more

On 02/17/2016 10:06 AM, Peter Levart wrote: On 02/17/2016 01:20 AM, Kim Barrett wrote: src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java I don't understand why CleanerImpl needs to be changed to public in order to provide access to the new drainQueue. Wouldn't it be better to a

Re: RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class

On 02/17/2016 07:10 PM, Alan Bateman wrote: > > > On 17/02/2016 13:41, Aleksey Shipilev wrote: >> : >> >> Alan, Mandy, would you like to review this as well? This should fix Jake >> compatibility problems. >> >> > Yes, I think this is okay although we'll need to look at the IMPL_LOOKUP > usage wh

Re: RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class

On 17/02/2016 13:41, Aleksey Shipilev wrote: : Alan, Mandy, would you like to review this as well? This should fix Jake compatibility problems. Yes, I think this is okay although we'll need to look at the IMPL_LOOKUP usage when we get this to jake. -Alan

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi, ok. A release note will be needed to document the new property. Please add the label 'release-note' and a separate comment with the proposed release note text. Thanks, Roger On 2/17/2016 10:17 AM, cheleswer sahu wrote: Hi, I have made changes in the property name (jdk.lang.processReape

Re: RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class

> On Feb 17, 2016, at 5:41 AM, Aleksey Shipilev > wrote: > > On 02/17/2016 01:48 PM, Paul Sandoz wrote: >>> On 17 Feb 2016, at 10:36, Aleksey Shipilev >>> wrote: >>> Yes: >>> http://cr.openjdk.java.net/~shade/8149835/webrev.jdk.02/ >>> http://cr.openjdk.java.net/~shade/8149835/webrev.langtool

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

Hi David, On 2/17/2016 3:33 AM, David Holmes wrote: Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks for those tweaks. I'm still perplexed by the test. We established that for USR2, PIPE

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi, I have made changes in the property name (jdk.lang.processReaperUseDefaultStackSize) and code as suggested in the earlier reviews. --- old/src/java.base/share/classes/java/lang/ProcessHandleImpl.java 2016-02-17 18:48:10.54563 +0530 +++ new/src/java.base/share/classes/java/lang/Proces

RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi All, Please review fix for the following bug- https://bugs.openjdk.java.net/browse/JDK-8144931 http://cr.openjdk.java.net/~srastogi/8144931/webrev.01/ Thanks, Shilpi

Re: RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class

On 02/17/2016 01:48 PM, Paul Sandoz wrote: >> On 17 Feb 2016, at 10:36, Aleksey Shipilev >> wrote: >> Yes: >> http://cr.openjdk.java.net/~shade/8149835/webrev.jdk.02/ >> http://cr.openjdk.java.net/~shade/8149835/webrev.langtools.01/ >> >> I have also changed to Lookup.IMPL_LOOKUP when looking u

JDK 9 RFR of JDK-8149922: Remove intermittent key from security tests

sun/security/mscapi/ShortRSAKey1024.sh sun/security/mscapi/SignUsingSHA2withRSA.sh javax/net/ssl/SSLSession/SessionCacheSizeTests.java For above tests, previous intermittent test failure issues are fixed, no open bug (no failure reported). This patch is to remove @key intermittent from tests.

JDK 9 RFR of JDK-8149920: Remove intermittent key from jdk_core tests

sun/nio/cs/FindEncoderBugs.java sun/nio/cs/FindDecoderBugs.java java/util/concurrent/Phaser/Basic.java java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java java/net/SocketPermission/SocketPermissionTest.java java/lang/ProcessHandle/InfoTest.java com/sun/jndi/ldap/LdapTimeoutTest.java

Re: RFR: 8072727 - add variation of Stream.iterate() that's finite

Hello! Thank you for your comments. The thing which is absolutely necessary is to make PECS Predicate signature (for some reason I forgot it): static Stream iterate(T seed, Predicate predicate, UnaryOperator f) { ... } While you cannot readily make Stream from it, it's not a big problem if

Re: RFR: JDK-8149925 We don't need jdk.internal.ref.Cleaner any more

On 16/02/2016 16:15, Peter Levart wrote: : and the following two, which seem to not like my network config. or something like that: java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java: Unit test for DatagramChannel's multicast support java/nio/channels/DatagramChannel/Promiscuo

Re: RFR[9] 8068686: Remove meta-index support

On 16/02/2016 20:39, Mandy Chung wrote: : I assume at some point the classlist under jdk/make/tools/classlist will be updated. They currently reference several sun.misc types that you have removed or renamed. The classlist is out of date but I think Claes is looking at better ways to do t

Re: RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class

> On 17 Feb 2016, at 10:36, Aleksey Shipilev > wrote: > > On 02/16/2016 11:59 PM, Andrej Golovnin wrote: >> Hi Aleksey, >> >>> http://cr.openjdk.java.net/~shade/8149835/webrev.jdk.01/ >> >> 701 return (pkg != null ? pkg.getName().replace(".", >> "/") + "/" : "") + "Stubs$

Re: RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class

On 02/16/2016 11:59 PM, Andrej Golovnin wrote: > Hi Aleksey, > >> http://cr.openjdk.java.net/~shade/8149835/webrev.jdk.01/ > > 701 return (pkg != null ? pkg.getName().replace(".", "/") > + "/" : "") + "Stubs$$StringConcat"; > 702 } else { > 703

Re: RFR: JDK-8149925 We don't need jdk.internal.ref.Cleaner any more

Hi Kim, Thanks for looking into this. Answers inline... On 02/17/2016 01:20 AM, Kim Barrett wrote: On Feb 16, 2016, at 11:15 AM, Peter Levart wrote: Hello everybody, Thanks for looking into this and for all your comments. Now that it seems we have a consensus that replacing internal Cleaner

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks for those tweaks. I'm still perplexed by the test. We established that for USR2, PIPE and XFSZ the handler is not actually invoked - yet yo