Hi Volker,
On 21/07/2016 4:49 AM, Volker Simonis wrote:
Hi,
can somebody please review the following trivial fix:
http://cr.openjdk.java.net/~simonis/webrevs/2016/8161951/
https://bugs.openjdk.java.net/browse/JDK-8161951
Change '8132379: -J options can cause crash or "Warning: app args
parsin
Hi, Robert.
Thanks for Reviewing!
iris
-Original Message-
From: Robert Field
Sent: Wednesday, July 20, 2016 6:16 PM
To: Iris Clark; Kumar Srinivasan; Java Core Libs;
compiler-...@openjdk.java.net; kulla-...@openjdk.java.net
Subject: Re: RFR(s) 8161236: Runtime.Version.{compareTo, equal
Thumbs up on JShell change.
-Robert
On 07/20/16 13:10, Iris Clark wrote:
Hi.
Please review changes in jdk and langtools (module jdk.jshell) to address the
following bug:
8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed
https://bugs.openjdk.java.net/browse/JDK
Hi.
Please review changes in jdk and langtools (module jdk.jshell) to address the
following bug:
8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed
https://bugs.openjdk.java.net/browse/JDK-8161236
Webrev:
http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0
On 20/07/2016 20:51, Naoto Sato wrote:
Hello,
Please review this small fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8161937
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8161937/webrev.00/
This is just to replace those non-ASCII characters used
Hello,
Please review this small fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8161937
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8161937/webrev.00/
This is just to replace those non-ASCII characters used in comments with
the equivalents in ASCII
Hi,
can somebody please review the following trivial fix:
http://cr.openjdk.java.net/~simonis/webrevs/2016/8161951/
https://bugs.openjdk.java.net/browse/JDK-8161951
Change '8132379: -J options can cause crash or "Warning: app args
parsing error passing arguments as-is"' uses the following non AN
Hello,
I have my own stream which does that (however mostly on the classes,
not array size) and I used a Predicate functional interface for the
filtering.
I also have a prefix checking white and blacklist implementation for
it. (using a sorted array and binary search).
I try to et the code onlin
http://cr.openjdk.java.net/~jlaskey/8158407/webrev/index.html
https://bugs.openjdk.java.net/browse/JDK-8158407
Will do, thanks, Roger
On 7/20/2016 10:22 AM, Daniel Fuchs wrote:
Hi Roger,
3901 /**
3902 * Method for getting the array size for any array.
3903 */
3904 private static int arrayLength(Object array) {
why not using java.lang.reflect.Array::getLength?
best regards,
-- danie
Hi Peter,
On 7/20/2016 4:19 AM, Peter Levart wrote:
Hi Roger,
On first reading, I have the following thoughts:
- The name "ObjectInputFilter" makes me think that it is a function
that "filters" the input stream (like a Predicate in
Stream::filter(Predicate)), but it is in fact a validator th
Hi Roger,
3901 /**
3902 * Method for getting the array size for any array.
3903 */
3904 private static int arrayLength(Object array) {
why not using java.lang.reflect.Array::getLength?
best regards,
-- daniel
On 19/07/16 15:02, Roger Riggs wrote:
Please review the design, i
Hi Max,
The use of filtering needs to be very intentional and so an
implementation should be required.
I don't expect there to be additional methods and if so a default for
checkInput could be added at that time.
Roger
On 7/19/2016 11:18 PM, Wang Weijun wrote:
The ObjectInputFilter interfa
Hi Roger,
On first reading, I have the following thoughts:
- The name "ObjectInputFilter" makes me think that it is a function that
"filters" the input stream (like a Predicate in
Stream::filter(Predicate)), but it is in fact a validator that
terminates deserialization on 1st rejection. So pe
14 matches
Mail list logo
