RFR (JDK 10) 8172298: Reduce memory churn when linking VarHandles operations

2017-01-27 Thread Paul Sandoz
Hi, Please review some small memory-based optimisations for VarHandle linkage: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8172298-varhandle-link-reduce-memory/webrev/ This will be pushed to the

Re: RFR: 8172309: classpath wildcards code does not support --class-path

2017-01-27 Thread Henry Jen
How about following patch instead for langtools repo? diff -r ef142ac9824e test/tools/javac/Paths/wcMineField.sh --- a/test/tools/javac/Paths/wcMineField.sh Thu Jan 26 16:53:56 2017 -0800 +++ b/test/tools/javac/Paths/wcMineField.sh Fri Jan 27 13:10:12 2017 -0800 @@ -26,7 +26,7 @@ # #

Re: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

2017-01-27 Thread Brent Christian
On 01/26/2017 05:07 PM, Brent Christian wrote: I also removed the more simplistic CountLocalSlots.java test, given that the updated LocalsAndOperands.java will now better cover testing -Xcomp. I also noticed that we no longer need the LocalsCrash.java test. Removed. -Brent

Re: RFR JDK-8173396:Error message issue with jar tool API validator

2017-01-27 Thread Paul Sandoz
+1 Paul. > On 26 Jan 2017, at 22:58, Xueming Shen wrote: > > Hi, > > Please review the change for JDK-8173396. > > issue: https://bugs.openjdk.java.net/browse/JDK-8173396 > webrev: http://cr.openjdk.java.net/~sherman/8173396/webrev > > The error message keys

Re: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

2017-01-27 Thread Brent Christian
On 01/27/2017 08:26 AM, Mandy Chung wrote: On Jan 26, 2017, at 5:07 PM, Brent Christian wrote: Webrev: http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/ I agree with Remi to make the MODE_* constants in LiveStackFrameInfo final and PrimitiveSlot::size()

Re: RFR JDK-8173396:Error message issue with jar tool API validator

2017-01-27 Thread Mandy Chung
> On Jan 26, 2017, at 10:58 PM, Xueming Shen wrote: > > Hi, > > Please review the change for JDK-8173396. > > issue: https://bugs.openjdk.java.net/browse/JDK-8173396 > webrev: http://cr.openjdk.java.net/~sherman/8173396/webrev > > The error message keys

Re: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

2017-01-27 Thread Mandy Chung
> On Jan 26, 2017, at 5:07 PM, Brent Christian > wrote: > > Hi, > > Please review my updated approach for fixing 8156073 ("2-slot > LiveStackFrame locals (long and double) are incorrect") in the experimental > portion of the StackWalker API, added in JDK 9. > >

RE: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

2017-01-27 Thread Ramanand Patil
Thank you Alan and Kumar for your review. Here is the updated webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.03 Changes done: 1. LinkageError in method loadMainClass is handled separately and with a new message in launcher.properties 2. Test case updated to print the error

Re: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

2017-01-27 Thread Remi Forax
Hi Brent, in LiveStackFrame, PrimitiveSlot.size() should be public. The other solution is to see PrimitiveValue as a technical factorisation of code, not something users should know, so it should be a public class but a package-private abstract class and PrimitiveSlot32/PrimitiveSlot64 should be