Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Lance, thanks for this review too! Best, Aleksei On 06/16/2017 07:20 PM, Lance Andersen wrote: Hi Aleks, This looks fine minus the request of Bill to revert. So no need to see the changes you reverted again Best Lance On Jun 16, 2017, at 12:17 PM, Aleks Efimov

Re: RFR: JDK-8181836 - BadKindHelper.html and BoundsHelper.html contains broken link in the javadoc

thanks Chris regards Mark On 16/06/2017 18:20, Chris Hegarty wrote: On 16 Jun 2017, at 17:31, Mark Sheppard wrote: Hi, please oblige and review the javadoc changes: http://cr.openjdk.java.net/~msheppar/8181836/webrev/ Looks good Mark. -Chris.

Re: [8u-dev] RFR (JAXWS): 8172297: In java 8, the marshalling with JAX-WS does not escape carriage return

Thank you for the review, Lance! On 06/16/2017 07:22 PM, Lance Andersen wrote: Hi Aleks, The changes looked fine to me. Best Lance On Jun 9, 2017, at 10:10 AM, Aleks Efimov > wrote: Hello, Please, help to review the fix that helps JAXWS marshaller to prope

Re: [8u-dev] RFR (JAXWS): 8172297: In java 8, the marshalling with JAX-WS does not escape carriage return

Hi Aleks, The changes looked fine to me. Best Lance > On Jun 9, 2017, at 10:10 AM, Aleks Efimov wrote: > > Hello, > > Please, help to review the fix that helps JAXWS marshaller to properly escape > new-line and carriage return symbols in webservice string parameters: > http://cr.openjdk.java.

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Aleks, This looks fine minus the request of Bill to revert. So no need to see the changes you reverted again Best Lance > On Jun 16, 2017, at 12:17 PM, Aleks Efimov wrote: > > Hi, > > Please, help to review the latest changes that addresses the following > comments: > 1. JAXBContext fo

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Thank you, Mandy! Best, Aleksei On 06/16/2017 06:19 PM, Mandy Chung wrote: On Jun 16, 2017, at 9:17 AM, Aleks Efimov wrote: : 4. Update jdk/test/jdk/modules/etc/JdkQualifiedExportTest.java to remove "java.xml/com.sun.xml.internal.stream.writers” from KNOWN_EXCEPTION. Removed "java.xml/c

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

> On 14 Jun 2017, at 23:29, Hamlin Li wrote: > > Hi Alan, Paul, > > Thank you for review, new webrev at: > http://cr.openjdk.java.net/~mli/8181478/webrev.01/ > > Please also check my comments inline. > > > On 2017/6/15 1:28, Alan Bateman wrote: >> >> On 14/06/2017 18:20, Paul Sandoz wrote:

Re: RFR: JDK-8181836 - BadKindHelper.html and BoundsHelper.html contains broken link in the javadoc

> On 16 Jun 2017, at 17:31, Mark Sheppard wrote: > > Hi, > please oblige and review the javadoc changes: > http://cr.openjdk.java.net/~msheppar/8181836/webrev/ Looks good Mark. -Chris.

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On Jun 16, 2017, at 9:17 AM, Aleks Efimov wrote: > > : > 4. Update jdk/test/jdk/modules/etc/JdkQualifiedExportTest.java to remove > "java.xml/com.sun.xml.internal.stream.writers” from KNOWN_EXCEPTION. > >Removed "java.xml/com.sun.xml.internal.stream.writers” from > JdkQualifiedExportTes

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Bill, Sure - will revert it. On 06/16/2017 06:05 PM, Bill Shannon wrote: Aleks Efimov wrote on 6/16/17 9:17 AM: 3. MimetypesFileTypeMap.java: - Are the Parens around lines 54-57 really needed? I think that the parens are not needed too. Removed them + also removed parens from

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Aleks Efimov wrote on 6/16/17 9:17 AM: > 3. MimetypesFileTypeMap.java: > - Are the Parens around lines 54-57 really needed? > > I think that the parens are not needed too. Removed them + also > removed > parens from MailcapCommandMap javadoc. > Bill, please, confirm if you thi

RFR: JDK-8181836 - BadKindHelper.html and BoundsHelper.html contains broken link in the javadoc

Hi, please oblige and review the javadoc changes: http://cr.openjdk.java.net/~msheppar/8181836/webrev/ to rectify broken javadoc links, as outlined in https://bugs.openjdk.java.net/browse/JDK-8181836 regards Mark

Re: [8u-dev] RFR (JAXWS): 8172297: In java 8, the marshalling with JAX-WS does not escape carriage return

Thank you for the review Roman. Can I, please, ask for JDK8u reviewer to go through these changes? With Best Regards, Aleksei On 06/09/2017 04:20 PM, Roman Grigoriadi wrote: Looks good to me. Just a side note that escape handler can be overridden by "setting com.sun.xml.bind.characterEscapeH

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, Please, help to review the latest changes that addresses the following comments: 1. JAXBContext for methods such as createValidator() I would suggest adding the @Deprecated annotation @Deprecated added to JAXBContext::createValidator 2. jdk.xml.bind and jdk.xml.ws have been updat

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

On 16/06/2017 11:21, Hamlin Li wrote: Please check new webrev: http://cr.openjdk.java.net/~mli/8181912/webrev.01/ I updated as Felix suggest to pass "LC_ALL" into test process as an environment by using ProcessTools This is much better, looks good. -Alan

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

On 16/06/2017 11:06, Amy Lu wrote: Thank you Alan! I'll change MacPathTest.sh(MacPathTest.java) in a separate bug (8182376). I updated webrev, and this patch only include changes for: java/nio/charset/Charset/default.sh java/nio/charset/coders/CheckSJISMappingProp.sh Please review: http://cr

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

+1 On Jun 15, 2017, at 3:35 PM, Claes Redestad wrote: > On 2017-06-15 18:50, Alan Bateman wrote: > > >> On 15/06/2017 17:26, Chris Hegarty wrote: >> : >> Claes, >> >> This is the first test in the core area that will now use a test >> specific native library, which will need to be built ( b

Re: RFR 8182321/10, Mark java/lang/ProcessHandle/OnExitTest.java as intermittent

+1 looks fine On 6/16/17 12:52 AM, Felix Yang wrote: Hi, please review a minor patch to add @key intermittent to java/lang/ProcessHandle/OnExitTest.java. It has been observed to be failing intermittently on Solaris x64. Bug: https://bugs.openjdk.java.net/browse/JDK-8182321 Patch: diff

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

On 15/06/17 23:35, Claes Redestad wrote: ... New webrev: http://cr.openjdk.java.net/~redestad/8181147/jdk.07 From my point of view, consider this reviewed. I am happy how this turned out. -Chris.

Re: Accessing module internals from bytecode rewriting agent

On 16/06/2017 10:26, Michael Rasmussen wrote: : If going that route, then there are 3 capabilities added with JVMTI 9 that you should look into, in order to be able to intercept the loading of the very early classes as well (Object, String, Class etc): can_generate_early_vmstart can_generate_all_

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

Please check new webrev: http://cr.openjdk.java.net/~mli/8181912/webrev.01/ I updated as Felix suggest to pass "LC_ALL" into test process as an environment by using ProcessTools Thank you -Hamlin On 2017/6/16 17:14, Felix Yang wrote: Hamlin, this may be not a blocker. if you prefer '

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

On 6/16/17 4:51 PM, Alan Bateman wrote: On 16/06/2017 06:56, Amy Lu wrote: Ping for review. (or should I withdraw this change and leave the set LC_ALL related tests as shell script tests as they are?) I think the tests would be okay if you they are run with LC_ALL set, the issue is -Dsun.jnu.

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

On 2017/6/16 17:14, Felix Yang wrote: Hamlin, this may be not a blocker. if you prefer 'pure' java, it can be achieved by adjusting environment for ProcessBuilder. see Amy's patch: http://cr.openjdk.java.net/~amlu/8181395/webrev.00/test/java/nio/charset/Charset/DefaultCharsetTest.java.

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

Hamlin, this may be not a blocker. if you prefer 'pure' java, it can be achieved by adjusting environment for ProcessBuilder. see Amy's patch: http://cr.openjdk.java.net/~amlu/8181395/webrev.00/test/java/nio/charset/Charset/DefaultCharsetTest.java.html In further, you may extend and wra

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

Ping. Thank you -Hamlin On 2017/6/15 14:29, Hamlin Li wrote: Hi Alan, Paul, Thank you for review, new webrev at: http://cr.openjdk.java.net/~mli/8181478/webrev.01/ Please also check my comments inline. On 2017/6/15 1:28, Alan Bateman wrote: On 14/06/2017 18:20, Paul Sandoz wrote: On

Re: JDK 10 RFR of JDK-8181309: Refactor shell test AsynchronousChannelProvider/custom_provider.sh to java

On 16/06/2017 03:25, Amy Lu wrote: java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181309 webrev: http://cr.openjdk.java.net/~amlu/8181309/webrev.00/ This looks okay

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

On 16/06/2017 06:56, Amy Lu wrote: Ping for review. (or should I withdraw this change and leave the set LC_ALL related tests as shell script tests as they are?) I think the tests would be okay if you they are run with LC_ALL set, the issue is -Dsun.jnu.encoding=UTF-8 as this was never meant to