On 6/16/17 4:51 PM, Alan Bateman wrote:
On 16/06/2017 06:56, Amy Lu wrote:
Ping for review.

(or should I withdraw this change and leave the set LC_ALL related tests as shell script tests as they are?)
I think the tests would be okay if you they are run with LC_ALL set, the issue is -Dsun.jnu.encoding=UTF-8 as this was never meant to be set on the command line. There is also potential for interaction with the UTF-8 changes that Claes is working on. Hamlin has also changed a few shell tests to set several read-only properties so those will need to be re-examined too.

-Alan

Thank you Alan!

I'll change MacPathTest.sh(MacPathTest.java) in a separate bug (8182376).

I updated webrev, and this patch only include changes for:

java/nio/charset/Charset/default.sh
java/nio/charset/coders/CheckSJISMappingProp.sh

Please review:
http://cr.openjdk.java.net/~amlu/8181395/webrev.01/

Thanks,
Amy

Reply via email to