Re: [10] RFR 8176841: Additional Unicode Language-Tag Extensions

2017-11-09 Thread Naoto Sato
Kindly requesting reviews. I incorporated a fix to the following issue raised by the test team: https://bugs.openjdk.java.net/browse/JDK-8190918 Here is the updated webrev: http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/ And the webrev since the one below (to address 8190

Re: JDK-8067661: transferTo proposal for Appendable

2017-11-09 Thread Roger Riggs
Hi Patrick, A few comments: Readable.java:  67: + it may be worth mentioning that the input might not fit in output (as seen in the CharBuffer case) Though I see we didn't call that out in the other transferTo description but here it is more likely that the output is bounded. 77: "The total

Re: Change in properties for logging: deliberate?

2017-11-09 Thread Jason Mehrens
Daniel, I would assume you would fix since it is advertised as a feature over here: https://docs.oracle.com/javase/1.5.0/docs/guide/logging/changes.html If it helps, I've dug up a lot of the history on this over here a while back: https://stackoverflow.com/questions/36726431/in-a-java-util-loggi

Re: Change in properties for logging: deliberate?

2017-11-09 Thread Daniel Fuchs
On 09/11/2017 19:16, mandy chung wrote: Daniel - we should add this known issue in the release note and document the workaround. Hi Mandy, Right, it either need to be fixed, or documented in the release notes. Let me first have a look at the issue though. best regards, -- daniel

Re: RFR: 8189953: FileHandler constructor throws NoSuchFileException with absolute path

2017-11-09 Thread mandy chung
On 11/9/17 11:20 AM, Daniel Fuchs wrote: Hi Mandy, Thanks for the review - and thanks for reminding me about @modules java.logging/java.util.logging:open I have a new webrev that incorporates your suggestions. I have also tried to reduce the long lines (I recently switched to a new IDE whose

Re: RFR: 8189953: FileHandler constructor throws NoSuchFileException with absolute path

2017-11-09 Thread Daniel Fuchs
Hi Mandy, Thanks for the review - and thanks for reminding me about @modules java.logging/java.util.logging:open I have a new webrev that incorporates your suggestions. I have also tried to reduce the long lines (I recently switched to a new IDE whose default config make them more difficult to s

Re: Change in properties for logging: deliberate?

2017-11-09 Thread mandy chung
Daniel - we should add this known issue in the release note and document the workaround. Mandy On 11/9/17 9:48 AM, Daniel Fuchs wrote: Hi Jeremy, I'm afraid I don't have a timeline at this point, but I will try having a look at the issue in the next couple of days. best regards, -- daniel

Re: RFR 8187742 Minimal set of bootstrap methods for dynamic constants

2017-11-09 Thread Paul Sandoz
Hi Volker, > On 9 Nov 2017, at 01:01, Volker Simonis wrote: > > Hi Paul, > > just some quick process-related questions. > > Is this intended to be targeted for jdk 10? > Yes, that’s what we are aiming for. I am front loading reviews ahead of a propose to target (which should hopefully happe

Re: RFR 8187742 Minimal set of bootstrap methods for dynamic constants

2017-11-09 Thread Paul Sandoz
Hi, > On 9 Nov 2017, at 00:24, stanislav lukyanov > wrote: > > Hi Paul, > > How about changing the name of the class to ConstantFactory to align > with its two siblings - LambdaMetafactory and StringConcatFactory? > I would prefer to keep it as is. It is intended to cover many forms of BSMs

Re: Faster Math ?

2017-11-09 Thread Laurent Bourgès
Hi Paul, Thank you so much for this complete summary ! I will still perform some benchmarks and could port acos native code into java code as it is used by marlin. Anyway I will backport the Cbrt java code into Marlin @ github for JDK8 users (GPL v2). Thanks, Laurent Le 9 nov. 2017 18:19, "Pau

Re: Change in properties for logging: deliberate?

2017-11-09 Thread Daniel Fuchs
Hi Jeremy, I'm afraid I don't have a timeline at this point, but I will try having a look at the issue in the next couple of days. best regards, -- daniel On 09/11/2017 17:42, Jeremy Manson wrote: Thanks, Daniel.  That is the issue.  I probably should have described it more clearly. Do you

Re: Change in properties for logging: deliberate?

2017-11-09 Thread Jeremy Manson
Thanks, Daniel. That is the issue. I probably should have described it more clearly. Do you have a sense of a fix timeline? If there is a relatively prompt fix, I can backport it to our internal build instead of introducing churn in our many, many logging configuration files. If it is likely t

Re: RFR: 8189953: FileHandler constructor throws NoSuchFileException with absolute path

2017-11-09 Thread mandy chung
Hi Daniel, On 11/2/17 9:47 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8189953: FileHandler constructor throws NoSuchFileException with absolute path https://bugs.openjdk.java.net/browse/JDK-8189953 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8189953/webrev.00/

Re: Faster Math ?

2017-11-09 Thread Laurent Bourgès
Thanks, andrew. I searched on the web and I understand now: Fdlibm native library has been ported in Java code for jdk9 (like the jafama library). Cbrt changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/7dc9726cfa82 I will anyway compare jdk9 with latest jafama 2.2 to have an up-to-date com

Re: Faster Math ?

2017-11-09 Thread Paul Sandoz
Hi Laurent, A Java method is a candidate for intrinsification if it is annotated with @HotSpotIntrinsicCandidate. When running Java code you can also use the HotSpot flags -XX:+PrintCompilarion -XX:+PrintInlining to show methods that are intrinsic (JIT watch, as mentioned, is also excellent in

Re: RFR 8190974 Parallel stream execution within a custom ForkJoinPool should obey the parallelism

2017-11-09 Thread Paul Sandoz
> On 8 Nov 2017, at 18:44, Martin Buchholz wrote: > > Looks good, but have comments as always. > > Fix type: exection > > Unrelated typo: the this slice spliterator > Fixed. Thanks, Paul. > I would test core libraries under taskset with an odd number of cpus >

Re: Faster Math ?

2017-11-09 Thread Andrew Haley
On 09/11/17 15:02, Laurent Bourgès wrote: > --- testing cbrt(double) = pow(double, 1/3) --- > Loop on Math.pow(double, 1/3), args in [-10.0,10.0], took 0.739 s > Loop on FastMath.cbrt(double), args in [-10.0,10.0], took 0.166 s > Loop on Math.pow(double, 1/3), args in [-0.7,0.7], took 0.746

Re: Faster Math ?

2017-11-09 Thread Andrew Haley
On 09/11/17 13:33, Laurent Bourgès wrote: > I checked in the latest jdk master and both cbrt / acos are NOT intrinsics. > > However, cbrt(x) = pow(x, 1/3) so it may be optmized... > > Could someone tell me how cbrt() is concretely implemented ? It's in FdLibm.java. It's not great, but it's bett

Re: JDK-8067661: transferTo proposal for Appendable

2017-11-09 Thread Patrick Reinhart
Finally did some review with Alan and integrated all into this webrev: http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.01 -Patrick > Am 08.11.2017 um 00:03 schrieb Brian Burkhalter : > > Hi Patrick, > > On Nov 7, 201

Re: Change in properties for logging: deliberate?

2017-11-09 Thread Daniel Fuchs
Sorry Jeremy, I think I misread your issue. The issue is that .handlers=X behaves differently than handlers=X I'm afraid I might have introduced this regression with https://bugs.openjdk.java.net/browse/JDK-8033661 :-( The obvious workaround for now would be to use handlers= as documented in th

Re: Faster Math ?

2017-11-09 Thread Laurent Bourgès
Hi, Here are very basic benchmark results from (JaFaMa 2 - FastMathPerf) made on my laptop (i7-6820HQ set @ 2Ghz + JDK8): --- testing asin(double) --- Loop on Math.asin(double) took 6.675 s Loop on FastMath.asin(double) took 0.162 s --- testing acos(double) --- Loop on Math.acos(double) t

Re: Faster Math ?

2017-11-09 Thread Laurent Bourgès
I checked in the latest jdk master and both cbrt / acos are NOT intrinsics. However, cbrt(x) = pow(x, 1/3) so it may be optmized... Could someone tell me how cbrt() is concretely implemented ? In native libfdm, there is no e_cbrt.c ! Thanks for your help, Laurent Le 9 nov. 2017 10:52 AM, "Jona

Re: Change in properties for logging: deliberate?

2017-11-09 Thread Daniel Fuchs
Hi Jeremy, Which jdk version/distribution are you using? I see .level = INFO in the jdk9/master sources: http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/src/java.logging/share/conf/logging.properties There should be no changes WRT the default level between 8 and 9. best regards, -- daniel

Re: Faster Math ?

2017-11-09 Thread Jonas Konrad
Hey, Most functions in the Math class are intrinsic ( http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/file/tip/src/share/vm/classfile/vmSymbols.hpp#l664 ) and will use native instructions where available. You can also test this yourself using jitwatch. There is no native call overhead. The st

Re: RFR 8187742 Minimal set of bootstrap methods for dynamic constants

2017-11-09 Thread Volker Simonis
Hi Paul, just some quick process-related questions. Is this intended to be targeted for jdk 10? Is the current implementation already available in a separate repository and/or branch? I've read in the RFR for 8186046 that some parts are currently being refined in the amber repository. Or is the

Faster Math ?

2017-11-09 Thread Laurent Bourgès
Hi, The Marlin renderer (JEP265) uses few Math functions: sqrt, cbrt, acos... Could you check if the current JDK uses C2 intrinsics or libfdm (native / JNI overhead?) and tell me if such functions are already highly optimized in jdk9 or 10 ? Some people have implemented their own fast Math like

Re: RFR 8187742 Minimal set of bootstrap methods for dynamic constants

2017-11-09 Thread stanislav lukyanov
I also noticed that Class::isPrimitive now says the following:     "These objects may only be accessed via the following public static final variables, and are the only Class objects for which this method returns true." (the fields its talking about are the .TYPE) Should this text be tweaked?

Re: RFR 8187742 Minimal set of bootstrap methods for dynamic constants

2017-11-09 Thread stanislav lukyanov
Hi Paul, How about changing the name of the class to ConstantFactory to align with its two siblings - LambdaMetafactory and StringConcatFactory? Other comments are purely about the spec text (should I be posting them in the CSR issue instead?) The class-level javadoc could use more text to de