Re: RFR of 8194284: CheckRegisterInLog.java fails with java.lang.RuntimeException: CheckRegisterInLog got exception timeout 6480000ms out of range

On 18/01/2018 5:41 PM, Hamlin Li wrote: Hi David, Sometime we will run test by command "jtreg -timeoutFactor:xxx ...", xxx Yes but that controls how jtreg manages the execution of the test. How is that then being used by the tests that call TestDriver? Further if TestDriver limits the timeo

Re: RFR of 8194284: CheckRegisterInLog.java fails with java.lang.RuntimeException: CheckRegisterInLog got exception timeout 6480000ms out of range

Hi David, Sometime we will run test by command "jtreg -timeoutFactor:xxx ...", xxx may be a large number than usual, e.g. 100. The reason we supply a large number for timeoutFactor is because we're running test on a very slow machine, or we're running test on a docker environment which has ver

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

The client part looks fine. On 17/01/2018 04:43, Lindenmaier, Goetz wrote: Posting this to awt-dev, too. This change adapts some tests to run on properly on aix or s390: http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/ Best regards, Goetz. -Original Message- From

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

Hi Volker, On 18/01/2018 9:21 AM, Volker Simonis wrote: David Holmes mailto:david.hol...@oracle.com>> schrieb am Mi. 17. Jan. 2018 um 22:45: Hi Goetz, On 17/01/2018 10:42 PM, Lindenmaier, Goetz wrote: > Hi David, > > thanks for looking at the change. > > We

Re: RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

On 1/17/18 11:08 AM, Bob Vandette wrote: I put these new methods in VMSupport since this was the class containg the getVMTemporaryDirectory and the intention of this class was document as: /* * Support class used by JVMTI and VM attach mechanism. */ class VMSupport { I looked at the hist

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

David Holmes schrieb am Mi. 17. Jan. 2018 um 22:45: > Hi Goetz, > > On 17/01/2018 10:42 PM, Lindenmaier, Goetz wrote: > > Hi David, > > > > thanks for looking at the change. > > > > We actually run the aix VM also on OS400. > > And as OS.java says that it's a " Stripped down version of jtreg > >

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

Hi Goetz, On 17/01/2018 10:42 PM, Lindenmaier, Goetz wrote: Hi David, thanks for looking at the change. We actually run the aix VM also on OS400. And as OS.java says that it's a " Stripped down version of jtreg internal class com.sun.javatest.regtest.config.OS" I not only grabbed the AIX case

Re: [11] RFR JDK-8194554: filterArguments runs multiple filters in the wrong order

>> That's a good idea (I should have started with a simpler test). >> >> Updated: >> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8194554/webrev.01/ >> Thanks, Mandy and Paul. Reviewed. — John

Re: [11] RFR JDK-8194554: filterArguments runs multiple filters in the wrong order

+1 Paul. > On 17 Jan 2018, at 12:29, mandy chung wrote: > > > > On 1/17/18 12:16 PM, Paul Sandoz wrote: >> >>> On 17 Jan 2018, at 08:50, mandy chung >>> wrote: >>> >>> Webrev: >>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8194554/webrev.00/ >>>

Re: [11] RFR JDK-8194554: filterArguments runs multiple filters in the wrong order

On 1/17/18 12:16 PM, Paul Sandoz wrote: On 17 Jan 2018, at 08:50, mandy chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8194554/webrev.00/ This fixes a mismatch between the specification and implementation. If MethodHandles.filterArguments is used to apply two or more

Re: [11] RFR JDK-8194554: filterArguments runs multiple filters in the wrong order

> On 17 Jan 2018, at 08:50, mandy chung wrote: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8194554/webrev.00/ > > This fixes a mismatch between the specification and implementation. > If MethodHandles.filterArguments is used to apply two or more non-null > filters to a metho

Re: [11] RFR 8194879 : Runtime.Version parses string which does not conform to spec without throwing IAE

Done[1] - thanks Roger. I also updated the copyright years. -Brent 1. http://cr.openjdk.java.net/~bchristi/8194879/webrev.01/ On 1/17/18 7:04 AM, Roger Riggs wrote: Hi Brent, The bug number should be added to the @bug line in the test. Thanks, Roger On 1/16/2018 4:21 PM, Brent Christian wr

Re: RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

I put these new methods in VMSupport since this was the class containg the getVMTemporaryDirectory and the intention of this class was document as: /* * Support class used by JVMTI and VM attach mechanism. */ class VMSupport { I could create a new PerfDataFileImpl or jdk.internal.jvmstat.VMSup

Re: RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

Hi Bob, I think the new methods in VMSupport and probablywith VMSupport.getVMTemporaryDirectory should belong to jdk.internal.jvmstat as they are specific for jvmstat and attach API to use. W.r.t VMSupportImpl, the implementation is the same for all platforms except Linux.  One option is to

[11] RFR JDK-8194554: filterArguments runs multiple filters in the wrong order

Webrev: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8194554/webrev.00/ This fixes a mismatch between the specification and implementation. If MethodHandles.filterArguments is used to apply two or more non-null filters to a method handle, those filters will be run in right-to-left order in th

RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

Here’s an updated webrev addressing the comments from David Holmes. 1. Moved new cgroup specific support from unix -> Linux and put stubs in all other OS's 2. Reduced the size of the stack arrays in perfMemory_linux.cpp There are still two outstanding issues: [serviceability] : Can we and sho

Re: RFR 8139206: Add InputStream readNBytes(int len)

The proposed change has been modified to replace the two methods byte[] InputStream.readAllBytes(int) // reads at most ‘len’ bytes byte[] InputStream.readNBytes(int) // reads exactly ‘len’ bytes or throws IOException with a single method byte[] InputStream.readNBytes(int) // reads at most ‘len’

Re: [11] RFR 8194879 : Runtime.Version parses string which does not conform to spec without throwing IAE

On 16/01/2018 21:21, Brent Christian wrote: Hi, Please review this version string parsing fix for Runtime.Version. Issue: https://bugs.openjdk.java.net/browse/JDK-8194879 Webrev: http://cr.openjdk.java.net/~bchristi/8194879/webrev.00/index.html Looks good to me.

Re: [11] RFR 8194879 : Runtime.Version parses string which does not conform to spec without throwing IAE

Hi Brent, The bug number should be added to the @bug line in the test. Thanks, Roger On 1/16/2018 4:21 PM, Brent Christian wrote: Hi, Please review this version string parsing fix for Runtime.Version. Issue: https://bugs.openjdk.java.net/browse/JDK-8194879 Webrev: http://cr.openjdk.java.net/

RE: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

Posting this to awt-dev, too. This change adapts some tests to run on properly on aix or s390: http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/ Best regards, Goetz. > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Mittwoch, 17. Januar

RE: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

Hi David, thanks for looking at the change. We actually run the aix VM also on OS400. And as OS.java says that it's a " Stripped down version of jtreg internal class com.sun.javatest.regtest.config.OS" I not only grabbed the AIX case from there, but also the OS400 one. I don't think this will

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

Hi Goetz, test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/OS.java I thought this was for AIX recognition not OS/400 ? ;-) Otherwise the AIX changes seem okay. Thought AWT tests should be reviewed on awt-dev. Cheers, David On 17/01/2018 9:39 PM, Lindenmaier, Goetz wrote:

RE: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

Hi, Volker, thanks for your review. Could someone else please have a quick look at this simple fix? Updated webrev with fixed BadPluginConfigurationTest: http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/ Best regards, Goetz. > -Original Message- > From: Volker Simoni