Hi Claes,
Moving the use of SALT to iterator creation is a great idea! You change looks
really good.
Thanks for making the change!
Jiangli
> On Apr 18, 2018, at 8:20 AM, Claes Redestad wrote:
>
> Hi,
>
> please review this change that moves the use of SALT to
Adding back hotspot-runtime-dev - please reply-all
On 19/04/2018 1:26 AM, Roger Riggs wrote:
Hi,
Also, the new constructor should be public so it can be used in other
places.
That takes this from being a simple change that adds more info to the
exception message, to an API addition that
+1 from me, thanks!
On Wed, Apr 18, 2018 at 3:09 PM, Xueming Shen wrote:
> Alan, David,
>
> Any more update/comment/suggestion on this one? I have updated
> DeInflate.java with
> some new test cases to cover the newly added methods. Good to go?
>
> -Sherman
>
> On
Alan, David,
Any more update/comment/suggestion on this one? I have updated DeInflate.java
with
some new test cases to cover the newly added methods. Good to go?
-Sherman
On 04/10/2018 08:49 PM, Xueming Shen wrote:
http://cr.openjdk.java.net/~sherman/6341887.David.Lloyd/webrev/
Thanks,
+1
There is one extra space in Optional.java: line 163: "is__not".
Thanks, Roger
On 4/18/18 2:06 AM, Stuart Marks wrote:
OK, looks good! +1 from me.
s'marks
On 4/17/18 10:34 PM, Vivek Theeyarath wrote:
Hi Stuart,
Done with the changes
Hi,
Minor improvement in readability (and probably perf) for Pattern. Switch is
more consistent with the rest of the impl and the resulting tableswitch
avoids a comparison for possessives.
-Isaac
--- a/src/java.base/share/classes/java/util/regex/Pattern.java
+++
Hi Pallavi,
The fix here seems to make padding to a fixed width incompatible with
adjacent value parsing.
That's not intuitive, since adjacent value parsing is intended to allow
more flexible parsing
of a combination leading fixed-width fields and subsequent variable
length fields.
The
2018/4/18 10:27:36 -0700, e...@zusammenkunft.net:
> Hello, I would put it on a standalone Git repo on one of the public
> hosting sites lile.Github, especially for a first discussion
> (especially good if added JMH comparisions). I would not expect a id
> quickly/easily and a in-tree webrev could
Hello, I would put it on a standalone Git repo on one of the public hosting
sites lile.Github, especially for a first discussion (especially good if added
JMH comparisions). I would not expect a id quickly/easily and a in-tree webrev
could be created by sponsor for final ok.
Bernd
Von:
Hi,
Also, the new constructor should be public so it can be used in other
places.
It seems in some cases the error message is a literal in the VM code (
typeArrayKlass.cpp:149).
That would seem to be a duplication and not really a good idea.
Roger
On 4/18/18 10:30 AM, Roger Riggs wrote:
Hi,
please review this change that moves the use of SALT to iterator
creation, which would allow for certain startup
optimizations in the future.
Bug: https://bugs.openjdk.java.net/browse/JDK-8201650
Webrev: http://cr.openjdk.java.net/~redestad/8201650/open.00/
This does make the randomness
Hi,
The requirements to become an OpenJDK Author[1] are fairly modest but follow
from a couple of sponsored contributions after which you can request to
become
an author.
Regards, Roger
[1] http://openjdk.java.net/projects/#project-author
On 4/18/18 10:49 AM, raffaello.giulie...@gmail.com
On 2018-04-18 16:35, Aleksey Shipilev wrote:
> On 04/18/2018 03:58 PM, Andrew Haley wrote:
>> On 04/18/2018 02:55 PM, raffaello.giulie...@gmail.com wrote:
>>> So, how can I best proceed with this initial delivery?
>>
>> Once you have an OpenJDK id you can get an account on cr.openjdk.java.net.
>>
On 04/18/2018 03:58 PM, Andrew Haley wrote:
> On 04/18/2018 02:55 PM, raffaello.giulie...@gmail.com wrote:
>> So, how can I best proceed with this initial delivery?
>
> Once you have an OpenJDK id you can get an account on cr.openjdk.java.net.
> That's where you should put your changes.
...and
Hi,
The message can be simpler and more efficiently convey the information.
It should be more consistent with existing uses of
ArrayIndexOutOfBoundsException as
throw by: Objects.checkIndex(index, length).
Which roughly reads as:
Index %d out-of-bounds for length %d
Regards, Roger
On
On 04/18/2018 02:55 PM, raffaello.giulie...@gmail.com wrote:
> So, how can I best proceed with this initial delivery?
Once you have an OpenJDK id you can get an account on cr.openjdk.java.net.
That's where you should put your changes.
--
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd.
Hi,
in thread [1] I mention a clean room implementation of
Double.toString(double) and my willingness to contribute it to the
OpenJDK project to fix [2].
As of today, my code resides in a module that exports a package simply
named "math". The reason I do not alter the original OpenJDK
Hi,
Please review the changes to the following issue:
Bug : https://bugs.openjdk.java.net/browse/JDK-8193877
The proposed fix is located at:
Webrev : http://cr.openjdk.java.net/~rpatil/8193877/webrev.00/
When padding is used in a pattern where there are unpadded values adjacent to
Adding core-libs-dev as you're changing
java.lang.ArrayIndexOutOfBoundsException.
I appreciate the intent here but I find the messages excessively
verbose. The basic error is:
index N is outside range [0, length-1]
David
On 18/04/2018 6:09 PM, Lindenmaier, Goetz wrote:
Hi,
I would like
Hello Volker.
(I'm sorry for duplicate posting, I did bad operation)
What's actually the difference between "ibm-942C" and "ibm-942"?
They have two differences on single byte part:
1. Control Character rotation for 0x1A and 0x1C, 0x7F [2]
2. Character replacement for 0x5C and 0x7E (0xFE, 0xFF)
> 17 apr. 2018 kl. 00:52 skrev mark.reinh...@oracle.com:
>
> 2018/4/12 1:12:36 -0700, raffaello.giulie...@gmail.com:
>> my code is now ready to be uploaded to the OpenJDK reps. Currently it
>> resides on GitHub and is under the "GPLv2 + Classpath Exception"
>> license, with myself as the
OK, looks good! +1 from me.
s'marks
On 4/17/18 10:34 PM, Vivek Theeyarath wrote:
Hi Stuart,
Done with the changes
http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.05/ .
Regards
Vivek
-Original Message-
From: Stuart Marks
Sent: Wednesday, April 18, 2018 8:56 AM
To: Vivek
22 matches
Mail list logo