I second that `Stream.append` would be a very useful addition, although I
would definitely propose it as
Stream append(Stream other) -> Stream.concat(this,
other);
Of course, we could also have a convenience overload like
Stream append(T... values) -> append(Arrays.stream(values));
OK
On 10/15/18 3:32 AM, Priya Lakshmi Muthuswamy wrote:
Hi,
Kindly review trivial fix for
https://bugs.openjdk.java.net/browse/JDK-8211957
webrev : http://cr.openjdk.java.net/~pmuthuswamy/8211957/webrev.00/
Thanks,
Priya
> On Oct 16, 2018, at 6:14 AM, Joe Wang wrote:
>
>
>
> On 10/14/18, 6:48 PM, Weijun Wang wrote:
>> Hi Joe
>>
>> Two comments:
>>
>> 1. How about (path1, path2)? I take a look at other similar APIs, some use
>> (c1,c2) and some (a,b).
>
> It's true we have some inconsistencies there. Arra
> On Oct 15, 2018, at 7:51 AM, Aleksei Voitylov
> wrote:
>
> Kim,
>
> If you were suggesting to just proceed with the change without giving a
> sufficient lead time for the ports that were willing to upgrade to do so,
> that sounds very alarming.
What is "sufficient lead time"? I'm not prop
On 10/14/18, 6:48 PM, Weijun Wang wrote:
Hi Joe
Two comments:
1. How about (path1, path2)? I take a look at other similar APIs, some use
(c1,c2) and some (a,b).
It's true we have some inconsistencies there. Arrays.mismatch for
example, named the parameters (a,b). Arguably though, they sh
On 10/14/18, 11:08 AM, Alan Bateman wrote:
On 12/10/2018 20:16, Joe Wang wrote:
Hi all,
Here's an update based on all of the great reviews and comments
(thanks all!):
JBS: https://bugs.openjdk.java.net/browse/JDK-8202285
CSR: https://bugs.openjdk.java.net/browse/JDK-8202302
Current versi
Thanks! Pushed.
-Aleksey
On 10/15/2018 09:24 PM, Joe Wang wrote:
> Thanks Joe for the reminder, and thanks all for doing this! The change looks
> good to me as well. I
> assume you updated copyright locally, not reflected in the webrev. With
> regards to the class
> documentation, it's confusin
Thanks Joe for the reminder, and thanks all for doing this! The change
looks good to me as well. I assume you updated copyright locally, not
reflected in the webrev. With regards to the class documentation, it's
confusing probably due to a class refactoring during the development.
That part of
I think it would be reasonable to give engineers who work in the XML
area some time to review the fix as well before it is pushed.
Cheers,
-Joe
On 10/15/2018 11:13 AM, Aleksey Shipilev wrote:
On 10/15/2018 07:50 PM, Kim Barrett wrote:
Fix:
http://cr.openjdk.java.net/~shade/8212178/webrev.
On 10/15/2018 07:50 PM, Kim Barrett wrote:
>> Fix:
>> http://cr.openjdk.java.net/~shade/8212178/webrev.01/
>
> Change looks good. Update copyright?
Thanks! Updated. jdk-submit is clean, I am going to push it soon.
> The class documentation here seems very confusing to me, like it’s not really
Hi all,
sorry for the repeated number of mails on this issue. I have added a
direct link to the patch the right link to the webrev is [1] there is a
previous version at [2] if you want to see the differences with the last
version. Basically we have dropped the `implements Constable` for the
s
adding core-libs in the loop
On 10/10/2018 12:30 PM, Vicente Romero wrote:
Hi all,
I have updated the webrev [1], this version removes the `implements
Constable` from the symbolic descriptor classes. Feedback is mostly
appreciated,
Thanks,
Vicente
[1] http://cr.openjdk.java.net/~vromero/82
> On Oct 15, 2018, at 8:22 AM, Aleksey Shipilev wrote:
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8212178
>
> See the details in the bug. We are hitting this race when Shenandoah is
> running in aggressive mode
> and evacuates lots of objects all the time, processing references very o
Hello Everyone,
This is the first time I am writing mail to this group, hence please ignore
my nuisance and guide me towards right direction.
As suggested by Martin, I believe documentation need to be updated.
I would happy to update the documentation, please provide your inputs.
I have attache t
The intent is that the collector is free to either call the identity
function, or replace it with an unchecked cast instead, and client code
cannot tell the difference.
On 10/9/2018 10:48 AM, Chris Dennis wrote:
I’m attempting to clarify the meaning/intent of the language in the
specification
Is there a more suitable mailing list for this kind of core-libs spec related
enquiry to be directed at?
Thanks,
Chris
> On Oct 9, 2018, at 10:48 AM, Chris Dennis wrote:
>
> I’m attempting to clarify the meaning/intent of the language in the
> specification of the identity-finish characteris
I have verified that the program that failed before doesn't appear to
fail anymore.
The patch looks good to me.
Thanks!
Roman
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8212178
>
> See the details in the bug. We are hitting this race when Shenandoah is
> running in aggressive mode
> a
Bug:
https://bugs.openjdk.java.net/browse/JDK-8212178
See the details in the bug. We are hitting this race when Shenandoah is running
in aggressive mode
and evacuates lots of objects all the time, processing references very often.
This makes weak
reference reclamation races very visible.
Fix:
Ping...
On 2018/10/12 2:00 PM, Hamlin Li wrote:
Hi Igor,
It's updated in place
http://cr.openjdk.java.net/~mli/8211974/webrev.00/, please review it
again.
Thank you
-Hamlin
On 2018/10/12 1:34 PM, Igor Ignatyev wrote:
Hi Hamlin,
could you please move jdk.test.lib.util.Compiler to j.t.l
Kim,
If you were suggesting to just proceed with the change without giving a
sufficient lead time for the ports that were willing to upgrade to do
so, that sounds very alarming.
Meanwhile, our testing has finished and I'm now confident we will be
able to switch ARM port over to 7.x in 12 tim
On 15/10/2018 11:32, Priya Lakshmi Muthuswamy wrote:
Hi,
Kindly review trivial fix for
https://bugs.openjdk.java.net/browse/JDK-8211957
webrev : http://cr.openjdk.java.net/~pmuthuswamy/8211957/webrev.00/
This looks okay to me.
-Alan
Hi,
Kindly review trivial fix for
https://bugs.openjdk.java.net/browse/JDK-8211957
webrev : http://cr.openjdk.java.net/~pmuthuswamy/8211957/webrev.00/
Thanks,
Priya
22 matches
Mail list logo
