Re: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-01-27 Thread Alan Bateman
On 24/01/2019 16:19, Baesken, Matthias wrote: Did you consider adding a Unix version of open_jarfile to avoid #ifdef WIN32 ? Hi Alan, do you mean , adding a separate c-file for UNIX containing the function open_jarfile ? I considered this, but did not like the idea to add a separate file for

Re: RFR: JDK-8217393 Re: Clarification in Attributes equal

2019-01-27 Thread Philipp Kunz
The class comment to Attributes says> > This map and its views have a predictable iteration order, namely the> order that keys were inserted into the map, as with {@link LinkedHashMap}.> Considering above statement, are two Attributes equal if they contain the same mappings in a different

RFR: JDK-8217331: Problems when space in application name

2019-01-27 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes removal of the APP_FS_NAME DeployParam, and enhanced  checking of the given application name so APP_NAME parameter can be safely

FW: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-27 Thread Deepak Kejriwal
+ jdk8u-dev. From: Deepak Kejriwal Sent: Saturday, January 26, 2019 4:27 PM To: core-libs-dev ; jdk-updates-...@openjdk.java.net Subject: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra Hi All, JBS report:

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

2019-01-27 Thread Alan Bateman
On 11/01/2019 19:41, Andy Herrick wrote: This is the second update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool I've started to play with the latest EA build,