On 24/01/2019 16:19, Baesken, Matthias wrote:
Did you consider adding a Unix version of open_jarfile to avoid #ifdef
WIN32 ?
Hi Alan, do you mean , adding a separate c-file for UNIX containing the
function open_jarfile ?
I considered this, but did not like the idea to add a separate file for UNIX
just for the small function .
Your suggestion to use FILE_SHARE_READ is probably the right way to do it ,
I changed this, second webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.2/
Christoph Langer's suggestion to use jli_util seems worth exploring to
keep the platform specific code together.
I still find the call to _open and checking for ENOENT a bit icky. If
this change gets pushed then I think we need a follow-up issue created
to replace this to use CreateFile consistently.
-Alan
