Thanks, Roger.
Cheers,
Henry
> On Mar 1, 2019, at 10:27 AM, Roger Riggs wrote:
>
> Hi Henry,
>
> The change looks ok, Reviewed.
>
> (I'm not that familiar with Solaris).
>
> Thanks, Roger
>
>
>
> On 3/1/19 10:45 AM, Henry Jen wrote:
>> Ping!
>>
>> Any thought on this webrev restore the
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added custom action to check installation folder and display
confirmation dialog to ask user to continue installation if destination
folder is not
Hi Nishit,
Just one comment on j.t.CompactNumberFormat.java. At line 425, Null
check can be done at the top of the method, as a parameter check, so
that all the unnecessary "if-elseif" can be avoided. Others look good.
Naoto
On 3/6/19 3:56 AM, Nishit Jain wrote:
Hi,
Please review the fix
Hi Mandy,
The webrev has been updated with the new test:
http://cr.openjdk.java.net/~afarley/8216558/webrev/
Note that I included a handful of small improvements, and that the final
fields are all setAccessible by default, because (a) it seemed cleaner
than adding a new control bit, and (b)
Hi Stuart,
According to Liskov substitution principle:
Subtype Requirement: Let ϕ ( x ) be a property provable about
objects x of type T. Then ϕ ( y ) should be true for objects y of type S
where S is a subtype of T.
Let ϕ ( x ) for objects x of type Iterable be: "x.iterator() may be
I don’t mean any offence, but I have to say, I strongly disagree with nearly
everything you’ve written below. To me, the idea of making a stream of integers
for a simple loop counter is hackish, confusing, verbose, and basically abusing
the stream concept. The only part I agree with is that it
Hi Tagir,
try to do it now and you will see that you can't, because you can not write
Iterable yet.
Once we will get generics over value types, it will be a no-brainer.
Rémi
- Mail original -
> De: "Tagir Valeev"
> À: "Stuart Marks"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 6 Mars
Hi,
Please review the fix for JDK-8217254 and JDK-8217721
Bug: https://bugs.openjdk.java.net/browse/JDK-8217254
https://bugs.openjdk.java.net/browse/JDK-8217721
Webrev: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.00/
Issue: The exception thrown by constructor and
Hello!
By the way one of the painful code patterns in modern Java is `for(int
i = 0; i wrote:
>
> Hi all,
>
> Please review and comment on this proposal to allow Stream instances to be
> used
> in enhanced-for ("for-each") loops.
>
> Abstract
>
> Occasionally it's useful to iterate a Stream
