ConcurrentModificationException thrown by HashMap.compute() operating on an empty Map, expected/unexpected?

Hi, Here I have a case simplified from a practical issue that throws ConcurrentModificationException (CME) unexpectedly (I think). [0] creates a HashMap, keeps it empty, and calls m.computeIfAbsent() or m.compute(), in which a "sneaky" m.clear() occurs, some of the test cases throw CME although

jpackage EA 5 Build 36 (2019/3/28)

A fifth EA build (Build 36) of jpackage tool is available at https://jdk.java.net/jpackage/ This release contains fixes to the following: JDK-8221256 Fix create-installer specific options on MAC JDK-8215241 Permissions are not set correctly on sub-folders in /Applications JDK-8221525

Re: [PATCH] Some improvements for java.lang.Class

Hi, From the benchmark data, it seems that the patched code is not a lot much faster than the original code, plus as Peter mentioned java.base is not compiled with the -XDstringConcat=inline option, so there is no way the compiler will generate any indy for the patched code. The new code is

Re: Review Request: 8221530: Caller sensitive methods not handling caller = null when invoked by JNI code with no java frames on stack

On 3/28/19 1:39 PM, Alan Bateman wrote: On 28/03/2019 16:43, Mandy Chung wrote: : Updated webrev: http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8221530/webrev.01 I think this looks okay. One minor nit is that newIllegalAccessException doesn't throw IAE. Thanks Alan. CSR: 

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

On 3/29/19 4:36 PM, Peter Levart wrote: On 3/29/19 8:49 AM, Lindenmaier, Goetz wrote: So I want to withdraw my claim that NPEs are thrown frequently. Probably I was biased by my compiler construction background, remembering NPE checks are all over the place in the code. But I think I can

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

On 3/29/19 8:49 AM, Lindenmaier, Goetz wrote: So I want to withdraw my claim that NPEs are thrown frequently. Probably I was biased by my compiler construction background, remembering NPE checks are all over the place in the code. But I think I can still keep the claim that the message is

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, I could access the JBS now, so part 2 of my reply. Yesterday, I added tables to the JEP describing what is printed for which bytecode. If this is too verbose for the JEP, it might be nice in the bug implementing it. > > This is a design decision not to make the printout too complex.

Re: RFR: 8221687: Deprecated j.u.jar.Attributes.Name attributes accidentally set to null

On 2019-03-29 14:44, Alan Bateman wrote: On 29/03/2019 13:38, Claes Redestad wrote: Hi, JDK-8214712 accidentally omitted three deprecated Names from being properly archived. Looks okay. Thanks, Alan! /Claes

Re: RFR: 8221687: Deprecated j.u.jar.Attributes.Name attributes accidentally set to null

On 29/03/2019 13:38, Claes Redestad wrote: Hi, JDK-8214712 accidentally omitted three deprecated Names from being properly archived. Looks okay. -Alan

RFR: 8221687: Deprecated j.u.jar.Attributes.Name attributes accidentally set to null

Hi, JDK-8214712 accidentally omitted three deprecated Names from being properly archived. Bug: https://bugs.openjdk.java.net/browse/JDK-8221687 Patch: diff -r d9f6d16299b1 src/java.base/share/classes/java/util/jar/Attributes.java --- a/src/java.base/share/classes/java/util/jar/Attributes.java

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

Thanks. Alan, are you fine with the current webrev, if yes may I add you as reviewer ? Best regards, Matthias > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 28. März 2019 12:41 > To: Baesken, Matthias > Cc: core-libs-dev@openjdk.java.net; Alan Bateman > >

jdk.packager.services.UserJvmOptionsService replacement?

I'm sorely missing the jdk.packager.services.UserJvmOptionsService in the current jpackage EA. I've asked before and received the answer that the UserJvmOptionsService was removed together JavaFX, and that no replacement was planned. May I plead for a reincarnation with the new jpackage tool?

Re: RFR: 8221477: Inject os/cpu-specific constants into Unsafe from JVM

Hi David, Thanks very much for reviewing this patch. On 29/03/2019 01:25, David Holmes wrote: > This seems fine in general but I have a few queries on some details: > > src/hotspot/share/classfile/javaClasses.hpp > >     f(java_lang_Thread) \ > +   f(jdk_internal_misc_UnsafeConstants) \ >    

Re: RFR: 8221477: Inject os/cpu-specific constants into Unsafe from JVM

Thanks Andrew. Looks all good to me now. Cheers, Thomas On Fri, Mar 29, 2019 at 9:43 AM Andrew Dinn wrote: > On 28/03/2019 17:09, Thomas Stüfe wrote: > > src/hotspot/share/classfile/javaClasses.cpp > > > > Pure nitpicking, but you could remove the member variables too and just > > set the

Re: RFR: 8221477: Inject os/cpu-specific constants into Unsafe from JVM

On 28/03/2019 17:09, Thomas Stüfe wrote: > src/hotspot/share/classfile/javaClasses.cpp > > Pure nitpicking, but you could remove the member variables too and just > set the Unsafe members directly, e.g.: > >     if (fd->name() == vmSymbols::address_size_name()) { >      

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, The JBS is offline, so I'll just reply on this item for now: > > > Since the JEP quotes that NullPointerExceptions are thrown frequently > > > and swallowed, it would help if you can generate some numbers. > > > This JEP will help the discussion on the proposed feature and design and