Inputs on patch for JDK-8225763?

I am looking to contribute a patch for the enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8225763. The change itself looks relatively straightforward to me and here's what I plan to do: 1. Have both java.util.zip.Inflater and java.util.zip.Deflater start implementing the AutoCloseab

Re: RFR: JDK-8226599 use code coverage results to remove dead code

Hi Andy, Why only some tests are renamed? Otherwise looks fine. Thanks, Alexander On 6/26/2019 4:09 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjd

Re: RFR: JDK-8226599 use code coverage results to remove dead code

Looks good. - Alexey On 6/26/2019 7:09 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226599 [2] http://cr.openjdk.java.net/

RFR: JDK-8226599 use code coverage results to remove dead code

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226599 [2] http://cr.openjdk.java.net/~herrick/8226599/webrev.03 /Andy

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

Bug ID is JDK-8226835. - Alexey On 6/26/2019 2:52 PM, Andy Herrick wrote: We need to investigate this further, I have created issue: JDK-8221333 to track this issue. Thank you for you feedback. /Andy On 6/25/2019 9:17 AM, Rachel Greenham wrote: I've been getting the new jpackage working wi

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

We need to investigate this further, I have created issue: JDK-8221333 to track this issue. Thank you for you feedback. /Andy On 6/25/2019 9:17 AM, Rachel Greenham wrote: I've been getting the new jpackage working with our project build. Generally everything's fine. One probable minor bug re

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

On 6/25/2019 1:44 PM, Scott Palmer wrote: I just tried this out. One thing that has changed since my last testing was the “create-installer” vs “--package-type” parameter. “--package-type all” isn’t allowed. If I want to create .rpm and .deb, or .exe. and .msi, do I need to run twice now?

Re: RFR: 8224657: [TEST_BUG]java/util/Locale/SoftKeys.java should be ignored but run

Looks good, Claes. Naoto On 6/26/19 6:22 AM, Claes Redestad wrote: Hi, please review this fix to make sure that this test is properly skipped/ignored in all configurations (the @ignore needs to be listed before @run). It is intermittently failing on some hardware configurations in our internal

[11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported

Hi, next try, here we go again... I'd like to backport "JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported". The main reason for backporting this item is that it'll ease further backports which base on that changeset (e.g. JDK-8216039). The patch is quite ext

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

then I'm fine with original fix. /Andy On 6/25/2019 6:08 PM, Alexander Matveev wrote: Hi Alexey, I cannot use index to get items from map. At least I did not figure it out how to do this. We need to use iterator when getting values from map. Thanks, Alexander On 6/25/2019 4:52 AM, Alexey

RFR: 8224657: [TEST_BUG]java/util/Locale/SoftKeys.java should be ignored but run

Hi, please review this fix to make sure that this test is properly skipped/ignored in all configurations (the @ignore needs to be listed before @run). It is intermittently failing on some hardware configurations in our internal testing. Thanks! /Claes diff -r d3e45bd166dc test/jdk/java/util/Lo