Re: 8226863: [aix] jdk/java/lang/reflect/exeCallerAccessTest cannot launch on primordial thread

Second, corrected Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/execalleraccesstest-cannot-launch-on-primordial-thread/webrev.01/webrev/ Run through SAP nightlies on all platforms. Cheers, Thomas On Thu, Jun 27, 2019 at 9:02 AM Thomas Stüfe wrote: > Hi all, > > Issue: > https://bugs.ope

Re: Review Request: JDK-8173978: Lookup.in should allow teleporting from a lookup class in a named module without dropping all access

On 7/1/19 12:51 PM, Mandy Chung wrote: This is an enhancement to |`Lookup::in`| and |`MethodHandles::privateLookupIn`| API for cross module teleporting.  A `Lookup` object will record the previous lookup class from which this |Lookup| object was teleported such that the access check will use

Re: RFR: JDK-8226891: rename and re-layout jpackage tests.

Hi Andy, Looks good. Thanks, Alexander On 6/30/2019 2:11 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226891 [2] http://cr

Re: RFR: JDK-8226751: "Exception: ..." for missing file

Looks good. On 7/1/2019 11:12 AM, Alexey Semenyuk wrote: Looks good. On 7/1/2019 1:07 PM, Andy Herrick wrote: Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the CommandLi

Re: OS X jpackage and java.class.path

> On Jul 1, 2019, at 3:21 PM, Andy Herrick wrote: > > can you share the command options used launching jpackage ? > > I think I would understand better if I saw the complete command. > > /Andy > Fwiw legacy was all absolute… java.class.path=/Users/mjh/HalfPipe/HalfPipe7.app/Contents/Java/

Re: OS X jpackage and java.class.path

> On Jul 1, 2019, at 3:21 PM, Andy Herrick wrote: > > can you share the command options used launching jpackage ? > > I think I would understand better if I saw the complete command. ${PACKAGER} \ --verbose \ --input ../HalfPipe12.app/Contents/Java \ --output outputdi

Re: OS X jpackage and java.class.path

can you share the command options used launching jpackage ? I think I would understand better if I saw the complete command. /Andy On 7/1/2019 3:02 PM, Michael Hall wrote: I think I may out mentioned this before but maybe I didn’t fix the problems it was causing me because I just ran into it

Review Request: JDK-8173978: Lookup.in should allow teleporting from a lookup class in a named module without dropping all access

This is an enhancement to |`Lookup::in`| and |`MethodHandles::privateLookupIn`| API for cross module teleporting.  A `Lookup` object will record the previous lookup class from which this |Lookup| object was teleported such that the access check will use both the previous lookup class and the curr

OS X jpackage and java.class.path

I think I may out mentioned this before but maybe I didn’t fix the problems it was causing me because I just ran into it again. So I’ll mention it again. java.class.path is somewhat inconsistent in its entries. The main jar is present as absolute path… /Users/mjh/HalfPipe/HalfPipe_jpkg/outputdir

RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Please review a fix to xml pretty print. This is a regression introduced during the JDK 9 development. CDATA is marked up to be interpreted literally as textual data, in other words, it's still character data. The processor therefore shall treat it as text data. The content of "abcxyz" should b

Re: RFR: JDK-8226751: "Exception: ..." for missing file

Looks good. On 7/1/2019 1:07 PM, Andy Herrick wrote: Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the CommandLine class uses nio Paths/Files, so the following might be a

Re: RFR: JDK-8226751: "Exception: ..." for missing file

Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the CommandLine class uses nio Paths/Files, so the following might be a better fit, and also checks whether the file can be r

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

Hi Thejasvi, Thanks for fixing this. Since those new test cases depend on the CLDR localization, which might change in other implementations, those test cases should be in jdk/java/time/test directory, as "tck" tests should only test the spec. Please create a new test case for this in the "te

Re: JPackage application image file system layout

> On Jul 1, 2019, at 2:47 AM, Robert Lichtenberger > wrote: > > While trying to update our application to the (ea-version of) jpackager I > noticed that the executable files are now in a bin/ subdirectory, which > will make the application update from javapackager a real pain. > > For Linux t

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

Is jdk-14 the current target release for this? I’m seeing the following in my app. Would this mean this release actually cracks down on some reflection? Is some jdk-14 bug unrelated to jpackage? Probably uncovered some other bug of mine? Who knows? java.lang.reflect.InvocationTargetException

Re: Suggestion for a more sensible implementation of EMPTY_MAP

> On 27 Jun 2019, at 22:38, Stuart Marks wrote: > > > > On 6/19/19 12:51 AM, Abraham Marín Pérez wrote: >> private void decorate(Map data) { >> //... >> data.computeIfPresent("field", (k, v) -> highlightDifferences(v, >> otherValue)); >> //... >> } >> At one point an emptyMap()