Re: RFR: JDK-8231281: Consider eliminating --identifier option

2019-09-28 Thread Philip Race
+// Get indetifier from app image if user provided app image and +// does not provided identifier via CLI. +String indentifier = extractBundleIdentifier(params); +if (indentifier != null) { +

[jpackage] Run custom action/script during installation

2019-09-28 Thread Tobias Diez
Hi all, I've been experimenting with the recent build of jpackage and in general it is working quite well. Thanks for your work! One feature that I was strongly missing (or at least couldn't find anything in the docs) is to run an own script during installation. For example, I need to register

Re: RFR: JDK-8231281: Consider eliminating --identifier option

2019-09-28 Thread Andy Herrick
looks good. /Andy On 9/27/2019 11:55 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed --identifier option, since it only usage is to specify identifier when

Re: RandomAccess Interface and List Heirarchy

2019-09-28 Thread forax
- Mail original - > De: "Peter Levart" > À: "Remi Forax" , "Cyrus Vafadari" > Cc: "core-libs-dev" > Envoyé: Samedi 28 Septembre 2019 10:38:43 > Objet: Re: RandomAccess Interface and List Heirarchy > On 9/25/19 12:15 PM, Remi Forax wrote: >> that said, i believe we should deprecate

Re: RandomAccess Interface and List Heirarchy

2019-09-28 Thread Peter Levart
On 9/25/19 12:15 PM, Remi Forax wrote: that said, i believe we should deprecate LinkedList (and any other List implementation that doesn't implement RandomAccess) because there are too much code out there that suppose that list.get() is O(1). Hi Remi, Deprecating LinkedList as a whole is