Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Not sure what problem was, but after moving hidden items at same Y
value as non-hidden icons issue was resolved. Also, had to adjust Y
value to
On 10/11/19 2:35 AM, Anton Kozlov wrote:
On 11.10.2019 00:28, Mandy Chung wrote:
Since the method throws Exception, this try-catch block is not needed.
The start year of the copyright in the new test files should be 2019.
Thanks! I preserved Amazon's copyright year as 2018, as I derived
Thanks, Roger. Modified readObject() accordingly:
https://cr.openjdk.java.net/~naoto/8212749.8231984/webrev.01/
Naoto
On 10/11/19 10:41 AM, Roger Riggs wrote:
Hi Naoto,
The javadoc/spec comments look fine.
Code comments at DecimalFormat:4035 give some latitute for the value to be
out of
Please review changes for [1] which is the implementation bug for JEP-343.
The webrev at [2] is the total cumulative webrev of changes for the
jpackage tool, currently in the JDK-8200758-branch branch of the open
sandbox repository.
The webrev at [3] shows the changes since EA-06 (Build
Hello,
If you can’t find the needed information on the Project Website it is probably
best to contact the project on the user mailing list.
https://phoenix.apache.org/mailing_list.html
You might want to give more information like which component is failing, what
are the exact error logs and
Dear Fellas,
Is openJDK 11 compatible with Apache Phoenix? I could see some
PhoenixDialect unresolvable name error.
Can somebody help?
Hi Severin,
The patch looks good to me.
Cheers,
Mario
On Fri, Sep 27, 2019 at 10:38 AM Severin Gehwolf wrote:
>
> Hi!
>
> I'd appreciate a review of this one. Thanks in advance! See below.
>
> On Tue, 2019-09-03 at 17:50 +0200, Severin Gehwolf wrote:
> > On Mon, 2019-08-26 at 17:54 +0200,
Hi Naoto,
The javadoc/spec comments look fine.
Code comments at DecimalFormat:4035 give some latitute for the value to be
out of range and since getGroupingSize returns the groupingSize byte
it would be cleaner if the value was always in the valid range
regardless of the isGroupingUsed boolean.
Hi Naoto,
Looks fine,
Roger
On 10/9/19 6:45 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8225435
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8225435/webrev.00/
The change is to
Looks good Roger; thanks,
-Joe
On 10/11/2019 8:12 AM, Roger Riggs wrote:
Hi Joe,
Updated with comments added for the reasons of the
@SuppressWarnings("serial").
http://cr.openjdk.java.net/~rriggs/webrev-ser-test-cleanup-8231427-3/
Thanks, Roger
On 9/27/19 2:45 PM, Joe Darcy wrote:
Hi
Updates look good to me :-)
> On Oct 11, 2019, at 11:12 AM, Roger Riggs wrote:
>
> Hi Joe,
>
> Updated with comments added for the reasons of the
> @SuppressWarnings("serial").
>
> http://cr.openjdk.java.net/~rriggs/webrev-ser-test-cleanup-8231427-3/
>
> Thanks, Roger
>
>
> On 9/27/19
+1
> On Oct 11, 2019, at 10:38 AM, Roger Riggs wrote:
>
> Please review this addition to a test to add diagnostic output.
> There have been intermittent failures of ProcessBuilder/Basic.java that
> indicate
> some output is being received from the child. There should be none.
> The additional
Pushed.
https://hg.openjdk.java.net/jdk/jdk/rev/3968bf3673c5
Many thanks Andrew!
On 10/10/19 8:32 AM, Andrew Leonard wrote:
Hi Roger,
I've updated the webrev here :
http://cr.openjdk.java.net/~aleonard/8231717/webrev.02/
Thanks
Andrew
Hi Joe,
Updated with comments added for the reasons of the
@SuppressWarnings("serial").
http://cr.openjdk.java.net/~rriggs/webrev-ser-test-cleanup-8231427-3/
Thanks, Roger
On 9/27/19 2:45 PM, Joe Darcy wrote:
Hi Roger,
Generally looks fine. Adding some comments about why the
On Fri, 2019-10-11 at 16:47 +0200, Mario Torre wrote:
> Hi Severin,
>
> The patch looks good to me.
Thanks for the review, Mario!
Cheers,
Severin
> On Fri, Sep 27, 2019 at 10:38 AM Severin Gehwolf wrote:
> > Hi!
> >
> > I'd appreciate a review of this one. Thanks in advance! See below.
> >
Please review this addition to a test to add diagnostic output.
There have been intermittent failures of ProcessBuilder/Basic.java that
indicate
some output is being received from the child. There should be none.
The additional output will be added to the log file along with the failure.
Jira
Hi Peter,
Thank you for the comment and suggestion of the fix.
I tried to pick up your change w.r.t. methodAccessor:
https://cr.openjdk.java.net/~ogatak/8229871/webrev.04/
Regarding micro benchmark, my original motivation of this change is to
improve performance of Class.getMethods(), which
Hi Mandy,
Thank you for review.
I'll keep the constructor package-private, as the change will be
non-trivial when I fix the code based on the Peter's comment.
Regards,
Ogata
Mandy Chung wrote on 2019/10/09 04:24:35:
> From: Mandy Chung
> To: Claes Redestad , Kazunori Ogata
> Cc:
On 11.10.2019 00:28, Mandy Chung wrote:
> Since the method throws Exception, this try-catch block is not needed.
>
> The start year of the copyright in the new test files should be 2019.
Thanks! I preserved Amazon's copyright year as 2018, as I derived the file from
JDK-8194653 initially
Hi,
The Jar File Specification [1] states that,
> If the last character of the file is an EOF character (code 26), the
EOF is treated as whitespace. Two newlines are appended (one for
editors that don't put a newline at the end of the last line, and one
so that the grammar doesn't have to
20 matches
Mail list logo
