Hi Martin,
On 10/14/2019 10:28 PM, Martin Buchholz wrote:
Hi Joe,
I'm surprised there were so few changes.
The changes in question allow the java.util.concurrent package to pass
cleanly through the current version of my checks. Perhaps a strong
version of the checks in the future will
Hi Joe,
I'm surprised there were so few changes.
Why are some of the Condition's marked // Conditionally serializable
and others // Not statically typed as Serializable
?
---
(I don't recall us ever testing serializability of Conditions)
---
ThreadPoolExecutor.Worker already has
/**
Hello,
Please review the changes for serial review now extending to the
java.rmi module:
JDK-8232234: Suppress warnings on non-serializable non-transient
instance fields in java.rmi
http://cr.openjdk.java.net/~darcy/8232234.0/
Patch below.
For
test/jdk/java/math/BigInteger/DivisionOverflow.java
test/jdk/java/math/BigInteger/StringConstructorOverflow.java
test/jdk/java/math/BigInteger/SymmetricRangeTests.java
These tests require huge memory and need to run with -Xmx8g
They are skipped or tagged with @ignore and not actually run in
Thank you for reviewing David. I will update/push the change as you
suggested.
BTW, sorry for the wrong bug number in email subject, it should be 8209824.
Thank you
-Hamlin
On 2019/10/15 10:29 AM, David Holmes wrote:
Hi Hamlin,
On 15/10/2019 12:03 pm, Hamlin Li wrote:
Could some help to
Thanks for reviewing, I updated change at:
http://cr.openjdk.java.net/~mli/8134599/webrev.01/
it does not increase minimum time time and consider timeout factor at
the same time.
Thank you
-Hamlin
On 2019/10/15 10:43 AM, Joe Darcy wrote:
Hello,
Structurally, I'd prefer an approach that
Hello,
Structurally, I'd prefer an approach that doesn't increase the minimum
time needed to run the test.
Any timeout-like value used within the test code should be sensitive to
the jtreg timeout factor, as done in the webrev.
Thanks,
-Joe
On 10/14/2019 7:20 PM, Weijun Wang wrote:
Hi Hamlin,
On 15/10/2019 12:03 pm, Hamlin Li wrote:
Could some help to review it?
Basic test seems okay but a few minor suggestions:
1. Please add a public summary to the bug report to convey the same
information as:
27 * @summary per latest JDK code coverage report, 2 methods
+SeanC
The wait might unnecessarily increase the test time. Maybe you can do something
like this:
int timeout = 10;
while (timeout > 0) {
sleep(one second);
verifyPortFree && return;
timeout--;
}
throw new Exception(still not freed);
And Sean, back in JDK-8016728
Could some help to review it?
Thank you
-Hamlin
On 2019/9/4 3:16 PM, Hamlin Li wrote:
Would you please review the following patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8209824
webrev: http://cr.openjdk.java.net/~mli/8209824/webrev.00/
Thank you
-Hamlin
Hi,
The test is failing more frequently, could some help to review it?
Thank you
-Hamlin
On 2019/9/4 11:11 AM, Hamlin Li wrote:
some background & comment: in most of failures, the
"test.timeout.factor" is 10.0 or 8.0, so in the test code this factor
should be considered in rmi operations
Hello,
Expanding the serialization review to include the java.util.concurrent
package, please review the proposed changes:
JDK-8232230: Suppress warnings on non-serializable non-transient
instance fields in java.util.concurrent
http://cr.openjdk.java.net/~darcy/8232230.0/
MethodHandles::lookup produces a Lookup object on the caller class. The
original intention for a Lookup object whose lookup class is always a
non-array and non-primitive class.
MethodHandles::privateLookupIn and Lookup::in are the two other ways
that can produce a new Lookup object and they
Hello.
Could you review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8232161
Change: https://cr.openjdk.java.net/~itakiguchi/8232161/webrev.00/
I have a concern about 1-way trip conversion entries (4 entries) on
MS950 charset.
The detail information is in JDK-8232161 [1]
[1]
Hi everybody,
JEP 358 is targeted to jdk14.
If there are no objections, I'll push this change tomorrow or
on Wednesday.
I'll do one final pass of jdk/submit before pushing.
The final webrev:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/21/
Best regards,
Goetz.
> -Original
15 matches
Mail list logo
