Re: [JPackage] Launcher should support command line arguments

HI Tobias, What build of jpackage do you use? There should be no such issue in recent jpackage builds. Please check https://jdk.java.net/jpackage/ for the latest EA JDK build with jpackage. - Alexey On 10/25/2019 12:20 PM, Tobias Diez wrote: Hello everybody, currently, the default launcher

Re: RFR: JDK-8232879: (zipfs) Writing out data with ZipFileSystem leads to a CRC failure in the generated jar file

> On Oct 25, 2019, at 10:10 PM, Jaikiran Pai wrote: > > Thank you for the review, Lance. > You are very welcome Jaikiran. > On 26/10/19 4:25 AM, Lance Andersen wrote: >> >> The change to Zip FS looks good. I re-worked the test so that it also runs >> against ZipFile (which uses the CEN vs

Re: RFR: 8232864: Classes generated by GenerateJLIClassesPlugin.java are not reproducable

Hi Mandy, Thanks for your review and help. I think your refactoring is a nice improvement. Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.03/ It seems much better now. Testing:  - make test TEST="tier1 tier2 tier3" CONF=release Thanks a lot. Best regards, Jie On 2019/10/26 上午3:29,

Re: RFR: JDK-8232879: (zipfs) Writing out data with ZipFileSystem leads to a CRC failure in the generated jar file

Thank you for the review, Lance. On 26/10/19 4:25 AM, Lance Andersen wrote: > > The change to Zip FS looks good.  I re-worked the test so that it also > runs against ZipFile (which uses the CEN vs the LOC) and Zip FS in > addition to ZipInputStream for extra coverage. > > The webrev can be found

Re: [14] RFR: 8231273: Upgrade CLDR to v36

Hi Roger, Thanks for the review. On 10/25/2019 AD 11:57 午前, Roger Riggs wrote: HI Naoto, cldrconverter/Bundle.java: 233-246:  If there is a parent list, it seems to ignore/drop patterns greater than plist.size(). This would be clearer if it always processed all the patterns and used the

Re: RFR: JDK-8232879: (zipfs) Writing out data with ZipFileSystem leads to a CRC failure in the generated jar file

Hi Jaikiran, Thank you for your patch. The change to Zip FS looks good. I re-worked the test so that it also runs against ZipFile (which uses the CEN vs the LOC) and Zip FS in addition to ZipInputStream for extra coverage. The webrev can be found at:

Re: RFR: 8232864: Classes generated by GenerateJLIClassesPlugin.java are not reproducable

On 10/23/19 11:21 PM, Jie Fu wrote: Hi Mandy, Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.02/ It seems better now. It's better while I think this can be further simplified. line 101 to 217 involves iterating on the default sets/map and then create a new TreeSet and TreeMap

[JPackage] Launcher should support command line arguments

Hello everybody, currently, the default launcher generated by jpackage does not accept command line arguments. On the other hand, the console launcher (--win-console) allows to specify command line arguments but then a command line window is kept open (which is fine for command line applications

Re: [14] RFR: 8231273: Upgrade CLDR to v36

HI Naoto, cldrconverter/Bundle.java: 233-246:  If there is a parent list, it seems to ignore/drop patterns greater than plist.size(). This would be clearer if it always processed all the patterns and used the parent if the pattern[i] was empty and i < plist.size().  Switching around the

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

> On Oct 23, 2019, at 4:58 PM, Alan Bateman wrote: > > On 23/10/2019 19:06, Lance Andersen wrote: >> >>> On Oct 22, 2019, at 2:37 PM, Alan Bateman >> > wrote: >>> >>> I assume skip(Long.MAX_VALUE) will cause n+pos to overflow and it will skip >>> backwards