Hello,
On 1/8/2020 7:22 AM, Maurizio Cimadamore wrote:
Good ideas.
On the implSpec issue I think I got confused by the CSR comment, which
was:
MemoryLayout.byteAlignment() should have an @implSpec tag describing
its default implementation.
I think now that Joe wanted a tag to describe the
Hi Alan,
Thanks for the comment. I added these checks for caution but on further
analysis it appears that these checks are not needed.
1) For PrimitiveRightShift, we have the input array and its length passed as
arguments. Since the input array, result[], is copied using arraycopy, we know
th
Hello,
Some further refinements to the implementation and tests ready for
re-review:
http://cr.openjdk.java.net/~darcy/8233452.4/
The fix-up code for directed roundings (up, down, etc.) was corrected to
properly handle rounding down when the interim result is a power of 10,
in this case
Thanks! CSR finalized.
Maurizio
On 08/01/2020 16:20, Chris Hegarty wrote:
Maurizio,
On 8 Jan 2020, at 16:06, Maurizio Cimadamore
wrote:
Please review this one liner, which is to fix a static implementation field
leaking through the memory access API javadoc:
cr.openjdk.java.net/~mcimadam
Maurizio,
> On 8 Jan 2020, at 16:06, Maurizio Cimadamore
> wrote:
>
> Please review this one liner, which is to fix a static implementation field
> leaking through the memory access API javadoc:
>
> cr.openjdk.java.net/~mcimadamore/8236779
Looks good.
> And corresponding CSR here:
>
> http
> On 8 Jan 2020, at 15:52, Maurizio Cimadamore
> wrote:
>
> New revision:
>
> http://cr.openjdk.java.net/~mcimadamore/8236769_v2
>
> delta from previous:
>
> http://cr.openjdk.java.net/~mcimadamore/8236769_v2_delta/
LGTM.
-Chris.
Please review this one liner, which is to fix a static implementation
field leaking through the memory access API javadoc:
cr.openjdk.java.net/~mcimadamore/8236779
And corresponding CSR here:
https://bugs.openjdk.java.net/browse/JDK-8236780
Cheers
Maurizio
New revision:
http://cr.openjdk.java.net/~mcimadamore/8236769_v2
delta from previous:
http://cr.openjdk.java.net/~mcimadamore/8236769_v2_delta/
Thanks for the comments so far
Maurizio
On 08/01/2020 12:18, Maurizio Cimadamore wrote:
Hi,
this is a small patch which addresses the javadoc issue
> On 8 Jan 2020, at 15:33, Maurizio Cimadamore
> wrote:
>
> I've looked at the java.lang.constant.ClassDesc interface which is similar in
> spirit to what MemoryLayout does: an interface that is not meant to be
> implemented by the user. There are many default methods there, and no
> implS
I've looked at the java.lang.constant.ClassDesc interface which is
similar in spirit to what MemoryLayout does: an interface that is not
meant to be implemented by the user. There are many default methods
there, and no implSpec, except for displayName() (to describe what the
implementation does
Good ideas.
On the implSpec issue I think I got confused by the CSR comment, which was:
MemoryLayout.byteAlignment() should have an @implSpec tag describing
its default implementation.
I think now that Joe wanted a tag to describe the default method
implementation.
I agree that the new tex
> On 8 Jan 2020, at 15:07, Chris Hegarty wrote:
>
> Maurizio,
>
>> On 8 Jan 2020, at 12:36, Maurizio Cimadamore
>> wrote:
>>
>> A link to the webrev might be useful I guess :-)
>>
>> http://cr.openjdk.java.net/~mcimadamore/8236769/
Forgot to add... MemoryAddress equality has no temporal
Maurizio,
> On 8 Jan 2020, at 12:36, Maurizio Cimadamore
> wrote:
>
> A link to the webrev might be useful I guess :-)
>
> http://cr.openjdk.java.net/~mcimadamore/8236769/
Mostly looks good.
Trivially, regarding the use of implSpec in MemoryLayout; I think that the tag
is just not needed, r
A link to the webrev might be useful I guess :-)
http://cr.openjdk.java.net/~mcimadamore/8236769/
Maurizio
On 08/01/2020 12:18, Maurizio Cimadamore wrote:
Hi,
this is a small patch which addresses the javadoc issues in the memory
access API, which were pointed out in the CSR review [1].
Add
Hi,
this is a small patch which addresses the javadoc issues in the memory
access API, which were pointed out in the CSR review [1].
Additionally, this patch also adds a test (contributed by Paul Sandoz,
thanks!), which makes sure that passing values of the wrong type to
memory access var han
On 08/01/2020 07:21, Nick Gasson wrote:
Hi Maurizio,
On 07/01/2020 19:06, Maurizio Cimadamore wrote:
As for integrating this - what are your plans? JDK 14 or panama repo? I
see you have targeted 14 in the issue, which is fine, but the priority
is P4. Needs to be at least a P3 to be pushed in
On 1/8/20 9:45 AM, Aleksey Shipilev wrote:
> On 1/7/20 7:50 AM, Aleksey Shipilev wrote:
>> On 1/6/20 1:48 PM, Alex Kashchenko wrote:
>>> [...]
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236125
>>> Webrev: http://cr.openjdk.java.net/~akasko/jdk/8236125/webrev.00/
>
> Actually, s
On 1/7/20 7:50 AM, Aleksey Shipilev wrote:
> On 1/6/20 1:48 PM, Alex Kashchenko wrote:
>> [...]
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236125
>> Webrev: http://cr.openjdk.java.net/~akasko/jdk/8236125/webrev.00/
>> [...]
Gentle reminder, it would be great to have
18 matches
Mail list logo
