Thank you for reviewing, Aleksei
Regards,
Chris
> On 23 Apr 2020, at 8:39 AM, Aleks Efimov wrote:
>
> Hi Chris,
>
> The changes look good to me.
> Thank you for extending the LDAP test server functionality.
>
> With Best Regards,
> Aleksei
>
> On 22/04/2020 08:27, Chris Yin wrote:
>> Hello
>
Hi Chris,
The changes look good to me.
Thank you for extending the LDAP test server functionality.
With Best Regards,
Aleksei
On 22/04/2020 08:27, Chris Yin wrote:
Hello
Please review following change for enhancement to
com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks
Bug: https://bugs.ope
Typo in the benchmark javadoc: “avarage” instead of “average"
> On Apr 22, 2020, at 4:47 PM, Claes Redestad wrote:
>
>
>
> On 2020-04-22 22:08, Volker Simonis wrote:
>> http://cr.openjdk.java.net/~simonis/webrevs/2020/8242848.02/
>> Notice that this new version only changes the microbenchmark,
On 4/22/20 1:42 PM, Joe Darcy wrote:
On 4/22/2020 6:12 AM, Alan Bateman wrote:
On 22/04/2020 13:50, Andrew Haley wrote:
:
1. Should close() always be idempotent, where practical? I would have
thought so, but perhaps there are downsides.
2. Should classes which implement close() with the st
On 2020-04-22 22:08, Volker Simonis wrote:
http://cr.openjdk.java.net/~simonis/webrevs/2020/8242848.02/
Notice that this new version only changes the microbenchmark, all the
other files are untouched.
As everybody seemed to be happy with the change itself and the
regression test, I'm now wai
Hello,
On 4/22/2020 6:12 AM, Alan Bateman wrote:
On 22/04/2020 13:50, Andrew Haley wrote:
:
1. Should close() always be idempotent, where practical? I would have
thought so, but perhaps there are downsides.
2. Should classes which implement close() with the standard meaning be
AutoClos
On Tue, Apr 21, 2020 at 5:23 PM Lance Andersen
wrote:
>
> Hi Volker,
>
> I think overall this looks OK. I went through the older SCCS histories to
> see if I could figure out why they were using 512 for the input length but
> could not find anything that might shed some light for me.
>
Hi Lanc
Hi Adam,
ok, looks good.
I will sponsor it. (Seeing Thomas's email).
Thanks, Roger
On 4/22/20 12:38 PM, Adam Farley8 wrote:
Hi Tom, Roger,
No, I didn't see that. I'm not sure why.
Sorry about that Roger. :)
Roger's proposal seems a fair compromise.
Here's a webrev for it:
http://cr.ope
Hi Adam,
LGTM.
Cannot sponsor though sorry, totally snowed in right now. If you have
enough changes to become Committer, we could make you one, then you
can sponsor yourself :).
Cheers, Thomas
On Wed, Apr 22, 2020 at 6:38 PM Adam Farley8 wrote:
> Hi Tom, Roger,
>
> No, I didn't see that. I'm
Hi Tom, Roger,
No, I didn't see that. I'm not sure why.
Sorry about that Roger. :)
Roger's proposal seems a fair compromise.
Here's a webrev for it:
http://cr.openjdk.java.net/~afarley/8239365.2/webrev
If this meets both of your approvals, could I ask for a volunteer to
sponsor and merge, pl
Lance, Naoto,
thanks for reviewing!
/Claes
On 2020-04-22 18:19, naoto.s...@oracle.com wrote:
+1
Naoto
On 4/22/20 9:13 AM, Lance Andersen wrote:
Hi Claes,
The latest version looks good.
Thank you for the patch.
Best
Lance
On Apr 22, 2020, at 6:26 AM, Claes Redestad
wrote:
Hi,
new we
+1
Naoto
On 4/22/20 9:13 AM, Lance Andersen wrote:
Hi Claes,
The latest version looks good.
Thank you for the patch.
Best
Lance
On Apr 22, 2020, at 6:26 AM, Claes Redestad wrote:
Hi,
new webrev based on discussions here and offline:
http://cr.openjdk.java.net/~redestad/8243254/open.01/
Hi Claes,
The latest version looks good.
Thank you for the patch.
Best
Lance
> On Apr 22, 2020, at 6:26 AM, Claes Redestad wrote:
>
> Hi,
>
> new webrev based on discussions here and offline:
>
> http://cr.openjdk.java.net/~redestad/8243254/open.01/
>
> - creates a new testng test TestZipF
Hi Takiguchi-san,
Change looks good. I'd expect a test case in
open/test/jdk/java/nio/charset/Charset/RegisteredCharsets.java for the
added "ISO8859_16" alias.
Naoto
On 4/20/20 6:37 PM, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse
On 22/04/2020 13:50, Andrew Haley wrote:
:
1. Should close() always be idempotent, where practical? I would have
thought so, but perhaps there are downsides.
2. Should classes which implement close() with the standard meaning be
AutoCloseable?
I'm sure Joe Darcy can say more on this but
On 4/21/20 10:06 PM, Stuart Marks wrote:
> (The usual objection to this construct is if closing the wrapper closes the
> underlying reader, the t-w-r will close it again. This isn't a problem for
> BufferedReader and most JDK I/O classes, as close() is idempotent for them.)
So here's a Java desi
Hi,
new webrev based on discussions here and offline:
http://cr.openjdk.java.net/~redestad/8243254/open.01/
- creates a new testng test TestZipFileEncodings, which derives from
TestZipFile rather than repurposing that existing test. There is
definitely some overlap, but since TestZipFile is
Hello
Please review following change for enhancement to
com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks
Bug: https://bugs.openjdk.java.net/browse/JDK-8243138
Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/
There is requirement to test starttls extended op against dummy ldap server
18 matches
Mail list logo
