RFR(S) 8241071 Generation of classes.jsa is not deterministic

https://bugs.openjdk.java.net/browse/JDK-8241071 http://cr.openjdk.java.net/~iklam/jdk15/8241071-deterministic-cds-archive.v02/ The goal is to for "java -Xshare:dump" to produce deterministic contents in the CDS archive that depend only on the contents of $JAVA_HOME/lib/modules. Problems: [1]

Re: 8243539: update copyright info for JDK-8241638(Internet mail)

https://hg.openjdk.java.net/jdk/jdk/rev/534855a30ef5 Thanks, Max > On Apr 27, 2020, at 11:56 AM, buddyliao(廖彬) wrote: > > Contributed-by: Bin Liao > > Thanks, > Bin > > 在 2020/4/27 上午11:52，“Weijun Wang” 写入: > >Sure, please provide me a "Contributed-by" line, it should look like > >

Re: 8243539: update copyright info for JDK-8241638(Internet mail)

Contributed-by: Bin Liao Thanks, Bin 在 2020/4/27 上午11:52，“Weijun Wang” 写入: Sure, please provide me a "Contributed-by" line, it should look like Contributed-by: Buddy Liao --Max > On Apr 27, 2020, at 11:48 AM, buddyliao(廖彬) wrote: > > Hi Max, >

Re: 8243539: update copyright info for JDK-8241638(Internet mail)

Sure, please provide me a "Contributed-by" line, it should look like Contributed-by: Buddy Liao --Max > On Apr 27, 2020, at 11:48 AM, buddyliao(廖彬) wrote: > > Hi Max, > > Thanks for your review, and I need a sponsor to help me merge this patch, > would you sponsor me? > > BRs, > Bin >

Re: 8243539: update copyright info for JDK-8241638(Internet mail)

Hi Max, Thanks for your review, and I need a sponsor to help me merge this patch, would you sponsor me? BRs, Bin 在 2020/4/27 上午11:40，“Weijun Wang” 写入: This looks fine to me. Do you need a sponsor? Thanks, Max > On Apr 27, 2020, at 10:53 AM, buddyliao(廖彬) wrote:

Re: RFR: 8243539: update copyright info for JDK-8241638

This looks fine to me. Do you need a sponsor? Thanks, Max > On Apr 27, 2020, at 10:53 AM, buddyliao(廖彬) wrote: > > Dear all, > > Would you help me to review the following tiny fix? Which is used to update > the copyright info for patch > https://hg.openjdk.java.net/jdk/jdk/rev/3f8d03880bf5

RFR: 8243539: update copyright info for JDK-8241638

Dear all, Would you help me to review the following tiny fix? Which is used to update the copyright info for patch https://hg.openjdk.java.net/jdk/jdk/rev/3f8d03880bf5 Bug: https://bugs.openjdk.java.net/browse/JDK-8243539 Webrev: https://cr.openjdk.java.net/~lzang/BuddyLiao/launcher/webrev/

Re: RFR: 8243587: Missing comma in copyright header

> On Apr 26, 2020, at 10:18 PM, Igor Ignatev wrote: > > LGTM > > — Igor > >> On Apr 26, 2020, at 7:14 PM, Kim Barrett wrote: >> >> Please review this fix for a missing comma in the copyright >> header for >>

Re: RFR: 8243587: Missing comma in copyright header

LGTM — Igor > On Apr 26, 2020, at 7:14 PM, Kim Barrett wrote: > > Please review this fix for a missing comma in the copyright > header for > src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/DottedVersion.java. > > CR: >

RFR: 8243587: Missing comma in copyright header

Please review this fix for a missing comma in the copyright header for src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/DottedVersion.java. CR: https://bugs.openjdk.java.net/browse/JDK-8243587 Webrev: https://cr.openjdk.java.net/~kbarrett/8243587/webrev/ Testing: Tested

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

Hi Bin, On 24/04/2020 7:28 pm, buddyliao(廖彬) wrote: Dear all, As Lin mentioned, I found the copyright info is not updated, so I prepared a patch to fix this. Lin helps me to build an issue in the jdk bug system. Would you help me to review this patch? Thank you very much. Patch link:

Re: RFR: 8243469: Lazily encode name in ZipFile.getEntryPos

Hi again, On 2020-04-24 21:22, Claes Redestad wrote: It seems that 'getEntryHitUncached' is getting slightly slower with your change while all the other variants get significantly faster. I don't think that's a problem, but do you have an explanation why that's the case? I've noticed it swing

Trivial patches for typos in java.base

Hi I filed 2 bug reports for typos in java.base Javadoc: https://bugs.openjdk.java.net/browse/JI-9064752 with patch diff --git a/src/java.base/share/classes/java/lang/invoke/package-info.java b/src/java.base/share/classes/java/lang/invoke/package-info.java index 82600d4866..a0ad09b03e