Re: RFR (JDK 15) 8251276: two jdeps files have extra whitespace in copyright header

LGTM Vyom On Fri, Aug 7, 2020 at 10:31 AM wrote: > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8251276 > > Webrev: http://cr.openjdk.java.net/~sundar/8251276/webrev.00/index.html > > Thanks, > > -Sundar > > -- Thanks, Vyom

RFR (JDK 15) 8251276: two jdeps files have extra whitespace in copyright header

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8251276 Webrev: http://cr.openjdk.java.net/~sundar/8251276/webrev.00/index.html Thanks, -Sundar

Re: RFR [16]: 8250665 : Wrong translation for the month of May in ar_JO, ar_LB and ar_SY

Thank you Naoto, pushed. -Leo On 8/7/20 2:18 AM, naoto.s...@oracle.com wrote: Looks good to me. Naoto On 8/6/20 9:47 AM, li.ji...@oracle.com wrote: Hi, Pls review the fix for month names in COMPAT provider data for ar_JO/LB/SY. Customer reported some month names are incorrect in JDK8 cod

Re: 8251272: Typo in java.util.Formatter: "Numberic" should be "Numeric"

+1 Sent from my iPad > On Aug 6, 2020, at 7:55 PM, Brian Burkhalter > wrote: > > For [1], please review this trivial fix [2]. > > Thanks, > > Brian > > [1] https://bugs.openjdk.java.net/browse/JDK-8251272 > [2] diff > > --- a/src/java.base/share/classes/java/util/Formatter.java > +++ b/sr

Re: RFR 8251202: Add missing javadoc comments

Hi Naoto Thank you for catching that Will add them before I push the change Best Lance -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Aug 6, 2020, at 7:

Re: RFR 8251202: Add missing javadoc comments

Looks good, Lance. nit: a couple of comments (line 128,133) don't end with periods. Naoto On 8/6/20 3:32 PM, Lance Andersen wrote: Hi all, Please review the webrev for: https://bugs.openjdk.java.net/browse/JDK-8251202 , which adds missing jav

Re: 8251272: Typo in java.util.Formatter: "Numberic" should be "Numeric"

+1 Good catch! Naoto On 8/6/20 4:12 PM, Brent Christian wrote: Looks good! -Brent On 8/6/20 3:54 PM, Brian Burkhalter wrote: For [1], please review this trivial fix [2]. Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8251272 [2] diff --- a/src/java.base/share/classes/java/uti

Re: 8251272: Typo in java.util.Formatter: "Numberic" should be "Numeric"

Looks good! -Brent On 8/6/20 3:54 PM, Brian Burkhalter wrote: For [1], please review this trivial fix [2]. Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8251272 [2] diff --- a/src/java.base/share/classes/java/util/Formatter.java +++ b/src/java.base/share/classes/java/util/Format

8251272: Typo in java.util.Formatter: "Numberic" should be "Numeric"

For [1], please review this trivial fix [2]. Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8251272 [2] diff --- a/src/java.base/share/classes/java/util/Formatter.java +++ b/src/java.base/share/classes/java/util/Formatter.java @@ -277,7 +277,7 @@ * * * - * For category Gener

RFR 8251202: Add missing javadoc comments

Hi all, Please review the webrev for: https://bugs.openjdk.java.net/browse/JDK-8251202 , which adds missing javadoc comments to java.util.zip.ZipConstants. The webrev can be found at: http://cr.openjdk.java.net/~lancea/8251205/webrev.00/ The C

RFR [testbug]: 8250772: Test com/sun/jndi/ldap/NamingExceptionMessageTest.java fails intermittently with javax.naming.ServiceUnavailableException

Hi, Please, help to review NamingExceptionMessageTest test stabilization change: There is a race condition between the closure of connection in test LDAP server and the JDKs LDAP client code. Due to this race the test could generate ServiceUnavailableException instead of the required NamingExce

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

Hi Raffaello, I think the source change is correct, it’s just that for a deterministic issue, the test generally will fail before the source change and pass with the source change applied. I did not investigate any further, either. Thanks, Brian > On Aug 6, 2020, at 2:36 PM, Raffaello Giuliet

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

Hi Brian, the body of readFully() seems to silently assume that the other arguments are correct (e.g., off >= 0 and so on). In the (still) current implementation of DataInputStream.readFully(byte[], int, int), when off < 0 and len > 0, in the loop it then invokes the underlying in.read(byte[

Re: RFR [16/java.xml] 8246816: XMLGregorianCalendar.hashCode() produces far too many identical hashes

Thanks Naoto, Roger!  I'll prepare push based on version 01. Best, Joe On 8/6/20 1:29 PM, Roger Riggs wrote: +1 On 8/6/20 4:18 PM, naoto.s...@oracle.com wrote: Hi Joe, thank you for looking it into further. Yes, I agree the chances of collision is very rare, as sub-millisecond difference in

Re: RFR [16/java.xml] 8246816: XMLGregorianCalendar.hashCode() produces far too many identical hashes

+1 On 8/6/20 4:18 PM, naoto.s...@oracle.com wrote: Hi Joe, thank you for looking it into further. Yes, I agree the chances of collision is very rare, as sub-millisecond difference in two objects. So fine with the version 01. Naoto On 8/6/20 12:18 PM, Joe Wang wrote: Thanks Naoto, Roger for

Re: RFR [16/java.xml] 8246816: XMLGregorianCalendar.hashCode() produces far too many identical hashes

Hi Joe, thank you for looking it into further. Yes, I agree the chances of collision is very rare, as sub-millisecond difference in two objects. So fine with the version 01. Naoto On 8/6/20 12:18 PM, Joe Wang wrote: Thanks Naoto, Roger for the review! For Naoto's concern about the equals me

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

> On Aug 6, 2020, at 12:36 PM, Raffaello Giulietti > wrote: > >> This looks all right. I would be inclined to do like in [1] and throw the >> RuntimeException on the line after each readFully() and drop the return >> statements], but I’m not going to insist on it. >> Thanks, >> Brian >> [1]

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

On 2020-08-06 20:51, Brian Burkhalter wrote: Hi Raffaello, This looks all right. I would be inclined to do like in [1] and throw the RuntimeException on the line after each readFully() and drop the return statements], but I’m not going to insist on it. Thanks, Brian [1] http://hg.openjd

Re: RFR [16/java.xml] 8246816: XMLGregorianCalendar.hashCode() produces far too many identical hashes

Thanks Naoto, Roger for the review! For Naoto's concern about the equals method using EonAndYear and FractionalSecond, I did cut corners using the all int getXXX method. The rational was: it fulfills the equals-hashcode contract just fine, is consistent with the existing implementation, and co

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

Hi Raffaello, This looks all right. I would be inclined to do like in [1] and throw the RuntimeException on the line after each readFully() and drop the return statements], but I’m not going to insist on it. Thanks, Brian [1] http://hg.openjdk.java.net/jdk/jdk/file/db6952bf8c39/test/jdk/java

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

Hi, here's the newest patch. > Also, instead of using the boolean “caughtException,” we usually just > put, e.g., the throwing of the RuntimeException on the line after where > the IIOBE or whatever would be thrown. I don’t think the “finally” block > is necessary. > > Thanks, > > Brian Greeti

Re: RFR [16]: 8250665 : Wrong translation for the month of May in ar_JO, ar_LB and ar_SY

Looks good to me. Naoto On 8/6/20 9:47 AM, li.ji...@oracle.com wrote: Hi, Pls review the fix for month names in COMPAT provider data for ar_JO/LB/SY. Customer reported some month names are incorrect in JDK8 code according to latest CLDR definition. Bug: https://bugs.openjdk.java.net/browse

Re: RFR (JDK 15) 8248299: two jdeps files miss copyright header

To clarify, I actually reviewed webrev.01. Mandy On 8/6/20 9:34 AM, Mandy Chung wrote: +1 Mandy On 8/6/20 8:03 AM, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8248299 Webrev: http://cr.openjdk.java.net/~sundar/8248299/webrev.0

Re: RFR: JDK-8251184: File association without description causes exception

Looks good. - Alexey On 8/5/2020 4:17 PM, Andy Herrick wrote: Please review this jpackage fix at [1] to issue [2] [1] - http://cr.openjdk.java.net/~herrick/8251184/ [2] - https://bugs.openjdk.java.net/browse/JDK-8251184 /Andy

RFR [16]: 8250665 : Wrong translation for the month of May in ar_JO, ar_LB and ar_SY

Hi, Pls review the fix for month names in COMPAT provider data for ar_JO/LB/SY. Customer reported some month names are incorrect in JDK8 code according to latest CLDR definition. Bug: https://bugs.openjdk.java.net/browse/JDK-8250665 Webrev: http://cr.openjdk.java.net/~ljiang/8250665/webrev.0

Re: RFR (JDK 15) 8248299: two jdeps files miss copyright header

+1 Mandy On 8/6/20 8:03 AM, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8248299 Webrev: http://cr.openjdk.java.net/~sundar/8248299/webrev.00/ Thanks, -Sundar

Re: JDK 16 RFR of JDK-5017980: Allow signed positive integer to be parsed instead of a NumerFormatException

Hi Joe, CSR reviewed; patch looks fine. Brian > On Aug 5, 2020, at 11:47 PM, Joe Darcy wrote: > > - * BigInteger. The String representation consists of an optional minus > + * BigInteger. The String representation consists of an optional minus > or plus

Re: RFR (JDK 15) 8248299: two jdeps files miss copyright header

Oops. Missed "Classpath exception" clause. Updated: http://cr.openjdk.java.net/~sundar/8248299/webrev.01/ -Sundar On 06/08/20 8:33 pm, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8248299 Webrev: http://cr.openjdk.java.net/~sunda

RFR (JDK 15) 8248299: two jdeps files miss copyright header

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8248299 Webrev: http://cr.openjdk.java.net/~sundar/8248299/webrev.00/ Thanks, -Sundar

Re: RFR [16/java.xml] 8246816: XMLGregorianCalendar.hashCode() produces far too many identical hashes

Hi Joe, Looks fine. Roger On 8/5/20 7:37 PM, Joe Wang wrote: Hello, Please review a fix for the hashCode generation. JBS: https://bugs.openjdk.java.net/browse/JDK-8246816 webrev: http://cr.openjdk.java.net/~joehw/jdk16/8246816/webrev/ Thanks, Joe

RFR[testbug]: 8251189: com/sun/jndi/ldap/LdapDnsProviderTest.java failed due to timeout

Hi, LdapDnsProviderTest was seen failing due to the timeout caused by the blocked bind operation. That could happen if there is a local process listening on the port specified in the test URL. To make LdapProviderTest.ProviderTest.call fail the LDAP connect timeout property needs to be set to