On Wed, 16 Sep 2020 16:36:54 GMT, Fei Yang wrote:
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>
> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
> Extensions:
>
On Thu, 22 Oct 2020 03:59:45 GMT, Vladimir Kozlov wrote:
> tier1,2,3 passed. I verified that new SHA3 tests were run and passed.
> But because SHA3 is not enabled for now (even on aarch64), it does not test
> asm code.
> At least testing verified that changes in shared code does not cause any
On Wed, 21 Oct 2020 23:42:33 GMT, Fei Yang wrote:
>> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>>
>> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
>> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
>> Extensions:
>>
On Thu, 22 Oct 2020 01:36:59 GMT, Vladimir Kozlov wrote:
> Tier3 testing clean with updated test.
Thank you for identifying the problem, the fix, then rebuilding and rerunning
the tests!
-
PR: https://git.openjdk.java.net/jdk/pull/293
On Wed, 21 Oct 2020 20:43:30 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for the intrinsic. The API is
>> similar to the existing
On Wed, 21 Oct 2020 19:20:28 GMT, Vladimir Kozlov wrote:
>> OK. Will update with the following change after Aleksey's PR is integrated:
>>
>> ---
>> a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
On Tue, 20 Oct 2020 23:42:31 GMT, Mandy Chung wrote:
>> Hi Mandy,
>>
>> You're right. I haven't thought of what one can do with a Lookup for one
>> proxy class when other proxy classes are co-located in the same module
>> and/or package. So instead of a Lookup, we could use some other more
On Wed, 21 Oct 2020 20:17:32 GMT, Sandhya Viswanathan
wrote:
> Additional tests to increase Vector API public method code coverage to > 99%.
This pull request has now been integrated.
Changeset: 5d262290
Author:Sandhya Viswanathan
URL:
On Wed, 21 Oct 2020 20:17:32 GMT, Sandhya Viswanathan
wrote:
> Additional tests to increase Vector API public method code coverage to > 99%.
I already reviewed these test updates when integrated into the
`vectorIntrinsics` branch of the `panama-vector` repository.
-
Marked as
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>
> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
> Extensions:
>
> Hi,
>
> Please review the changes to the subject issue. The fix replaces the
> obsolete/incorrect English language/region/script display names in the COMPAT
> root locale bundle. The data are derived from CLDR's English names.
Naoto Sato has updated the pull request incrementally with one
On Wed, 21 Oct 2020 23:01:59 GMT, Brent Christian wrote:
>> Hi,
>>
>> Please review the changes to the subject issue. The fix replaces the
>> obsolete/incorrect English language/region/script display names in the
>> COMPAT root locale bundle. The data are derived from CLDR's English names.
>
On Wed, 21 Oct 2020 17:03:33 GMT, Alexey Semenyuk wrote:
> Don't run ldd and build list of dependency packages in case jpackage builds
> DEB package on non Debian Linux and RPM on Debian Linux. In this cases
> attempts to detect what packages provide libs will fail anyways, so don't
> waste
On Wed, 21 Oct 2020 20:39:18 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes to the subject issue. The fix replaces the
> obsolete/incorrect English language/region/script display names in the COMPAT
> root locale bundle. The data are derived from CLDR's English names.
Hi, Naoto
On Wed, 21 Oct 2020 20:31:24 GMT, Paul Sandoz wrote:
>> The zero methods on `IntVector` and all other specializations are missing
>> documentation.
>
> Paul Sandoz has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address CSR review.
On Mon, 19 Oct 2020 19:43:13 GMT, Paul Sandoz wrote:
> The zero methods on `IntVector` and all other specializations are missing
> documentation.
This pull request has now been integrated.
Changeset: 60d3fa2e
Author:Paul Sandoz
URL: https://git.openjdk.java.net/jdk/commit/60d3fa2e
On Wed, 21 Oct 2020 20:12:55 GMT, Vladimir Kozlov wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> CheckGraalIntrinsics.java: fix copy/paste error
>
> Changes requested by kvn (Reviewer).
Note, tier1 and tier2
Hi,
Please review the changes to the subject issue. The fix replaces the
obsolete/incorrect English language/region/script display names in the COMPAT
root locale bundle. The data are derived from CLDR's English names.
-
Commit messages:
- 8255086: JRE country and region name may
On Wed, 21 Oct 2020 20:12:47 GMT, Vladimir Kozlov wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> CheckGraalIntrinsics.java: fix copy/paste error
>
> test/hotspot/jtreg/compiler/intrinsics/base64/TestBase64.java
> This patch set encompasses the following commits:
>
> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
> decodeBlock(), and provides a flexible API for the intrinsic. The API is
> similar to the existing encodeBlock intrinsic.
> - Adds the code in HotSpot to check and
Additional tests to increase Vector API public method code coverage to > 99%.
-
Commit messages:
- 8255174: Vector API unit tests for missed public api code coverage
Changes: https://git.openjdk.java.net/jdk/pull/785/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=785=00
> The zero methods on `IntVector` and all other specializations are missing
> documentation.
Paul Sandoz has updated the pull request incrementally with one additional
commit since the last revision:
Address CSR review.
-
Changes:
- all:
On Wed, 21 Oct 2020 01:51:26 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for the intrinsic. The API is
>> similar to the existing
> JDK-8252870: Finalize (remove "incubator" from) jpackage
Andy Herrick has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains five commits:
- Merge branch master into JDK-8252870
- Merge branch 'master' into JDK-8252870
- JDK-8252870:
On Wed, 21 Oct 2020 09:19:57 GMT, Fei Yang wrote:
> > Someone in Oracle have to run tier1-tier3 testing with these changes to
> > make sure nothing is broken. I don't want to repeat 8254790.
>
> That's appreciated.
> On my side, I run tier1-tier3 both on aarch64 linux and x86_64 linux.
> The
On Wed, 21 Oct 2020 11:33:27 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On Tue, 20 Oct 2020 17:23:26 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On Wed, 21 Oct 2020 18:05:26 GMT, Brent Christian wrote:
>> Hi,
>>
>> The java/util/prefs/AddNodeChangeListener.java test fails once in a while in
>> the automated test system. Previous failures were traced to machine
>> configuration errors, but that does not appear to be the case this
Hi Lance,
Yes, this is exactly the point where the problem is in JDK code. It's directly
related to the zip entry beyond max int offset. The code tries to read data
from a local zip entry header at locoff, here:
if (zipfs.readFullyAt(buf, 0, buf.length , locoff)
but the locoff is set to ~0 as
On Wed, 21 Oct 2020 17:33:26 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 20 Oct 2020 14:37:01 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 127:
>>
>>> 125: *
>>> 126: * @implSpec
>>> 127: * This class is immutable and thread-safe.
>>
>> I'm curious why this is an implSpec, and not just a normative statement?
>>
> Hi,
>
> The java/util/prefs/AddNodeChangeListener.java test fails once in a while in
> the automated test system. Previous failures were traced to machine
> configuration errors, but that does not appear to be the case this time.
>
> My efforts to reproduce this failure have been
On Tue, 20 Oct 2020 23:25:31 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> The java/util/prefs/AddNodeChangeListener.java test fails once in a while in
>> the automated test system. Previous failures were traced to machine
>> configuration errors, but that does not appear to be the case this
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of
On Wed, 21 Oct 2020 16:28:21 GMT, CoreyAshford
wrote:
>> Buried in that GitHub test run link are the results for
>> windows-x64-debug_testlogs_hs_tier1_compiler
>> which includes this file (test-summary.txt):
>>
>> ==
>> Test summary
>>
Don't run ldd and build list of dependency packages in case jpackage builds DEB
package on non Debian Linux and RPM on Debian Linux. In this cases attempts to
detect what packages provide libs will fail anyways, so don't waste time and
pollute jpackage log output.
-
Commit
On Wed, 2020-10-21 at 12:43 +0200, Aleksey Shipilev wrote:
> On 10/21/20 11:17 AM, Severin Gehwolf wrote:
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8250984
> > > webrev:
> > > https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250984/01/webrev/
>
> Looks fine to me.
Thanks for the
Hi David,
From a quick look at ZipFileSystem this appears to be an optimization to avoid
looking at the LOC extended Timestamp Extra field
If a Info-ZIP Extended Timestamp (0x5455)is found then:
If the "zipinfo-time" entry was set to “false” in the Map specified when
creating the Zip
On Sun, 6 Sep 2020 15:25:10 GMT, Raffaello Giulietti
wrote:
> This is a follow-up of the Mercurial-based workflow initiated on the
> core-lib-devs mailing list [0]. Not sure if this one is strictly necessary or
> if the patches sent on the list are sufficient. Anyway, I exploit this PR as
>
On Wed, 21 Oct 2020 13:42:48 GMT, Daniel D. Daugherty
wrote:
> Buried in that GitHub test run link are the results for
> windows-x64-debug_testlogs_hs_tier1_compiler
> which includes this file (test-summary.txt):
>
> ```
> ==
> Test summary
>
On Mon, 19 Oct 2020 14:58:22 GMT, Raffaello Giulietti
wrote:
>> This is a follow-up of the Mercurial-based workflow initiated on the
>> core-lib-devs mailing list [0]. Not sure if this one is strictly necessary
>> or if the patches sent on the list are sufficient. Anyway, I exploit this PR
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Wed, 21 Oct 2020 13:00:09 GMT, Martin Doerr wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> CheckGraalIntrinsics.java: fix copy/paste error
>
> Marked as reviewed by mdoerr (Reviewer).
Buried in that GitHub
On Wed, 21 Oct 2020 01:51:26 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for the intrinsic. The API is
>> similar to the existing
> This is the current proposed patch for the upcoming JEP 394, for pattern
> matching for instanceof.
>
> A summary of changes:
> -making the feature permanent (non-preview)
> -making the binding variables non-final (as per current specification
> proposal)
> -producing a compile-time error for
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>>
On Wed, 21 Oct 2020 02:55:49 GMT, David Holmes wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve wording in refersTo javadoc
>
> Update looks good. Need to reflect the change in the CSR.
>
> Thanks.
> David
On Mon, 19 Oct 2020 11:24:45 GMT, Jorn Vernee wrote:
>> I looked through some Hotspot runtime code and that looks ok. I saw a
>> couple of strange things on my way through the code. See comments.
>
> Hi David, this code somewhat predates me, so I initially kept the JVM_ENTRY
> since that was
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On 10/21/20 11:17 AM, Severin Gehwolf wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8250984
webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250984/01/webrev/
Looks fine to me.
--
Thanks,
-Aleksey
On Wed, 21 Oct 2020 03:11:28 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits
On Wed, 21 Oct 2020 03:26:57 GMT, Vicente Romero wrote:
>> I believe plain jtreg invocations may not be always setting "-g". So
>> probably better to be explicitly clear we need -g, as the test itself
>> requires the debugging info/LocalVariableTable?
>
> sure I understand that the `-g` option
On Tue, 20 Oct 2020 23:08:22 GMT, Vladimir Kozlov wrote:
> Someone in Oracle have to run tier1-tier3 testing with these changes to make
> sure nothing is broken. I don't want to repeat 8254790.
That's appreciated.
On my side, I run tier1-tier3 both on aarch64 linux and x86_64 linux.
The test
Gentle reminder. Anyone?
On Fri, 2020-10-09 at 18:18 +0200, Severin Gehwolf wrote:
> Hi,
>
> Please review this backport for Oracle 11.0.10 parity. The jdk-jdk
> patch needs to be significantly reworked since JDK 15+ has the cgroups
> v2 patches. The gist of the change is to only report memory
> This is the current proposed patch for the upcoming JEP 394, for pattern
> matching for instanceof.
>
> A summary of changes:
> -making the feature permanent (non-preview)
> -making the binding variables non-final (as per current specification
> proposal)
> -producing a compile-time error for
On Tue, 20 Oct 2020 23:06:41 GMT, Vladimir Kozlov wrote:
>> Fei Yang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 13 commits:
>>
>> - Fix trailing whitespace issue reported by jcheck
>> - Merge master
>> - Merge master
>>
Hello,
We've encountered a seemingly valid ZIP file (zipinfo -v shows all its
entries are intact) that causes a runtime exception when scanning its
contents with ZipFileSystem. The exception indicates an invalid
signature when parsing EXTID_EXTT. I don't quite understand this
comment in the code:
On Wed, 21 Oct 2020 01:33:48 GMT, CoreyAshford
wrote:
>> Please, update
>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
>
>> Please, update
>>
59 matches
Mail list logo
