Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

On Thu, 5 Nov 2020 23:58:21 GMT, Dean Long wrote: >> Roland Westrelin has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains ten commits: >> >> - Jorn's comments >> - Update headers and add intrinsic to Graal test ignore list >> -

Re: RFR: 8180352: Add Stream.toList() method

On Fri, 6 Nov 2020 03:01:42 GMT, Stuart Marks wrote: >> Looking at the linked issue, I see [this comment from Rémi >> Forax](https://bugs.openjdk.java.net/browse/JDK-8180352?focusedCommentId=14171626=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14171626): >> >>>

Re: RFR: 8180352: Add Stream.toList() method

On Wed, 4 Nov 2020 23:18:29 GMT, Paŭlo Ebermann wrote: >> Changes requested by orio...@github.com (no known OpenJDK username). > > Looking at the linked issue, I see [this comment from Rémi >

Re: RFR: 8247781: Day periods support [v7]

On Thu, 5 Nov 2020 23:25:38 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed typo/grammatical error. > > test/jdk/java/time/tck/java/time/format/TCKDateTimeParseResolver.java line >

Re: RFR: 8180352: Add Stream.toList() method

On Fri, 6 Nov 2020 02:50:29 GMT, Stuart Marks wrote: >> test/jdk/java/util/stream/test/org/openjdk/tests/java/util/stream/ToListOpTest.java >> line 73: >> >>> 71: } >>> 72: >>> 73: @Test(dataProvider = "withNull:StreamTestData", >>> dataProviderClass = StreamTestDataProvider.class)

Re: RFR: 8180352: Add Stream.toList() method

On Thu, 5 Nov 2020 19:47:43 GMT, Paul Sandoz wrote: >> This change introduces a new terminal operation on Stream. This looks like a >> convenience method for Stream.collect(Collectors.toList()) or >> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this >> method directly

Re: Filtered XMLStreamReader Exceptions (java.xml)

Hi Mike, I saw that you are on the OCA list but not census , I therefore assumed you'd need a sponsor, or would you?  Let me know if I'm mistaken. If you're an openjdk author/committer and have a JBS account, please go ahead take over the bug and create a

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Thu, 5 Nov 2020 14:59:56 GMT, Alan Bateman wrote: > If we are changing NativeMethodAccessorImpl.invoke then we should probably do > NativeConstructorAccessorImpl.newInstance at the same time. Yes, NativeConstructorAccessorImpl should also apply this change. > Also wondering if we should,

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

On Thu, 5 Nov 2020 15:47:31 GMT, Roland Westrelin wrote: >> This change add 3 new methods in Objects: >> >> public static long checkIndex(long index, long length) >> public static long checkFromToIndex(long fromIndex, long toIndex, long >> length) >> public static long checkFromIndexSize(long

Re: RFR: 8247781: Day periods support [v7]

On Thu, 5 Nov 2020 17:12:11 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8247781: Day periods support [v7]

On Mon, 2 Nov 2020 23:21:22 GMT, Naoto Sato wrote: >> Pulling on this a little more. >> >> As the PR stands, it seems that if the user passes in text with just a >> day-period of "AM" they get a `LocalTime` of 06:00 but if they pass in >> `AMPM_OF_DAY` of "AM" the get no `LocalTime` in the

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v3]

On Thu, 5 Nov 2020 18:18:16 GMT, Andy Herrick wrote: >> JVM > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional >

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On 5/11/2020 7:09 pm, Aleksey Shipilev wrote: On Thu, 5 Nov 2020 02:52:05 GMT, Hui Shi wrote: …AccessorImpl object We met real problem when using protobuf with option optimized for code size, detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 Optimize solution is adding a new

Re: RFR: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags [v2]

On Thu, 5 Nov 2020 22:10:07 GMT, Brian Burkhalter wrote: >> Please review this change which would replace the use of a system property >> and a child process with updated jtreg tags. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags [v2]

On Thu, 5 Nov 2020 21:53:40 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using >> jtreg tags > >

Re: RFR: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags [v2]

> Please review this change which would replace the use of a system property > and a child process with updated jtreg tags. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8255969: Improve

Re: RFR: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags

On Thu, 5 Nov 2020 19:50:14 GMT, Brian Burkhalter wrote: > Please review this change which would replace the use of a system property > and a child process with updated jtreg tags. test/jdk/java/io/BufferedInputStream/LargeCopyWithMark.java line 29: > 27: * @summary BufferedInputStream

Re: Filtered XMLStreamReader Exceptions (java.xml)

The bug for this issue was accepted: JDK-8255918. I have made the change that I suggested in my original email and tested, but have not yet opened a pull request. Please let me know what (if anything) needs to occur for the CSR process due to the method signature change (added `throws`). Thank

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this

RFR: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags

Please review this change which would replace the use of a system property and a child process with updated jtreg tags. - Commit messages: - 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags Changes:

Re: RFR: 8180352: Add Stream.toList() method

On Tue, 3 Nov 2020 01:33:32 GMT, Stuart Marks wrote: > This change introduces a new terminal operation on Stream. This looks like a > convenience method for Stream.collect(Collectors.toList()) or > Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this > method directly on

Re: RFR: JDK-8255395 Implement Enhanced Pseudo-Random Number Generators (CSR)

Hello, Not sure if it is needed to implement a new RandumGenerator interface instead of extending SecureRandom, but the extensions and the discovery mechanism looks good. One thing I am wondering about is if reseed() and reseed(Param) should be part of the new RandomGenerator interface as

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v3]

> JVM Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]

On 11/5/2020 4:45 AM, Jan Lahoda wrote: FWIW, a javadoc generated with the current version of the patch: http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.01/api/index.html Allow me to draw people's attention to the PREVIEW link in the banner of the generated javadoc. It shows all the

Re: RFR: 8180352: Add Stream.toList() method

At the risk of a can of worms, or at least of raising something that has long since been discussed and rejected... This discussion of unmodifiable lists brings me back to the thought that there would be good client-side reasons for inserting an UnmodifiableList interface as a parent of LIst, not

Re: RFR: 8180352: Add Stream.toList() method

On Wed, 4 Nov 2020 23:03:02 GMT, Paŭlo Ebermann wrote: >> This change introduces a new terminal operation on Stream. This looks like a >> convenience method for Stream.collect(Collectors.toList()) or >> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this >> method

RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler

This patch adds jcmd Thread.print to the jtreg timeout handler. Please review. - Commit messages: - Add jcmd thread.print to timeout handler Changes: https://git.openjdk.java.net/jdk/pull/1080/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1080=00 Issue:

Re: RFR: 8180352: Add Stream.toList() method

On Wed, 4 Nov 2020 09:46:32 GMT, Zheka Kozlov wrote: >> This change introduces a new terminal operation on Stream. This looks like a >> convenience method for Stream.collect(Collectors.toList()) or >> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this >> method

Re: RFR: 8247781: Day periods support [v7]

On Thu, 5 Nov 2020 17:12:11 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v22]

> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which

Re: RFR: 8247781: Day periods support [v7]

> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8247781: Day periods support [v7]

On Thu, 5 Nov 2020 16:07:30 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed typo/grammatical error. > > src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java > line 1479:

Re: RFR: 8247781: Day periods support [v3]

On Mon, 2 Nov 2020 19:20:10 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed exception messages. > > src/java.base/share/classes/java/time/format/Parsed.java line 180: > >> 178:

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

On Thu, 5 Nov 2020 15:42:54 GMT, Roland Westrelin wrote: >> src/java.base/share/classes/java/lang/IndexOutOfBoundsException.java line 83: >> >>> 81: */ >>> 82: public IndexOutOfBoundsException(long index) { >>> 83: super("Index out of range: " + index); >> >> For consistency

Re: RFR: 8247781: Day periods support [v3]

On Fri, 30 Oct 2020 22:03:08 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting

Re: RFR: 8247781: Day periods support [v6]

On Wed, 4 Nov 2020 22:13:25 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Thu, 5 Nov 2020 14:59:56 GMT, Alan Bateman wrote: >> I do wonder if it makes sense to handle triple-state `int` here: "not yet >> generated", "generated", "in error"? So that we don't try to generate the >> accessor over and over again when it is in error? > > If we are changing

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

> This change add 3 new methods in Objects: > > public static long checkIndex(long index, long length) > public static long checkFromToIndex(long fromIndex, long toIndex, long length) > public static long checkFromIndexSize(long fromIndex, long size, long length) > > This mirrors the int utility

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

On Thu, 5 Nov 2020 11:58:43 GMT, Jorn Vernee wrote: > Although I'm not a 'Reviewer', I've done a pass over the code and left some > inline comments that I hope you find useful. Thanks for the review! All suggestions (except the exception message one that I commented on) look good to me. I

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Thu, 5 Nov 2020 09:07:13 GMT, Aleksey Shipilev wrote: >> …AccessorImpl object >> >> We met real problem when using protobuf with option optimized for code size, >> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 >> >> Optimize solution is adding a new boolean field to detect

Integrated: 8255214: Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager

On Wed, 4 Nov 2020 21:52:56 GMT, Rahul Yadav wrote: > Hello, > > Request to review this small change, as HTML4 support has been dropped from > javadoc. > Have replaced valign="top" with style="vertical-align:top". This pull request has now been integrated. Changeset: 867a484d Author:

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Thu, 5 Nov 2020 09:05:55 GMT, Aleksey Shipilev wrote: >> …AccessorImpl object >> >> We met real problem when using protobuf with option optimized for code size, >> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 >> >> Optimize solution is adding a new boolean field to detect

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Thu, 5 Nov 2020 09:02:55 GMT, Aleksey Shipilev wrote: >> …AccessorImpl object >> >> We met real problem when using protobuf with option optimized for code size, >> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 >> >> Optimize solution is adding a new boolean field to detect

Re: RFR: 8254354: Add a withInvokeExactBehavior() VarHandle combinator [v12]

On Mon, 2 Nov 2020 11:22:07 GMT, Jorn Vernee wrote: >> Hi, >> >> This patch adds an asExact() combinator to VarHandle, that will return a new >> VarHandle that performs exact type checks, similar to >> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, >> which can

RFR: JDK-8255395 Implement Enhanced Pseudo-Random Number Generators (CSR)

Please review the CSR for JEP-356 Enhanced Pseudo-Random Number Generators. Thank you. -- Jim CSR: https://bugs.openjdk.java.net/browse/JDK-8255395 JBS: https://bugs.openjdk.java.net/browse/JDK-8248862

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]

On Wed, 4 Nov 2020 19:40:33 GMT, Jan Lahoda wrote: >> I have read all the files. >> >> I have added a n umber of various minor non-blocking comments (no need for >> re-review( to fix these. But I have a couple of comments/questions before >> finally giving approval. >> There's a comment in

Re: RFR: 8255214 : Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager

On Wed, 4 Nov 2020 21:52:56 GMT, Rahul Yadav wrote: > Hello, > > Request to review this small change, as HTML4 support has been dropped from > javadoc. > Have replaced valign="top" with style="vertical-align:top". LGTM Rahul. The generated javadoc looks OK too. - Marked as

Re: RFR: 8255150: Add utility methods to check long indexes and ranges

On Mon, 2 Nov 2020 10:47:18 GMT, Roland Westrelin wrote: > This change add 3 new methods in Objects: > > public static long checkIndex(long index, long length) > public static long checkFromToIndex(long fromIndex, long toIndex, long length) > public static long checkFromIndexSize(long

Integrated: 8255226: (tz) Upgrade time-zone data to tzdata2020d

On Mon, 2 Nov 2020 16:29:07 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020d to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/62.html > Bug:

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v10]

> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v12]

On Thu, 5 Nov 2020 01:20:08 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for the intrinsic. The API is >> similar to the existing

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v9]

> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v8]

> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Thu, 5 Nov 2020 02:52:05 GMT, Hui Shi wrote: > …AccessorImpl object > > We met real problem when using protobuf with option optimized for code size, > detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 > > Optimize solution is adding a new boolean field to detect concurrent

Integrated: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)

On Thu, 8 Oct 2020 11:49:17 GMT, Jan Lahoda wrote: > This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current