On Sat, 28 Nov 2020 22:05:01 GMT, Сергей Цыпанов
wrote:
>>> @cl4es Could you tell me where I can look for a command to run the
>>> benchmark?
>>
>> See
>> [doc/testing.md](https://github.com/openjdk/jdk/blob/master/doc/testing.md).
>> The
>> [configuration](https://github.com/openjdk/jdk/bl
> JDK-8188055 added the function Reference.refersTo. For performance, the
> supporting native methods Reference.refersTo0 and PhantomReference.refersTo0
> should be intrinsified by C2.
>
> Initial patch was prepared by @fisk.
>
> Tested hs-tier1-4. Added new compiler tests to test intrinsics.
>
On Sat, 28 Nov 2020 21:45:25 GMT, Claes Redestad wrote:
>> Looks good to me.
>>
>> Theoretically the refactored `getBytes(byte[], int, byte)` should have no
>> cost, but could cause some issues in some microbenchmarks that touches this.
>> You mentioned this was used by StringConcatHelper, so
On Sat, 28 Nov 2020 14:10:10 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8254082: Consolidate putStringAt() methods: make length represent char
>> count
>
> Looks good to me.
>
> Theore
Hi Dawid,
Thank you for the follow up.
> On Nov 28, 2020, at 9:34 AM, Dawid Weiss wrote:
>
>
> I know what the problem is and I know what the fix should be (and tried to
> convey it) but I don't have a patch.
Given you believe you know what the fix would be, it would be great to create
a p
On Sat, 28 Nov 2020 14:10:10 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8254082: Consolidate putStringAt() methods: make length represent char
>> count
>
> Looks good to me.
>
> Theore
On Fri, 27 Nov 2020 21:04:59 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> com
I know what the problem is and I know what the fix should be (and tried to
convey it) but I don't have a patch. Writing the test case is not a problem
but it'll be a lengthy test on slower drives (has to create a zip file that
exceeds 4gb of disk space). I don't think there is a way to fake the fil
On Sat, 28 Nov 2020 14:00:10 GMT, Сергей Цыпанов
wrote:
>> Original mail:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/069197.html
>>
>> Hello,
>>
>> while working with `StringBuilder.insert()` I've spotted that its delegate
>> `AbstractStringBuilder.insert()` is m
> Original mail:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/069197.html
>
> Hello,
>
> while working with `StringBuilder.insert()` I've spotted that its delegate
> `AbstractStringBuilder.insert()` is missing
> a fast-path for the most frequent case when its argument
On Thu, 26 Nov 2020 19:08:54 GMT, Richard Fussenegger
wrote:
>> src/java.base/share/classes/java/util/UUID.java line 168:
>>
>>> 166: /**
>>> 167: * Constructs a new {@code UUID} using the specified data. {@code
>>> 168: * mostSigBits} is used for the most significant 64 bits of
> Made byte constructor public and changed the length assertion to an
> `IllegalArgumentException`, added a `getBytes` method that allows users to
> retrieve the raw bytes of the UUID, and created a new private constructor
> with an optimized construction for byte arrays that can set the version
On Wed, 25 Nov 2020 23:35:14 GMT, Vladimir Kozlov wrote:
>> JDK-8188055 added the function Reference.refersTo. For performance, the
>> supporting native methods Reference.refersTo0 and PhantomReference.refersTo0
>> should be intrinsified by C2.
>>
>> Initial patch was prepared by @fisk.
>>
>>
On Sat, 28 Nov 2020 09:43:15 GMT, Aleksey Shipilev wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Wed, 25 Nov 2020 23:35:14 GMT, Vladimir Kozlov wrote:
>> JDK-8188055 added the function Reference.refersTo. For performance, the
>> supporting native methods Reference.refersTo0 and PhantomReference.refersTo0
>> should be intrinsified by C2.
>>
>> Initial patch was prepared by @fisk.
>>
>>
On Wed, 25 Nov 2020 16:39:20 GMT, Pavel Rappo wrote:
>> @pavelrappo Please see my proposed CSR below. Thank you.
>>
>> # Map::compute should have a clearer implementation requirement.
>>
>> ## Summary
>>
>> java.util.Map::compute should have a clearer implementation requirement in
>> its docu
> This is from the mailing list:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html
>
> -
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
>
> ### Testing
On Wed, 25 Nov 2020 20:22:21 GMT, Daniel Fuchs wrote:
>> @pavelrappo
>>
>>> What is the required level of fidelity particular (pseudo-) code has to
>>> have?
>>
>> It's potentially a large discussion, one that could be had in the context of
>> my JEP draft http://openjdk.java.net/jeps/806856
18 matches
Mail list logo
