On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote:
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
> "jdk.xml.isStandalone".
>
> This
On Fri, 29 Jan 2021 23:06:20 GMT, Alexey Semenyuk wrote:
>> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>>
>> The fix splits Linux app launcher in app launcher and launcher shared lib.
>> App launcher is pure C and doesn't have C++ code. App launcher lib
>> incorporates bulk of
> Updates to the specifications of Double.{equals, compareTo} to explain more
> explicitly why the obvious wrappers around "==" and "<"/"==" are not
> sufficient for floating-point values.
>
> Once the wording is worked out, I'll replicate it for the analogous methods
> on Float.
Joe Darcy
On Tue, 8 Dec 2020 17:10:33 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Editing pass on changes in Double; add accommodations in Float.
>
> src/java.base/share/classes/java/lang/Double.java
> On Jan 26, 2021, at 7:16 PM, Michael Hall wrote:
>
>>
>>
>> When I open the built dmg there is an application icon, a drag to indicating
>> arrow, but no application folder icon as the drag target.
>>
>> Possibly related…
>>
>> Running [osascript,
>>
> Updates to the specifications of Double.{equals, compareTo} to explain more
> explicitly why the obvious wrappers around "==" and "<"/"==" are not
> sufficient for floating-point values.
>
> Once the wording is worked out, I'll replicate it for the analogous methods
> on Float.
Joe Darcy
On Fri, 29 Jan 2021 22:47:52 GMT, Weijun Wang wrote:
>> This fix covers both
>>
>> - [[macOS]: Remove JNF dependency from
>> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
>> - [[macOS]: Remove JNF dependency from
>>
On Fri, 29 Jan 2021 18:43:40 GMT, Lance Andersen wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor to do most entry validation in one place, out of line from
>> initCEN.
>
>
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate hash, check encoding etc into the
> addEntry method to
On Thu, 28 Jan 2021 13:45:15 GMT, Zhengyu Gu wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment
>
> Sorry, I overlooked some of details. Final change looks fine to me.
@zhengyu123 Thank you for
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>
> The fix splits Linux app launcher in app launcher and launcher shared lib.
> App launcher is pure C and doesn't have C++ code. App launcher lib
> incorporates bulk of C++ code from app launcher.
> At startup app launcher loads
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860)
Weijun Wang has
On Fri, 29 Jan 2021 22:05:21 GMT, Phil Race wrote:
>> So I should remember how env was retrieved and only detach when it's from
>> `AttachCurrentThreadAsDaemon`? In fact, in my test the plain `GetEnv` has
>> never succeeded and it was always attached.
>
> Yes that is the idea. BTW which thread
On Fri, 29 Jan 2021 22:00:32 GMT, Phil Race wrote:
>> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>>
>> The fix splits Linux app launcher in app launcher and launcher shared lib.
>> App launcher is pure C and doesn't have C++ code. App launcher lib
>> incorporates bulk of C++
On Fri, 29 Jan 2021 21:47:32 GMT, Weijun Wang wrote:
>> src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m line 619:
>>
>>> 617: (*env)->ReleaseCharArrayElements(env, passwordObj,
>>> passwordChars,
>>> 618: JNI_ABORT);
>>> 619: }
>>
>> Although you
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote:
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>
> The fix splits Linux app launcher in app launcher and launcher shared lib.
> App launcher is pure C and doesn't have C++ code. App launcher lib
> incorporates bulk of C++
On Fri, 29 Jan 2021 20:51:04 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> same behavior as before -- empty realm map
>
> make/modules/java.security.jgss/Lib.gmk line 84:
>
>> 82:
On Fri, 29 Jan 2021 00:54:46 GMT, Claes Redestad wrote:
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate
On Fri, 29 Jan 2021 14:57:56 GMT, Weijun Wang wrote:
>> This fix covers both
>>
>> - [[macOS]: Remove JNF dependency from
>> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
>> - [[macOS]: Remove JNF dependency from
>>
On Fri, 29 Jan 2021 18:40:55 GMT, Lance Andersen wrote:
>> src/java.xml/share/classes/module-info.java line 78:
>>
>>> 76: * System Properties
>>> 77: * A property may have a corresponding System Property that has the
>>> same name
>>> 78: * except the prefix as shown above. A System
On Fri, 29 Jan 2021 17:57:14 GMT, Daniel Fuchs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated the patch based on review comments. Refer to the previous reviews.
>
> src/java.xml/share/classes/module-info.java
On Fri, 29 Jan 2021 18:24:59 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
On Fri, 29 Jan 2021 17:31:09 GMT, Joe Darcy wrote:
>> Updates to the specifications of Double.{equals, compareTo} to explain more
>> explicitly why the obvious wrappers around "==" and "<"/"==" are not
>> sufficient for floating-point values.
>>
>> Once the wording is worked out, I'll
On Fri, 29 Jan 2021 17:52:33 GMT, Daniel Fuchs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated the patch based on review comments. Refer to the previous reviews.
>
> src/java.xml/share/classes/module-info.java
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
> "jdk.xml.isStandalone".
>
> This change addresses an incompatibility introduced
On Fri, 29 Jan 2021 00:07:59 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
On Fri, 29 Jan 2021 00:07:59 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
On Fri, 29 Jan 2021 00:07:59 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
> Updates to the specifications of Double.{equals, compareTo} to explain more
> explicitly why the obvious wrappers around "==" and "<"/"==" are not
> sufficient for floating-point values.
>
> Once the wording is worked out, I'll replicate it for the analogous methods
> on Float.
Joe Darcy
On Fri, 29 Jan 2021 00:07:59 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860)
Weijun Wang has
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote:
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
>
This fix covers both
- [[macOS]: Remove JNF dependency from
libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
- [[macOS]: Remove JNF dependency from
libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860)
-
Commit
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote:
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
>
On Thu, 28 Jan 2021 14:33:35 GMT, Aleksey Shipilev wrote:
> If you run x86 configuration (cross-compiled on x86_64), then many tests
> would fail with:
>
> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
> ...
> can not load libgnomevfs-2.so
> Exception in thread
On Fri, 29 Jan 2021 07:31:55 GMT, Aleksey Shipilev wrote:
>> If you run x86 configuration (cross-compiled on x86_64), then many tests
>> would fail with:
>>
>> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
>> ...
>> can not load libgnomevfs-2.so
>> Exception in
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Reset the formatting.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new:
On Fri, 29 Jan 2021 00:54:46 GMT, Claes Redestad wrote:
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate
- Merge checkEncoding into the byte[]-based normalizedHash. The latter is only
used from ZipFile.initCEN right after the checkEncoding today, so verifying
this is equivalent is straightforward.
- Factor out the logic to calculate hash, check encoding etc into the addEntry
method to allow JITs
39 matches
Mail list logo
