On Sat, 13 Mar 2021 15:19:18 GMT, Claes Redestad wrote:
>> This is a very simple and trivial improvement about getting rid of pointless
>> char wrapping into array
>
> LGTM
I'll sponsor when I'm back to work on Monday, assuming there are no objections.
-
PR:
On Fri, 12 Mar 2021 16:57:38 GMT, Johannes Kuhn wrote:
>> Remove unused methods.
>
> LGTM
Thanks for reviewing, @DasBrain and @mlchung.
-
PR: https://git.openjdk.java.net/jdk/pull/2969
On Fri, 12 Mar 2021 13:27:39 GMT, Claes Redestad wrote:
> Remove unused methods.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2969
On Sat, 13 Mar 2021 15:18:59 GMT, Claes Redestad wrote:
>> This is a very simple and trivial improvement about getting rid of pointless
>> char wrapping into array
>
> src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
>
>> 831: String fname = in.readUTF();
>>
On Sat, 20 Feb 2021 12:17:32 GMT, Сергей Цыпанов
wrote:
> This is a very simple and trivial improvement about getting rid of pointless
> char wrapping into array
LGTM
src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
> 831: String fname = in.readUTF();
> 832:
On Sat, 13 Mar 2021 14:20:20 GMT, Daniel D. Daugherty
wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> I downloaded the patch and
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
>
JDK-8263154: [macos] DMG builds have finder errors
-
Commit messages:
- JDK-8263154: [macos] DMG builds have finder errors
Changes: https://git.openjdk.java.net/jdk/pull/2987/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2987=00
Issue:
On Tue, 16 Feb 2021 23:49:36 GMT, Brian Burkhalter wrote:
> I think the implementation changes here look good. I don't know however
> whether there is enough coverage in the tests. These should verify that the
> `Reader`, `CharArrayReader`, and `InputStreamReader` implementations of
>
On Fri, 19 Feb 2021 07:34:57 GMT, Alan Bateman wrote:
>> I think that's what @AlanBateman intended. The `skip()` changes would revert
>> also (I think) but the C-style array changes can stay. Thanks.
>
> Yes, let's bring it back to just eliminating the intermediate array when the
> buffer has
On Tue, 16 Feb 2021 23:52:09 GMT, Brian Burkhalter wrote:
>> Philippe Marschall has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Replace c-style array declarations
>> - Share work buffer between #skip and #read
>
>
On Tue, 16 Feb 2021 23:50:30 GMT, Brian Burkhalter wrote:
>> Philippe Marschall has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Replace c-style array declarations
>> - Share work buffer between #skip and #read
>
>
> Implement three optimiztations for Reader.read(CharBuffer)
>
> * Add a code path for heap buffers in Reader#read to use the backing array
> instead of allocating a new one.
> * Change the code path for direct buffers in Reader#read to limit the
> intermediate allocation to
On Sat, 13 Mar 2021 12:16:57 GMT, Yi Yang wrote:
>> @kelthuzadx hi! I'd appreciate this, as there's no JBS issue for this (
>
> Hi @stsypanov, I've created it
> https://bugs.openjdk.java.net/browse/JDK-8263552. Good luck :-)
Thanks!
-
PR:
On Sat, 13 Mar 2021 11:35:48 GMT, Сергей Цыпанов
wrote:
>> Nice cleanup. I can help file a JBS issue if @c-cleary doesn't notice your
>> comment.
>
> @kelthuzadx hi! I'd appreciate this, as there's no JBS issue for this (
Hi @stsypanov, I've created it
On Mon, 22 Feb 2021 12:04:14 GMT, Conor Cleary wrote:
>> This is a very simple and trivial improvement about getting rid of pointless
>> char wrapping into array
>
> src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
>
>> 831: String fname = in.readUTF();
>> 832:
On Sat, 13 Mar 2021 03:12:32 GMT, Yi Yang wrote:
>> src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
>>
>>> 831: String fname = in.readUTF();
>>> 832: String signature = ((tcode == 'L') || (tcode == '[')) ?
>>> 833: in.readTypeString()
On Mon, 22 Feb 2021 12:04:14 GMT, Conor Cleary wrote:
>> This is a very simple and trivial improvement about getting rid of pointless
>> char wrapping into array
>
> src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
>
>> 831: String fname = in.readUTF();
>> 832:
On Sat, 20 Feb 2021 12:17:32 GMT, Сергей Цыпанов
wrote:
> This is a very simple and trivial improvement about getting rid of pointless
> char wrapping into array
src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
> 831: String fname = in.readUTF();
> 832:
On Mon, 1 Mar 2021 12:50:35 GMT, Andrey Turbanov
wrote:
> I think it's worth to cleanup other places with similar code too.
Done
-
PR: https://git.openjdk.java.net/jdk/pull/2660
This is a very simple and trivial improvement about getting rid of pointless
char wrapping into array
-
Commit messages:
- Fix other occurences
- Use String.valueOf() for char-to-String conversion in ObjectStreamClass
Changes: https://git.openjdk.java.net/jdk/pull/2660/files
On Sat, 20 Feb 2021 12:17:32 GMT, Сергей Цыпанов
wrote:
> This is a very simple and trivial improvement about getting rid of pointless
> char wrapping into array
Marked as reviewed by turban...@github.com (no known OpenJDK username).
I think it's worth to cleanup other places with similar
On Sat, 13 Mar 2021 06:44:12 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this dull patch that replaces `ClassFileInstaller`
>> w/ `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions
>> to ensure we won't get split testlibrary, and removes
>>
> Implement three optimiztations for Reader.read(CharBuffer)
>
> * Add a code path for heap buffers in Reader#read to use the backing array
> instead of allocating a new one.
> * Change the code path for direct buffers in Reader#read to limit the
> intermediate allocation to
Hi!
The javadoc of java.io.Serial [1] says that serialVersionUID is private.
But the javadoc of Serializable [2] says it can have any access modifier.
Who is right here? When I write the following code, should there be a
warning or not?
import java.io.Serial;import java.io.Serializable;
public
On Sat, 13 Mar 2021 00:51:19 GMT, Alexey Semenyuk wrote:
>> 8263536: Add missing @compile tags to jpackage tests
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains one commit:
>
> 8263536: Add missing @compile
26 matches
Mail list logo
