Re: RFR: 8173970: jar tool should have a way to extract to a directory

2021-03-27 Thread Lance Andersen
On Mar 27, 2021, at 12:05 PM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: On Fri, 26 Feb 2021 17:03:11 GMT, Jaikiran Pai mailto:j...@openjdk.org>> wrote: Can I please get a review for this patch which proposes to implement the enhancement request noted in

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-27 Thread Alan Bateman
On Fri, 26 Mar 2021 02:14:54 GMT, Lin Zang wrote: >> Hi Lin, >> >> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote: >> >> >> >> Hi Lance, >> Thanks a lot for your review. I will update the PR ASAP. >> May I ask your help to also review the CSR? >> >> I believe we need

Re: RFR: 8173970: jar tool should have a way to extract to a directory

2021-03-27 Thread Alan Bateman
On Fri, 26 Feb 2021 17:03:11 GMT, Jaikiran Pai wrote: > Can I please get a review for this patch which proposes to implement the > enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970? > > The commit in this PR introduces the `-o` and `--output-dir` option to the >

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

2021-03-27 Thread Alan Bateman
On Sat, 27 Mar 2021 15:19:37 GMT, Attila Szegedi wrote: > I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods > had a lot of code duplication among themselves, and even within each method. > I refactored them into a modern unified implementation. While there I also >

RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

2021-03-27 Thread Attila Szegedi
I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods had a lot of code duplication among themselves, and even within each method. I refactored them into a modern unified implementation. While there I also took the opportunity to introduce `Objects.requireNonNull` in place

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

2021-03-27 Thread Attila Szegedi
On Sat, 27 Mar 2021 15:19:37 GMT, Attila Szegedi wrote: > I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods > had a lot of code duplication among themselves, and even within each method. > I refactored them into a modern unified implementation. While there I also >

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-27 Thread Andrew Haley
On Sat, 27 Mar 2021 09:53:37 GMT, Andrew Haley wrote: >> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. >> Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic >> idea can be found at >>

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-27 Thread Andrew Haley
On Sat, 27 Mar 2021 08:58:03 GMT, Dong Bo wrote: > In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. > Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea > can be found at > http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. > >

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-27 Thread Andrew Haley
On Sat, 27 Mar 2021 08:58:03 GMT, Dong Bo wrote: > In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. > Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea > can be found at > http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. > >

RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-27 Thread Dong Bo
In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea can be found at http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. Patch passed jtreg tier1-3 tests with