Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-05-23 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > Hi Lin, > > On Mar 24, 2021, at 2:51 AM,

Re: RFR: 8266054: VectorAPI rotate operation optimization [v7]

2021-05-23 Thread Jatin Bhateja
> Current VectorAPI Java side implementation expresses rotateLeft and > rotateRight operation using following operations:- > > vec1 = lanewise(VectorOperators.LSHL, n) > vec2 = lanewise(VectorOperators.LSHR, n) > res = lanewise(VectorOperations.OR, vec1 , vec2) > > This patch moves

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v7]

2021-05-23 Thread Tagir F . Valeev
> With the introduction of `toList()`, preserving the SIZED characteristics in > more cases becomes more important. This patch preserves SIZED on `skip()` and > `limit()` operations, so now every combination of > `map/mapToX/boxed/asXyzStream/skip/limit/sorted` preserves size, and >

RFR: 8267587: Update java.util to use enhanced switch

2021-05-23 Thread Tagir F . Valeev
Inspired by PR#4088. Most of the changes are done automatically using IntelliJ IDEA refactoring. Some manual adjustments are also performed, including indentations, moving comments, extracting common cast out of switch expression branches, etc. I also noticed that there are some switches

Re: RFR: 8267587: Update java.util to use enhanced switch

2021-05-23 Thread Tagir F . Valeev
On Mon, 24 May 2021 04:20:23 GMT, Tagir F. Valeev wrote: > Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch >

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v3]

2021-05-23 Thread Roger Riggs
On Mon, 24 May 2021 00:33:06 GMT, Roger Riggs wrote: >> Methods are added to java.lang.Process to read and write characters and >> lines from and to a spawned Process. >> The Charset used to encode and decode characters to bytes can be specified >> or use the >> operating system native

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v3]

2021-05-23 Thread Roger Riggs
> Methods are added to java.lang.Process to read and write characters and lines > from and to a spawned Process. > The Charset used to encode and decode characters to bytes can be specified or > use the > operating system native encoding as is available from the "native.encoding" > system

Re: RFR: 8224243: Make AccessibleObject a sealed class [v2]

2021-05-23 Thread Kasper Nielsen
On Fri, 21 May 2021 at 03:44, Joe Darcy wrote: > > Conceptually, AccessbileObject is a sealed class with a protected > constructor stating > > > > Constructor: only used by the Java Virtual Machine. > > > > With the language now supporting sealed classes, the AccessbileObject > should be

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v3]

2021-05-23 Thread Sean Mullan
On Fri, 21 May 2021 15:27:39 GMT, Daniel Fuchs wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixing awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java > >

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v2]

2021-05-23 Thread Alan Bateman
On Sat, 22 May 2021 01:24:24 GMT, Roger Riggs wrote: >> Methods are added to java.lang.Process to read and write characters and >> lines from and to a spawned Process. >> The Charset used to encode and decode characters to bytes can be specified >> or use the >> operating system native

RE: New java.util.Strings class

2021-05-23 Thread Alberto Otero Rodríguez
Hi Tagir, several things I want to talk about: 1) In Guava already existed an Objects class before Java created its own Objects class. So, I don't see any problem in creating now a Strings class. 2) The idea of creating the class in Java is to use a better or more performant implementation.

Re: New java.util.Strings class

2021-05-23 Thread Tagir Valeev
Hello! > 1) I based my code in the current java.util.Objects class of Java 16. I don't > know why the Objects class was a good idea, but the Strings class is not. Because Objects class is applicable to any objects (including strings) while Strings is applicable to strings only which greatly

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v6]

2021-05-23 Thread Tagir F . Valeev
On Sun, 23 May 2021 11:24:12 GMT, Tagir F. Valeev wrote: >> With the introduction of `toList()`, preserving the SIZED characteristics in >> more cases becomes more important. This patch preserves SIZED on `skip()` >> and `limit()` operations, so now every combination of >>

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v3]

2021-05-23 Thread Tagir F . Valeev
On Mon, 17 May 2021 22:08:01 GMT, Paul Sandoz wrote: >> I see your concern. I made some additional benchmarks and added them here. >> First, CountSized, which just gets the stream size without actual traversal. >> We can see how the performance changes depending on number of stream >>

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v6]

2021-05-23 Thread Tagir F . Valeev
> With the introduction of `toList()`, preserving the SIZED characteristics in > more cases becomes more important. This patch preserves SIZED on `skip()` and > `limit()` operations, so now every combination of > `map/mapToX/boxed/asXyzStream/skip/limit/sorted` preserves size, and >