> 8267630: Start of release updates for JDK 18
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 22 commits:
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
-
On Wed, 9 Jun 2021 13:56:40 GMT, Rafael Winterhalter
wrote:
>> During annotation parsing, the parser assumes that a declared property is of
>> an array type if the parsed annotation property is defined as an array. In
>> this case, the component type is `null`, and a `NullPointerException` is
On Wed, 9 Jun 2021 19:00:39 GMT, Leonid Mesnik wrote:
>> EFH is improved to process cores and get mixed stack traces with jhsdb and
>> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
>> contain info about all threads, sometimes it is even not generated.
>
> Leonid
> 8267630: Start of release updates for JDK 18
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 21 commits:
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
-
On Wed, 9 Jun 2021 13:56:40 GMT, Rafael Winterhalter
wrote:
>> During annotation parsing, the parser assumes that a declared property is of
>> an array type if the parsed annotation property is defined as an array. In
>> this case, the component type is `null`, and a `NullPointerException` is
On Wed, 9 Jun 2021 13:46:28 GMT, Rafael Winterhalter
wrote:
>> If a type is changed from a type that can be a member of an annotation which
>> is used in an array, changing it to a type that cannot be an array member
>> will be treated as if the type is an annotation type. As a result, no
>>
On Mon, 7 Jun 2021 23:58:44 GMT, Dan Smith wrote:
> Small bug fix.
This pull request has now been integrated.
Changeset: 58ba48b7
Author:Dan Smith
URL:
https://git.openjdk.java.net/jdk/commit/58ba48b7b88eff359683aa3271c48b18f1973282
Stats: 27 lines in 3 files changed: 7 ins; 12
On Tue, 8 Jun 2021 15:30:33 GMT, Dan Smith wrote:
>> Small bug fix.
>
> Dan Smith has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clean up validation of implKind REF_invokeSpecial
Looks good to me.
-
Marked as reviewed by
On Tue, 8 Jun 2021 15:30:33 GMT, Dan Smith wrote:
>> Small bug fix.
>
> Dan Smith has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clean up validation of implKind REF_invokeSpecial
Marked as reviewed by psandoz (Reviewer).
-
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
My biggest comment is the spaces used to align, which I strongly
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
Leonid Mesnik has updated the pull request incrementally with one
On Wed, 2 Jun 2021 01:00:53 GMT, Leonid Mesnik wrote:
>> EFH is improved to process cores and get mixed stack traces with jhsdb and
>> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
>> contain info about all threads, sometimes it is even not generated.
>
> Leonid
On Wed, 9 Jun 2021 08:42:13 GMT, Igor Ignatyev wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spaces updated.
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/GathererFactory.java
> line 32:
>
On Tue, 11 May 2021 10:51:18 GMT, Jorn Vernee wrote:
> This patch adds a `--validate` option to the jar tool which can be used to
> validate a jar file that might be malformed. For instance, if a jar is a
> multi-release jar, it is malformed if different versions expose different
> APIs.
>
>
On Tue, 8 Jun 2021 16:46:36 GMT, Vicente Romero wrote:
> Please review this PR which is just syncing the implementation of
> DirectMethodHandleDesc.Kind.valueOf(int) with its spec. My reading of the
> method's spec is that if the value of the `refKind` parameter is:
>
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/time/Month.java line 491:
> 489:
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Looks good overall. Some misplaced comments. Also, copyright years
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Updates look good Patrick
-
Marked as reviewed by
Hi,
Could someone please review my code for updating the code in the `java.time`
packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268469: Update java.time to use switch expressions
Changes:
On Wed, 9 Jun 2021 00:42:35 GMT, ScientificWare
wrote:
>> This concerns [dtdbuilder
>> tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder).
>>
>> In jshell, try `System.getProperty("html32") + ""` you'll get a `String`.
>>
>> So, in
> During annotation parsing, the parser assumes that a declared property is of
> an array type if the parsed annotation property is defined as an array. In
> this case, the component type is `null`, and a `NullPointerException` is
> thrown. This change discovers the mismatch and throws an
>
On Tue, 8 Jun 2021 17:34:58 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> ~This is part 2 of a two part upstreaming process of the patch mentioned in
>> the subject line. The patch was split into 2 in order to document 2 separate
>> specification changes that arose from a change in the implementation,
> If a type is changed from a type that can be a member of an annotation which
> is used in an array, changing it to a type that cannot be an array member
> will be treated as if the type is an annotation type. As a result, no
> exception proxy is created and the type is returned as if it was
> During annotation parsing, the parser assumes that a declared property is of
> an array type if the parsed annotation property is defined as an array. In
> this case, the component type is `null`, and a `NullPointerException` is
> thrown. This change discovers the mismatch and throws an
>
On Wed, 9 Jun 2021 13:37:02 GMT, Jorn Vernee wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line
>> 241:
>>
>>> 239: \ --validate Validate a jar. This process will
>>> validate that the API\n\
>>> 240: \ exported by
On Wed, 9 Jun 2021 13:02:50 GMT, Alan Bateman wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve help message.
>
> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 241:
>
>> 239: \
> This patch adds a `--validate` option to the jar tool which can be used to
> validate a jar file that might be malformed. For instance, if a jar is a
> multi-release jar, it is malformed if different versions expose different
> APIs.
>
> The implementation is straight forward since there
On Wed, 5 May 2021 21:36:45 GMT, Rafael Winterhalter
wrote:
> This improves the messages that are provided by
> `AnnotationTypeMismatchException`s. The message provided by
> AnnotationTypeMismatchExceptions is deliberately undefined such that this
> should not break any contract.
This pull
On Tue, 8 Jun 2021 18:32:36 GMT, Jorn Vernee wrote:
>> This patch adds a `--validate` option to the jar tool which can be used to
>> validate a jar file that might be malformed. For instance, if a jar is a
>> multi-release jar, it is malformed if different versions expose different
>> APIs.
On Wed, 9 Jun 2021 10:02:35 GMT, Rafael Winterhalter
wrote:
>> This improves the messages that are provided by
>> `AnnotationTypeMismatchException`s. The message provided by
>> AnnotationTypeMismatchExceptions is deliberately undefined such that this
>> should not break any contract.
>
>
On Tue, 8 Jun 2021 18:32:36 GMT, Jorn Vernee wrote:
>> This patch adds a `--validate` option to the jar tool which can be used to
>> validate a jar file that might be malformed. For instance, if a jar is a
>> multi-release jar, it is malformed if different versions expose different
>> APIs.
On Wed, 12 May 2021 13:58:44 GMT, Roger Riggs wrote:
> JEP 415: Context-specific Deserialization Filters extends the deserialization
> filtering mechanisms with more flexible and customizable protections against
> malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415.
>
On Tue, 8 Jun 2021 16:46:36 GMT, Vicente Romero wrote:
> Please review this PR which is just syncing the implementation of
> DirectMethodHandleDesc.Kind.valueOf(int) with its spec. My reading of the
> method's spec is that if the value of the `refKind` parameter is:
>
> This tests fails intermittently but very rarely, on Windows it seems. The
> subtest in question is `testLockSharedMultiThread`. This test is spawning a
> number of threads, each of which:
>
> * increments a counter atomically
> * acquire scope
> * waits some time
> * release scope
> *
On Wed, 9 Jun 2021 11:31:52 GMT, Maurizio Cimadamore
wrote:
>> This tests fails intermittently but very rarely, on Windows it seems. The
>> subtest in question is `testLockSharedMultiThread`. This test is spawning a
>> number of threads, each of which:
>>
>> * increments a counter atomically
On Sun, 9 May 2021 21:59:29 GMT, Rafael Winterhalter
wrote:
> During annotation parsing, the parser assumes that a declared property is of
> an array type if the parsed annotation property is defined as an array. In
> this case, the component type is `null`, and a `NullPointerException` is
>
On Wed, 9 Jun 2021 10:33:34 GMT, Maurizio Cimadamore
wrote:
> This tests fails intermittently but very rarely, on Windows it seems. The
> subtest in question is `testLockSharedMultiThread`. This test is spawning a
> number of threads, each of which:
>
> * increments a counter atomically
> *
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
On Fri, 7 May 2021 18:58:02 GMT, Rafael Winterhalter
wrote:
> If a type is changed from a type that can be a member of an annotation which
> is used in an array, changing it to a type that cannot be an array member
> will be treated as if the type is an annotation type. As a result, no
>
> If a type is changed from a type that can be a member of an annotation which
> is used in an array, changing it to a type that cannot be an array member
> will be treated as if the type is an annotation type. As a result, no
> exception proxy is created and the type is returned as if it was
This tests fails intermittently but very rarely, on Windows it seems. The
subtest in question is `testLockSharedMultiThread`. This test is spawning a
number of threads, each of which:
* increments a counter atomically
* acquire scope
* waits some time
* release scope
* decrement counter (in
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
On Thu, 3 Jun 2021 17:04:58 GMT, Mandy Chung wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268124: small refactoring; fixed misplaced comment and added missing
>> lambda operator
>
>
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with two
additional commits since the last revision:
- 8268124:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Wed, 2 Jun 2021 16:10:19 GMT, Rémi Forax wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Sat, 8 May 2021 09:51:46 GMT, Rafael Winterhalter
wrote:
>> This improves the messages that are provided by
>> `AnnotationTypeMismatchException`s. The message provided by
>> AnnotationTypeMismatchExceptions is deliberately undefined such that this
>> should not break any contract.
>
>
> This improves the messages that are provided by
> `AnnotationTypeMismatchException`s. The message provided by
> AnnotationTypeMismatchExceptions is deliberately undefined such that this
> should not break any contract.
Rafael Winterhalter has refreshed the contents of this pull request, and
On Sat, 8 May 2021 09:51:46 GMT, Rafael Winterhalter
wrote:
>> This improves the messages that are provided by
>> `AnnotationTypeMismatchException`s. The message provided by
>> AnnotationTypeMismatchExceptions is deliberately undefined such that this
>> should not break any contract.
>
>
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
>
On Sat, 8 May 2021 09:51:46 GMT, Rafael Winterhalter
wrote:
>> This improves the messages that are provided by
>> `AnnotationTypeMismatchException`s. The message provided by
>> AnnotationTypeMismatchExceptions is deliberately undefined such that this
>> should not break any contract.
>
>
On Wed, 2 Jun 2021 01:00:53 GMT, Leonid Mesnik wrote:
>> EFH is improved to process cores and get mixed stack traces with jhsdb and
>> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
>> contain info about all threads, sometimes it is even not generated.
>
> Leonid
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
>
On Mon, 7 Jun 2021 11:00:00 GMT, Athijegannathan Sundararajan
wrote:
> jlink should clean up output directory on any failure. should not leave
> partially filled output.
This pull request has now been integrated.
Changeset: 4d1cf51b
Author:Athijegannathan Sundararajan
URL:
On Tue, 8 Jun 2021 14:29:38 GMT, Athijegannathan Sundararajan
wrote:
>> jlink should clean up output directory on any failure. should not leave
>> partially filled output.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with
> one additional commit since the last
58 matches
Mail list logo
