RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

2021-06-27 Thread Jaikiran Pai
Can I please get a review for this proposed fix for the issue reported in https://bugs.openjdk.java.net/browse/JDK-8190753? The commit here checks for the size of the zip entry before trying to create a `ByteArrayOutputStream` for that entry's content. A new jtreg test has been included in this

Withdrawn: 8269383: (bf) ByteOrder should expose methods to test if platform is big or little endian

2021-06-27 Thread Yi Yang
On Fri, 25 Jun 2021 13:30:56 GMT, Yi Yang wrote: > Hi, can I have a review of this change that adds two new utility methods for > java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of > ByteOrder.nativeOrder() is to check if the underlying platform is > little-endian/big-en

Re: RFR: 8269383: (bf) ByteOrder should expose methods to test if platform is big or little endian

2021-06-27 Thread Yi Yang
On Fri, 25 Jun 2021 13:30:56 GMT, Yi Yang wrote: > Hi, can I have a review of this change that adds two new utility methods for > java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of > ByteOrder.nativeOrder() is to check if the underlying platform is > little-endian/big-en

Re: RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-27 Thread Yi Yang
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote: > Prefer using ByteOrder to compute byte order for StringUTF16 to determining > byte order by native method StringUTF16.isBigEndian. Hi Aleksey, do you have a concrete issue/discussion about bootstrapping problems? I don't see it because I can b

Integrated: Merge jdk17

2021-06-27 Thread Jesper Wilhelmsson
On Sun, 27 Jun 2021 23:05:10 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: a29953d8 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/a29953d805ac6360bcfe005bcefa60e112788494 Stats: 1925

RFR: Merge jdk17

2021-06-27 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash - 8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component clas

RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside

2021-06-27 Thread Jaikiran Pai
Can I please get a review of this proposed fix for https://bugs.openjdk.java.net/browse/JDK-8251329? As noted in that issue, if a zip filesystem created on top of a jar containing a "./" entry is "walked" using the `Files.walkFileTree`, it leads to a infinite never ending iteration (which ultim

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo

2021-06-27 Thread Markus KARG
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG wrote: > This PR-*draft* is **work in progress** and an invitation to discuss a > possible solution for issue > [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not > yet* intended for a final review. > > As proposed in JDK