On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
Looks good, but this returns true also for
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has refreshed the contents of this pull request, and previous commits
have been removed. The
On Wed, 7 Jul 2021 17:08:19 GMT, Mandy Chung wrote:
>>> Does "client changes" means changes involving src/java.desktop and
>>> test/java/awt?
>>
>> src/java.desktop, test/java/awt, and test/javax/imageio
>
>> > src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
>> >
Generated lambda class can not access protected static method of the target
class. The following exception is thrown when executing the attached
reproducible program:
Exception in thread "main" java.lang.IllegalAccessError: class
On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
LGTM.
-
Marked as reviewed by
On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
Testing:
Grepped test sources for
Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
CDS archive, time to update test configuration for this platform. This is a
very small one-line change.
-
Commit messages:
- 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for
On Jul 7, 2021, at 5:50 PM, Joe Darcy
mailto:joe.da...@oracle.com>> wrote:
There is no specific constant in `{Float,Double}Consts` to mask all but the
sign bit, but I had thought it might be good to add one there
The sign bit mask can be bit-wise complemented though :-)
I had it that way
On Thu, 8 Jul 2021 01:05:16 GMT, Brian Burkhalter wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
6506405: Add comments, use new consts for masking
-
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 180 commits:
- Merge
- 8264735: Make dynamic dump repeatable
Reviewed-by: ccheung, iklam
- 8269481: SctpMultiChannel never
On Thu, 8 Jul 2021 00:01:43 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: 270fbcb3
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/270fbcb3f5755baf045fa6dec3fba459d32c32e1
Stats: 1083
On 7/7/2021 5:43 PM, Brian Burkhalter wrote:
On Thu, 8 Jul 2021 00:38:45 GMT, Joe Darcy wrote:
Please consider this change to make the `float` and `double` versions of
`java.lang.Math.abs()` branch-free.
src/java.base/share/classes/java/lang/Math.java line 1530:
1528:
On Wed, 7 Jul 2021 20:29:37 GMT, Brian Burkhalter wrote:
>
>
> With this change there is no measurable effect on performance on macOS, but
> on Linux there is approximately a 10% throughput improvement.
The improvement is with the default options, without turning intrinsics off?
I'm
On Wed, 7 Jul 2021 20:28:37 GMT, Brian Burkhalter wrote:
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
src/java.base/share/classes/java/lang/Math.java line 1530:
> 1528: @IntrinsicCandidate
> 1529: public static float
On Thu, 8 Jul 2021 00:38:45 GMT, Joe Darcy wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> src/java.base/share/classes/java/lang/Math.java line 1530:
>
>> 1528: @IntrinsicCandidate
>> 1529: public static
On Fri, 2 Jul 2021 19:36:01 GMT, Joe Wang wrote:
>> Thanks for the suggestion. I am happy with it as is, but I'll hold off
>> integrating it for now and rethink it later.
>
> Ok, good to know. Have a great weekend!
I am inclined to leave the wording alone barring serious objections to the
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for
unexpected output
- 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are
different
- 8269879: [PPC64] C2: Math.rint intrinsic uses
On Wed, 7 Jul 2021 20:28:37 GMT, Brian Burkhalter wrote:
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
On Jul 7, 2021, at 3:44 PM, Rémi Forax ***@***.**@***.***>> wrote:
Your patch change the semantics, actually
On Wed, 7 Jul 2021 22:22:45 GMT, Joe Darcy wrote:
>
> > Your patch change the semantics, actually
> > `Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE`
> > with your patch
> > `Math.abs(Integer.MIN_VALUE) == Integer.MAX_VALUE`
>
> Does it? The overriding of int arguments shouldn't be
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
> string and then it looks for "/lib/". But this is wrong order as
On Wed, 7 Jul 2021 20:28:37 GMT, Brian Burkhalter wrote:
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
>
> Good catch. Well that’s not good. If it needs to catch a special case it’s
> probably not worth doing. given the small
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
> with unexpected output from the VM.
> It appears that destroying the process causes a vm thread to fail to be
> started.
> Extend the delay between starting the
On Wed, 7 Jul 2021 20:28:37 GMT, Brian Burkhalter wrote:
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Good catch. Well that’s not good. If it needs to catch a special case it’s
probably not worth doing. given the small
On Wed, 7 Jul 2021 20:28:37 GMT, Brian Burkhalter wrote:
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Your patch change the semantics, actually
`Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE`
with your patch
Please consider this change to make the `float` and `double` versions of
`java.lang.Math.abs()` branch-free.
-
Commit messages:
- 6506405: Math.abs(float) is slow
Changes: https://git.openjdk.java.net/jdk/pull/4711/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4711=00
On Wed, 7 Jul 2021 20:28:37 GMT, Brian Burkhalter wrote:
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
With this change there is no measurable effect on performance on macOS, but on
Linux there is approximately a 10%
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
> with unexpected output from the VM.
> It appears that destroying the process causes a vm thread to fail to be
> started.
> Extend the delay between starting the
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
> with unexpected output from the VM.
> It appears that destroying the process causes a vm thread to fail to be
> started.
> Extend the delay between starting the
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
> with unexpected output from the VM.
> It appears that destroying the process causes a vm thread to fail to be
> started.
> Extend the delay between starting the
The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
with unexpected output from the VM.
It appears that destroying the process causes a vm thread to fail to be started.
Extend the delay between starting the child and destroying it.
Add diagnostics to be specific about
On Wed, 7 Jul 2021 18:54:23 GMT, Alexey Semenyuk wrote:
>> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
>> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
>> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
>>
On Sat, 3 Jul 2021 07:41:40 GMT, Alan Bateman wrote:
>> Is it possible to add a test for this that is completely independent of
>> jpackage? I think there are a few existing tests that copy the run-time
>> image to a new location for testing purposes.
>>
>> We may need to rename the JBS
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
> string and then it looks for "/lib/". But this is wrong order as
On Wed, 7 Jul 2021 16:22:25 GMT, Mandy Chung wrote:
>> Hi Mandy, thanks for reviewing this.
>>
>>> I suggest to separate the client changes (both src and test) in a separate
>>> PR for the client review.
>>
>> Does "client changes" means changes involving src/java.desktop and
>>
On Fri, 2 Jul 2021 22:17:09 GMT, Alexey Semenyuk wrote:
> Disable stripping to prevent rpmbuild from modifying executables
This pull request has now been integrated.
Changeset: 6000950b
Author:Alexey Semenyuk
URL:
On Wed, 7 Jul 2021 12:10:16 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
On Wed, 7 Jul 2021 02:10:10 GMT, Yi Yang wrote:
> Does "client changes" means changes involving src/java.desktop and
> test/java/awt?
src/java.desktop, test/java/awt, and test/javax/imageio
-
PR: https://git.openjdk.java.net/jdk/pull/4507
Hi Joe,
Thanks, I appreciate your feedback very much!
There was one more thing I wanted to discuss: there is something that
might be improved in the AnnotationInvocationHandler#validateAnnotationMethods
and I wanted to know if it makes sense to go ahead with the change.
There are `if`
> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
> property.
> Fix description in the example of a filter allowing platform classes.
> Suppress some warnings about use of SecurityManager in tests.
Roger Riggs has updated the pull request incrementally with one
On Wed, 7 Jul 2021 12:10:16 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
> Currently, an enum switch with patterns is desugared in a very non-standard,
> and potentially slow, way. It would be better to use the standard
> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to
> accept enum constants as labels in order to allow this. A
On Fri, 2 Jul 2021 22:17:09 GMT, Alexey Semenyuk wrote:
> Disable stripping to prevent rpmbuild from modifying executables
Marked as reviewed by herrick (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/207
On Wed, 7 Jul 2021 06:08:13 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
On Mon, 5 Jul 2021 11:21:39 GMT, Daniel Fuchs wrote:
> Please find here a trivial fix for:
>
> 8269772: [macos-aarch64] test compilation failed with "SocketException: No
> buffer space available"
>
> Running several of the websocket tests concurrently on some of the CI
> machines is causing
> Currently, an enum switch with patterns is desugared in a very non-standard,
> and potentially slow, way. It would be better to use the standard
> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to
> accept enum constants as labels in order to allow this. A
46 matches
Mail list logo
