Re: RFR: JDK-8256844: Make NMT late-initializable [v2]

2021-08-03 Thread Thomas Stuefe
On Sun, 1 Aug 2021 08:17:08 GMT, Thomas Stuefe wrote: >> Short: this patch makes NMT available in custom-launcher scenarios and >> during gtests. It simplifies NMT initialization. It adds a lot of >> NMT-specific testing, cleans them up and makes them sideeffect-free. >> >> - >> >>

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v5]

2021-08-03 Thread Nick Gasson
On Tue, 3 Aug 2021 13:33:07 GMT, Wang Huang wrote: >> Dear all, >> Can you do me a favor to review this patch. This patch use `ldp` to >> implement String.compareTo. >> >> * We add a JMH test case >> * Here is the result of this test case >> >> Benchmark

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places [v4]

2021-08-03 Thread Brian Burkhalter
On Tue, 3 Aug 2021 22:44:57 GMT, Raffaello Giulietti wrote: >> Hello, >> >> please review the changes in documentation of floorDiv() and floorMod() in >> all their variants. Some are clarifications, some are corrections. >> >> Here's an example of a confusing formulation in the current doc

Integrated: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Weijun Wang
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang wrote: > `oddPart` contains a lot of info on the `modInverse` output, sometimes it's > even the same. Clearing it in case the result is sensitive. > > No new regression test since it's difficult to access a temporary local > variable in an internal

Re: RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Valerie Peng
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang wrote: > `oddPart` contains a lot of info on the `modInverse` output, sometimes it's > even the same. Clearing it in case the result is sensitive. > > No new regression test since it's difficult to access a temporary local > variable in an internal

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places [v4]

2021-08-03 Thread Raffaello Giulietti
> Hello, > > please review the changes in documentation of floorDiv() and floorMod() in > all their variants. Some are clarifications, some are corrections. > > Here's an example of a confusing formulation in the current doc >> "the / operator returns the integer closest to zero" > >

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places [v4]

2021-08-03 Thread Joe Darcy
On Tue, 3 Aug 2021 22:41:52 GMT, Raffaello Giulietti wrote: >> Hello, >> >> please review the changes in documentation of floorDiv() and floorMod() in >> all their variants. Some are clarifications, some are corrections. >> >> Here's an example of a confusing formulation in the current doc

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places [v3]

2021-08-03 Thread Brian Burkhalter
On Tue, 3 Aug 2021 22:37:12 GMT, Raffaello Giulietti wrote: >> Hello, >> >> please review the changes in documentation of floorDiv() and floorMod() in >> all their variants. Some are clarifications, some are corrections. >> >> Here's an example of a confusing formulation in the current doc

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places [v3]

2021-08-03 Thread Raffaello Giulietti
> Hello, > > please review the changes in documentation of floorDiv() and floorMod() in > all their variants. Some are clarifications, some are corrections. > > Here's an example of a confusing formulation in the current doc >> "the / operator returns the integer closest to zero" > >

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places [v2]

2021-08-03 Thread Raffaello Giulietti
> Hello, > > please review the changes in documentation of floorDiv() and floorMod() in > all their variants. Some are clarifications, some are corrections. > > Here's an example of a confusing formulation in the current doc >> "the / operator returns the integer closest to zero" > >

Re: RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Joe Darcy
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang wrote: > `oddPart` contains a lot of info on the `modInverse` output, sometimes it's > even the same. Clearing it in case the result is sensitive. > > No new regression test since it's difficult to access a temporary local > variable in an internal

Re: RFR: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places

2021-08-03 Thread Joe Darcy
On Mon, 2 Aug 2021 22:34:58 GMT, Raffaello Giulietti wrote: > Hello, > > please review the changes in documentation of floorDiv() and floorMod() in > all their variants. Some are clarifications, some are corrections. > > Here's an example of a confusing formulation in the current doc >> "the

Re: RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Brian Burkhalter
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang wrote: > `oddPart` contains a lot of info on the `modInverse` output, sometimes it's > even the same. Clearing it in case the result is sensitive. > > No new regression test since it's difficult to access a temporary local > variable in an internal

RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Weijun Wang
oddPart contains a lot of info on the modInverse output, sometimes it's even the same. Clearing it in case the result is sensitive. No new regression test since it's difficult to access a temporary local variable in an internal class. Existing tier1-2 tests passed. - Commit

Integrated: JDK-8271344: Windows product version issue

2021-08-03 Thread Andy Herrick
On Mon, 2 Aug 2021 13:45:17 GMT, Andy Herrick wrote: > JDK-8271344: Windows product version issue This pull request has now been integrated. Changeset: 0199b03e Author:Andy Herrick URL: https://git.openjdk.java.net/jdk/commit/0199b03eb3bd9ffe79b5193ff1792144b5c488f1 Stats: 21

Re: [External] : Re: jpackage MacOS Notarization

2021-08-03 Thread Andy Herrick
OK - took me a while to see what you are doing. The problem is you are signing the pkg but building it from an unsigned app-image. If you are building in two phases (app-image, then installer package) you need the --mac-sign option on both phases. /Andy On 8/3/2021 10:37 AM, Andy Herrick

Re: RFR: 8271225: Add floorDivExact() method to java.lang.[Strict]Math

2021-08-03 Thread Brian Burkhalter
On Tue, 3 Aug 2021 08:42:18 GMT, Raffaello Giulietti wrote: >> The `floorDivExact()` methods are identical to their `floorDiv()` >> counterparts aside from that they throw an `ArithmeticException` when the >> dividend is `MIN_VALUE` and the divisor is `-1`. These methods behave with >>

Re: Quick question on JDK-8198997 and normalization of user.dir

2021-08-03 Thread Volker Simonis
Thanks for the quick confirmation! On Tue, Aug 3, 2021 at 4:41 PM Alan Bateman wrote: > > On 03/08/2021 15:36, Volker Simonis wrote: > > Hi, > > > > I have a quick question on JDK-8198997 [1] (a follow-up of JDK-8194154 > > [2]) which introduced normalization for the cached "user.dir" property >

Re: Quick question on JDK-8198997 and normalization of user.dir

2021-08-03 Thread Alan Bateman
On 03/08/2021 15:36, Volker Simonis wrote: Hi, I have a quick question on JDK-8198997 [1] (a follow-up of JDK-8194154 [2]) which introduced normalization for the cached "user.dir" property in order to avoid "inefficient, repeated normalization". However, from what I can see,

Quick question on JDK-8198997 and normalization of user.dir

2021-08-03 Thread Volker Simonis
Hi, I have a quick question on JDK-8198997 [1] (a follow-up of JDK-8194154 [2]) which introduced normalization for the cached "user.dir" property in order to avoid "inefficient, repeated normalization". However, from what I can see, WinNTFileSystem.getUserPath(), the only place where the cached

Re: [External] : Re: jpackage MacOS Notarization

2021-08-03 Thread Andy Herrick
I was having problems notarizing anything yesterday, but fixed them today. I can notarize my own test - but get failure when trying to notarize your app as built from non-modular branch of https://github.com/danielpeintner/Java11Test/ am looking into it ... /Andy On 8/2/2021 9:57 AM,

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-08-03 Thread Wang Huang
On Thu, 15 Jul 2021 03:30:46 GMT, Wang Huang wrote: >> Dear all, >> Can you do me a favor to review this patch. This patch use `ldp` to >> implement String.compareTo. >> >> * We add a JMH test case >> * Here is the result of this test case >> >> Benchmark

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v5]

2021-08-03 Thread Wang Huang
> Dear all, > Can you do me a favor to review this patch. This patch use `ldp` to > implement String.compareTo. > > * We add a JMH test case > * Here is the result of this test case > > Benchmark|(size)| Mode| Cnt|Score | Error |Units >

Re: RFR: 8271225: Add floorDivExact() method to java.lang.[Strict]Math

2021-08-03 Thread Raffaello Giulietti
On Thu, 29 Jul 2021 23:28:07 GMT, Brian Burkhalter wrote: >> Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to >> `java.lang.Math` and `java.lang.StrictMath`. > > The `floorDivExact()` methods are identical to their `floorDiv()` > counterparts aside from that they throw an