On Thu, Oct 7, 2021 at 12:15 AM Joe Darcy wrote:
> Curious. The JDK build is done with javac -Xlint:cast warning enabled
> (JDK-8032734) which is intended to catch issues like this. Perhaps IntelliJ
> is using a different (or sharper) analysis.
Yes, our analysis is written independently of
On Fri, 16 Apr 2021 11:30:32 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Wed, 6 Oct 2021 18:53:39 GMT, Andy Herrick wrote:
>> 8274346: Support for additional content in an app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8274346: Support for additional content in an app-image.
On Oct 5, 2021, at 5:05 PM, Raffaello Giulietti
mailto:github.com+70726043+rgiulie...@openjdk.java.net>>
wrote:
The proof of the central theorem of Schubfach is based on continued fractions.
It was prepared on ACL2 by the late Dmitry Nadezhin, who was a member of
Oracle's formal verification
> Sorting:
>
> - adopt radix sort for sequential and parallel sorts on int/long/float/double
> arrays (almost random and length > 6K)
> - fix tryMergeRuns() to better handle case when the last run is a single
> element
> - minor javadoc and comment changes
>
> Testing:
> - add new data inputs
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
`java.io` change looks all right.
-
It was meant to be a vertical ellipsis. In hindsight, we could use the
explicit character for that purpose. ('⋮' U+22EE)
Naoto
On 10/6/21 12:07 PM, Andrey Turbanov wrote:
Hello.
While reading the javadoc of CollationElementIterator I found a
strange colon in the example.
On Wed, 6 Oct 2021 19:43:06 GMT, Sean Coffey wrote:
>> This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c
>> level. Note that the tz data is "as is", as released by IANA. No `merged
>> links` are retracted.
>> The PR also fixes two issues along with the 2021c upgrade.
>
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote:
> This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c
> level. Note that the tz data is "as is", as released by IANA. No `merged
> links` are retracted.
> The PR also fixes two issues along with the 2021c upgrade.
Marked
> This reimplements core reflection with method handles.
>
> For `Constructor::newInstance` and `Method::invoke`, the new implementation
> uses `MethodHandle`. For `Field` accessor, the new implementation uses
> `VarHandle`.For the first few invocations of one of these reflective
>
On Wed, 6 Oct 2021 18:53:39 GMT, Andy Herrick wrote:
>> 8274346: Support for additional content in an app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8274346: Support for additional content in an app-image.
Hello.
While reading the javadoc of CollationElementIterator I found a
strange colon in the example.
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/text/CollationElementIterator.java#L87
String testString = "This is a test";
Collator col =
> 8274346: Support for additional content in an app-image.
Andy Herrick has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8274346: Support for additional content in an app-image.
-
Changes:
- all:
On Thu, 30 Sep 2021 11:26:12 GMT, Masanori Yano wrote:
> @mbreinhold Could you comment on this pull request?
This is somewhat tricky code. I’ll take a look, but give me a few days.
-
PR: https://git.openjdk.java.net/jdk/pull/5679
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov
wrote:
> StringBuffer is a legacy synchronized class. There are more modern
> alternatives which perform better:
> 1. Plain String concatenation should be preferred
> 2. StringBuilder is a direct replacement to StringBuffer which generally have
On Wed, 15 Sep 2021 07:08:09 GMT, Andrey Turbanov
wrote:
>> 8273711: Remove redundant stream() call before forEach in jdk.jlink
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8273711: Remove redundant stream() call
On Mon, 13 Sep 2021 20:06:08 GMT, Andrey Turbanov
wrote:
> 8273711: Remove redundant stream() call before forEach in jdk.jlink
This pull request has now been integrated.
Changeset: 4e7d7caa
Author:Andrey Turbanov
Committer: Daniel Fuchs
URL:
On Wed, 15 Sep 2021 07:12:25 GMT, Andrey Turbanov
wrote:
> 8274464: Remove redundant stream() call before forEach in java.* modules
This pull request has now been integrated.
Changeset: f3cedbe9
Author:Andrey Turbanov
Committer: Daniel Fuchs
URL:
On Wed, 6 Oct 2021 05:04:28 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote:
> This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c
> level. Note that the tz data is "as is", as released by IANA. No `merged
> links` are retracted.
> The PR also fixes two issues along with the 2021c upgrade.
Marked
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote:
> This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c
> level. Note that the tz data is "as is", as released by IANA. No `merged
> links` are retracted.
> The PR also fixes two issues along with the 2021c upgrade.
Marked
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
Curious. The JDK build is done with javac
Use correct manifest file name in the Manifest verifier checks.
Also - extra null check
The test doesn't reproduce the exact issue reported but should prevent future
regressions in this area.
-
Commit messages:
- 8273826: Correct Manifest file name and NPE checks
Changes:
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
Marked as reviewed by lancea (Reviewer).
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
Calendar-related changes look good to me.
On Wed, 6 Oct 2021 00:02:55 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274544: Langtools command's usage were garbled on Japanese Windows
>
> I just grepped `System.out/err` in jshell
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote:
> This commit appends the name of the JAR file to the exception message for
> when automatic module lists a non-existing provider class.
This pull request has now been integrated.
Changeset: c10de353
Author:Christian Stein
Redundant castings make code harder to read.
Found them by IntelliJ IDEA.
I tried to select only casts which are definitely safe to remove. Also didn't
touch primitive types casts.
-
Commit messages:
- [PATCH] Remove unnecessary castings in java.base
- [PATCH] Remove unnecessary
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
The security related files look fine.
I was actually referring to the
src/java.base/windows/native/launcher/java.manifest file (or the
jdk/src/windows/resource/java.manifest file on JDK 8) that gets embedded as a
manifest in the JDK executables.
When I was mentioning "UTF-8 manifest", I was referring to the java.manifest
file
When I ran the test programs to determine the behavior changes that occur with
the UTF-8 setting in the manifest, I
actually copied the executables of the compiled test programs and modified the
manifest resource of the copied executables to include the
UTF-8 setting.
I agree that UTF-8
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote:
> Could you please review the 8233674 bug fixes?
> This problem is caused by the antivirus software opening the file for a short
> time, so CreateFile() should be retried.
I inquired of the Microsoft Technical Support about this problem.
On Fri, 16 Apr 2021 11:30:32 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three
On Mon, 4 Oct 2021 21:13:02 GMT, PROgrm_JARvis
wrote:
> This is trivial fix of
> [JDK-8274686](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8274686)
> which replaces manually-computed `int`-based `long` hash-code.
>
> Because `Long#hashCode(long)` uses other hashing function than
On Mon, 4 Oct 2021 21:13:02 GMT, PROgrm_JARvis
wrote:
> This is trivial fix of
> [JDK-8274686](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8274686)
> which replaces manually-computed `int`-based `long` hash-code.
>
> Because `Long#hashCode(long)` uses other hashing function than
On Wed, 6 Oct 2021 08:33:21 GMT, Peter Levart wrote:
>> This is trivial fix of
>> [JDK-8274686](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8274686)
>> which replaces manually-computed `int`-based `long` hash-code.
>>
>> Because `Long#hashCode(long)` uses other hashing function
On Mon, 4 Oct 2021 21:13:02 GMT, PROgrm_JARvis
wrote:
> This is trivial fix of
> [JDK-8274686](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8274686)
> which replaces manually-computed `int`-based `long` hash-code.
>
> Because `Long#hashCode(long)` uses other hashing function than
On Sat, 11 Sep 2021 12:11:50 GMT, Andrey Turbanov
wrote:
> Usages of primitive types should be preferred and makes code easier to read.
> Similar cleanups:
> 1. [JDK-8273168](https://bugs.openjdk.java.net/browse/JDK-8273168)
> java.desktop
> 2.
On Sat, 11 Sep 2021 17:22:01 GMT, Сергей Цыпанов
wrote:
>> Usages of primitive types should be preferred and makes code easier to read.
>> Similar cleanups:
>> 1. [JDK-8273168](https://bugs.openjdk.java.net/browse/JDK-8273168)
>> java.desktop
>> 2.
Usages of primitive types should be preferred and makes code easier to read.
Similar cleanups:
1. [JDK-8273168](https://bugs.openjdk.java.net/browse/JDK-8273168) java.desktop
2. [JDK-8274234](https://bugs.openjdk.java.net/browse/JDK-8274234)
java.sql.rowset
-
Commit messages:
-
On Wed, 6 Oct 2021 05:04:28 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with
42 matches
Mail list logo
