On Fri, 5 Nov 2021 09:03:59 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes the
> `JLinkReproducibleTest` and `JLinkReproducible3Test` tests from the
> `ProblemList.txt`?
>
> With the fix for https://bugs.openjdk.java.net/browse/JDK-8275509 now merged,
> I e
On Fri, 5 Nov 2021 09:03:59 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes the
> `JLinkReproducibleTest` and `JLinkReproducible3Test` tests from the
> `ProblemList.txt`?
>
> With the fix for https://bugs.openjdk.java.net/browse/JDK-8275509 now merged,
> I e
On Tue, 2 Nov 2021 19:06:09 GMT, Anirvan Sarkar wrote:
> This fixes Properties.loadFromXML/storeToXML so that it works correctly for
> supplementary characters.
This pull request has now been integrated.
Changeset: c7095b20
Author:Anirvan Sarkar
Committer: Joe Wang
URL:
https://gi
On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote:
> The lack of anything to compile in `syslookup.c` is leading to a number of
> issues in our tooling, on some architectures more than others (s390x seems to
> be the most problematic). They expect to be able to retrieve debuginfo and
On Fri, 5 Nov 2021 20:46:42 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exception: changed from XPathFactoryConfigurationException to
>> IllegalArgumentException
>
> src/java.xml/share/classes/ja
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Removing IAE from the method signature; Update impl and test.
-
Cha
The fix is to isolate C++ calls in the separate forked child process on Linux.
This change requires the passing of JLI command line arguments and values of
environment variables between two processes.
-
Commit messages:
- Whitespace clean up
- 8274856: Failing jpackage tests with
On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote:
> The lack of anything to compile in `syslookup.c` is leading to a number of
> issues in our tooling, on some architectures more than others (s390x seems to
> be the most problematic). They expect to be able to retrieve debuginfo and
On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote:
> The lack of anything to compile in `syslookup.c` is leading to a number of
> issues in our tooling, on some architectures more than others (s390x seems to
> be the most problematic). They expect to be able to retrieve debuginfo and
On Fri, 5 Nov 2021 20:00:24 GMT, Roger Riggs wrote:
>> The three `java.lang.Runtime.exec` methods that tokenize a command line to
>> produce an array of string arguments are easily misused, sometimes with
>> erroneous results. For example, on some operating systems, spaces are
>> supported in
On Fri, 5 Nov 2021 20:34:06 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Exception: changed
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/j
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Exception: changed from XPathFactoryConfigurationException to
IllegalArgumentExc
On Fri, 5 Nov 2021 17:08:02 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 412:
>>
>>> 410: *
>>> 411: * @throws XPathFactoryConfigurationException if the property name
>>> is not
>>> 412: * recognized
>>
>> Are you sure XPathFactoryCon
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Exception: changed from XPathFactoryConfigurationException to
IllegalArgumentExc
On Fri, 5 Nov 2021 20:10:28 GMT, Joe Wang wrote:
> Do you need to add test?
I would if I could, but specifying the environment dependent settings in the
test would be fragile and error-prone, so I did not add a test but marked the
issue as `noreg-hard`.
-
PR: https://git.openjdk.
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Do you need to add test?
-
Marked as reviewed by joehw (Reviewer).
PR: http
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jd
> The three `java.lang.Runtime.exec` methods that tokenize a command line to
> produce an array of string arguments are easily misused, sometimes with
> erroneous results. For example, on some operating systems, spaces are
> supported in filenames and are in common use.
>
> The tokenization use
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
Please review the subject fix. In light of JEP400, Java runtime can/should
start in UTF-8 charset if the underlying native encoding is not supported.
-
Commit messages:
- Use UTF-8 if jnuEncoding is not supported
- Utilized 2-arg Charset.forName()
- 8275007: Java fails to start wi
On Fri, 5 Nov 2021 17:21:01 GMT, Andy Herrick wrote:
> JDK-8276562: Fix to JDK-8263155 left out the help text changes
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6281
JDK-8276562: Fix to JDK-8263155 left out the help text changes
-
Commit messages:
- JDK-8276562: Fix to JDK-8263155 left out the help text changes
Changes: https://git.openjdk.java.net/jdk/pull/6281/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6281&range=00
Iss
On Fri, 5 Nov 2021 11:02:37 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add default impl; Add tests.
>
> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 412:
>
>> 410: *
>>
On Fri, 5 Nov 2021 09:03:59 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes the
> `JLinkReproducibleTest` and `JLinkReproducible3Test` tests from the
> `ProblemList.txt`?
>
> With the fix for https://bugs.openjdk.java.net/browse/JDK-8275509 now merged,
> I e
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Fri, 5 Nov 2021 10:59:44 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add default impl; Add tests.
>
> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 406:
>
>> 404: * @i
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
drop: in the XPath API
-
Changes:
- all: https://git.openjdk.java
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Fri, 5 Nov 2021 14:33:44 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java
>> line 134:
>>
>>> 132: *
>>> 133: * Upcall stubs are generally safer to work with, as the linker
>>> runtime can validate the type of the target metho
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Fri, 5 Nov 2021 14:25:35 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Add two new CLinker static methods to compute upcall/downcall method
>> types
>> * Clarify section on CLinker
On Fri, 5 Nov 2021 11:06:53 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-419 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last modified timestamp of a `module-info.class`
> descriptor.
>
> This commit
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last modified timestamp of a `module-info.class`
> descriptor.
>
> This commit
On Fri, 5 Nov 2021 11:19:16 GMT, Lance Andersen wrote:
>> This PR enables reproducible Jars, Jmods and openjdk image zip files
>> (eg.src.zip).
>> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
>> ZipOutputStream's.
>> It fixes the following keys issues relating to repro
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
On Fri, 5 Nov 2021 11:31:34 GMT, Andrew Leonard wrote:
>> This PR enables reproducible Jars, Jmods and openjdk image zip files
>> (eg.src.zip).
>> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
>> ZipOutputStream's.
>> It fixes the following keys issues relating to repro
On 05/11/2021 11:39, Magnus Ihse Bursie wrote:
:
I agree with Alan's comment above. First of all, to be absolutely clear, I
think this is a very worthy goal, and much overdue. I'll do my best to help get
this implemented.
One suggestion is to separate out the issue of ordering of entries (in
On Fri, 5 Nov 2021 11:16:45 GMT, Lance Andersen wrote:
>> This PR enables reproducible Jars, Jmods and openjdk image zip files
>> (eg.src.zip).
>> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
>> ZipOutputStream's.
>> It fixes the following keys issues relating to repro
On Thu, 4 Nov 2021 11:48:04 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source owned by compiler. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they are
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus wrote:
> This change applies the minimal fix suggested in
> https://bugs.openjdk.java.net/browse/JDK-8231490.
> The bug text suggests possibilities for reworking, but notes that
> this change is enough to fix the data race.
> Adding a regression tes
On Tue, 2 Nov 2021 15:40:45 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweak javadoc of loaderLookup
>
> Marked as reviewed by psandoz (Reviewer).
I have made some minor API changes (a
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
On Fri, 5 Nov 2021 11:31:34 GMT, Andrew Leonard wrote:
>> This PR enables reproducible Jars, Jmods and openjdk image zip files
>> (eg.src.zip).
>> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
>> ZipOutputStream's.
>> It fixes the following keys issues relating to repro
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Thu, 4 Nov 2021 13:10:37 GMT, Christian Stein wrote:
> This PR implements the fix as suggested by Adam Farley, which reads:
>
>> Note: Looks to be as simple as adding `jaccessinspector-32` and
>> `jaccesswalker-32` to `TOOLS_NOT_TO_TEST` at the top of
>> `HelpFlagsTest.java`, as the non-32b
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Wed, 3 Nov 2021 01:10:46 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add default impl; A
On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote:
> The lack of anything to compile in `syslookup.c` is leading to a number of
> issues in our tooling, on some architectures more than others (s390x seems to
> be the most problematic). They expect to be able to retrieve debuginfo and
On Fri, 5 Nov 2021 09:03:59 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes the
> `JLinkReproducibleTest` and `JLinkReproducible3Test` tests from the
> `ProblemList.txt`?
>
> With the fix for https://bugs.openjdk.java.net/browse/JDK-8275509 now merged,
> I e
On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote:
> The lack of anything to compile in `syslookup.c` is leading to a number of
> issues in our tooling, on some architectures more than others (s390x seems to
> be the most problematic). They expect to be able to retrieve debuginfo and
Can I please get a review for this change which removes the
`JLinkReproducibleTest` and `JLinkReproducible3Test` tests from the
`ProblemList.txt`?
With the fix for https://bugs.openjdk.java.net/browse/JDK-8275509 now merged, I
expect these tests to stop failing intermittently. I have run these
On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote:
> The lack of anything to compile in `syslookup.c` is leading to a number of
> issues in our tooling, on some architectures more than others (s390x seems to
> be the most problematic). They expect to be able to retrieve debuginfo and
On 04/11/2021 21:16, Andrew Leonard wrote:
This PR enables reproducible Jars, Jmods and openjdk image zip files
(eg.src.zip).
It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
ZipOutputStream's.
It fixes the following keys issues relating to reproducibility:
- Jar and ZipOu
64 matches
Mail list logo
