On Wed, 12 Jan 2022 13:45:00 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8279921?
>
> The change here builds upon the debugging enhancement that was done in
> https://github.com/openjdk/jdk/pull/6696 to try
On Wed, 12 Jan 2022 13:45:00 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8279921?
>
> The change here builds upon the debugging enhancement that was done in
> https://github.com/openjdk/jdk/pull/6696 to try
On Thu, 13 Jan 2022 08:25:22 GMT, Andrey Turbanov wrote:
> Method `Class.isAssignableFrom` is often used in form of:
>
> if (clazz.isAssignableFrom(obj.getClass())) {
> Such condition could be simplified to more shorter and performarnt code
>
> if (clazz.isInstance(obj)) {
>
>
On Thu, 20 Jan 2022 00:28:55 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 4616c13c
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/4616c13c2f1ced8a8bdeed81f0469523932e91b5
Stats: 1732
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge
- 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl
- 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null"
when compiling
- 8272058: 25 Null pointer dereference defect groups in 4
On Wed, 19 Jan 2022 18:48:48 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>>
On Wed, 19 Jan 2022 22:20:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The
On Wed, 19 Jan 2022 17:38:25 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Fri, 14 Jan 2022 14:33:13 GMT, Jim Laskey wrote:
> Tests were fatally failing (windows) on Github actions. Pumping up the memory
> requirements will hopefully alleviate.
Okay - lets see how it goes.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR:
On Wed, 19 Jan 2022 17:38:25 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
> While it is strongly recommend to not use the default toString for a class,
> at times it is the least-bad alternative. When that alternative needs to be
> used, it would be helpful to have the implementation already available, such
> as in Objects.toDefaultString(). This method is analagous
On Wed, 19 Jan 2022 02:57:10 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>>
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH
On Fri, 14 Jan 2022 09:15:37 GMT, kabutz wrote:
>>> > embarrassingly parallelizable
>>>
>>> Having looked at [embarrassingly
>>> parallel](https://en.wikipedia.org/wiki/Embarrassingly_parallel), I'm not
>>> certain that this particular problem would qualify. The algorithm is easy
>>> to
On Fri, 14 Jan 2022 15:06:12 GMT, Daniel Fuchs wrote:
> Have you been able to test this on a specific setup? Would be good to hear
> from @msheppar too.
I have tested it with the server setup by Prajwal. Security SQE are looking
into configuring a server with a similar setup which can be
On Wed, 19 Jan 2022 15:36:16 GMT, Michael McMahon wrote:
>>> It's actually a purely system property rather than a Net property at the
>>> moment (same as the other spnego ones). Maybe, I should convert them all to
>>> net properties, so they can be documented/set in that file?
>>
>> AFAICS
On Wed, 19 Jan 2022 15:13:57 GMT, Rob McKenna wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/pool/PooledConnectionFactory.java
>> line 54:
>>
>>> 52: * @param timeout the connection timeout
>>> 53: */
>>> 54: public abstract PooledConnection
>>>
On Sat, 15 Jan 2022 14:02:15 GMT, Michael Osipov wrote:
>> I suggest moving the `TlsChannelBinding` class into
>> `java.base/sun.security.util` since it's not only used by LDAP anymore. It's
>> even not restricted to GSS-API. According to
>> https://www.rfc-editor.org/rfc/rfc5056, "Although
On Mon, 17 Jan 2022 13:44:06 GMT, Daniel Fuchs wrote:
>> Shall we log a message if the value is not one of the 3 forms?
>
> Usually malformed values are just ignored - and the property takes its
> default value. But yes - s.n.w.h.HttpClient has a logger so it wouldn't be
> much effort to log
On Mon, 17 Jan 2022 13:49:35 GMT, Daniel Fuchs wrote:
>> I vote for "jdk.https.tls.cbt"
>
>> It's actually a purely system property rather than a Net property at the
>> moment (same as the other spnego ones). Maybe, I should convert them all to
>> net properties, so they can be documented/set
On Thu, 13 Jan 2022 01:02:38 GMT, Mark Sheppard wrote:
>> Rob McKenna has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Allow the test to pass on MacOSX
>
> src/java.naming/share/classes/com/sun/jndi/ldap/pool/PooledConnectionFactory.java
On Wed, 19 Jan 2022 13:10:55 GMT, Peter Levart wrote:
> Note this matches other places we do the weak-reference loops, for example in
> `MethodType`:
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/invoke/MethodType.java#L1390-L1401
This one does not have
On Wed, 19 Jan 2022 10:44:57 GMT, Aleksey Shipilev wrote:
> > So, this patch is fine for making ClassCache more robust as a re-usable
> > component inside JDK (checking for non-null return of computeValue). The
> > 2nd change, that apparently shields against unbounded accumulation of
> >
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
This pull request has now been integrated.
Changeset: 8931c122
Author:Matthias Baesken
URL:
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7142
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
Marked as reviewed by egahlin (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7142
On Sat, 11 Sep 2021 12:11:50 GMT, Andrey Turbanov wrote:
> Usages of primitive types should be preferred and makes code easier to read.
> Similar cleanups:
> 1. [JDK-8273168](https://bugs.openjdk.java.net/browse/JDK-8273168)
> java.desktop
> 2.
On Wed, 19 Jan 2022 08:25:55 GMT, Aleksey Shipilev wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry
On Wed, 19 Jan 2022 10:42:02 GMT, Peter Levart wrote:
> So, this patch is fine for making ClassCache more robust as a re-usable
> component inside JDK (checking for non-null return of computeValue). The 2nd
> change, that apparently shields against unbounded accumulation of garbage,
> might
On Wed, 19 Jan 2022 08:25:55 GMT, Aleksey Shipilev wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry
On Wed, 19 Jan 2022 08:25:55 GMT, Aleksey Shipilev wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry
Very small change fixing wrong strings "Falied" in a couple of tests.
-
Commit messages:
- JDK-8280157
Changes: https://git.openjdk.java.net/jdk/pull/7142/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7142=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8280157
On Wed, 19 Jan 2022 02:57:10 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>>
On Mon, 17 Jan 2022 20:56:56 GMT, Andrey Turbanov wrote:
> Method `Thread.dispatchUncaughtException` (called by VM) uses result of of
> `getUncaughtExceptionHandler`. Field `uncaughtExceptionHandler` is volatile
> and can be changed by another Thread. Which could lead to NPE.
>
> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
> issues with it:
> - The cache cannot disambiguate between cleared SoftReference and the
> accidental passing of `null` value; in that case, the retry loop would spin
> indefinitely;
> - If retry loop would spin
On Tue, 18 Jan 2022 20:07:10 GMT, Roger Riggs wrote:
> It may not be worth it. If not, add the label "noreg-hard".
Added.
> It is possible for add to the test description the modules to be opened:
> ```
> * @modules java.base/java.io:open
> ```
>
> jtreg will add the appropriate command line
> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
> issues with it:
> - The cache cannot disambiguate between cleared SoftReference and the
> accidental passing of `null` value; in that case, the retry loop would spin
> indefinitely;
> - If retry loop would spin
38 matches
Mail list logo
