On Mon, 24 Jan 2022 12:02:10 GMT, Andrey Turbanov wrote:
>> Test `test/java/io/File/GetXSpace.java` always failed on my machine with
>> this output:
>>
>> --System.out:(12/489)--
>> --- Testing df
>> C:/Programs/cygwin64 292848636 49695320 243153316 17% /
>> D: 59672 59672 0
The SuppressWarnings annotation type is declared have multiple targets,
including modules; however, "package" is left off of its target list. As
package-info file are another kind of declaration where a compiler could give
warnings, allowing SuppressWarnings in that case is reasonable. Wanting
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from
On Wed, 26 Jan 2022 20:05:07 GMT, Joe Darcy wrote:
> The changes in this PR on top of the out-for-review changes in
> https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint
> checking to be enabled in all JDK modules.
>
> Typically, a @SuppressWarnings("doclint:refernce")
On Thu, 13 Jan 2022 12:19:03 GMT, Roman Kennke wrote:
>> Thread.java would benefit from a refactoring similar to JDK-8278065 to use
>> ClassValue instead of the somewhat problematic WeakClassKey mechanism.
>>
>> Testing:
>> - [x] tier1
>> - [x] tier2
>> - [x] tier3
>
> Roman Kennke has
On Wed, 26 Jan 2022 19:09:58 GMT, Alan Bateman wrote:
> I think this looks okay. It's only used when running with a SecurityManager
> so unlikely to be used in most deployments.
Thanks, Alan! Could you also 'approve' this PR?
Thanks, Roman
-
PR:
On Thu, 13 Jan 2022 12:19:03 GMT, Roman Kennke wrote:
>> Thread.java would benefit from a refactoring similar to JDK-8278065 to use
>> ClassValue instead of the somewhat problematic WeakClassKey mechanism.
>>
>> Testing:
>> - [x] tier1
>> - [x] tier2
>> - [x] tier3
>
> Roman Kennke has
On Wed, 26 Jan 2022 16:25:24 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed ^M from test
>
> test/jdk/sun/security/krb5/auto/HttpsCB.java line 120:
>
>> 118:
>> 119: boolean
On Wed, 26 Jan 2022 16:27:29 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed ^M from test
>
> test/jdk/sun/security/krb5/auto/HttpsCB.java line 201:
>
>> 199: return
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from
On Sat, 8 Jan 2022 21:00:37 GMT, Yasser Bazzi wrote:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method
On Sat, 8 Jan 2022 21:00:37 GMT, Yasser Bazzi wrote:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method
On Wed, 26 Jan 2022 17:04:35 GMT, Yasser Bazzi wrote:
>> src/java.base/share/classes/java/util/random/RandomGenerator.java line 144:
>>
>>> 142: /**
>>> 143: * Returns a wrapper to use {@link java.util.Random}
>>> 144: * @return {@link java.util.Random}
>>
>> Possible reword:
>>
On Wed, 26 Jan 2022 02:12:11 GMT, Joe Darcy wrote:
> Use floating-point library methods to nudge down the result if needed. The
> nextAfter(r, origin) call return the next value in the direction of origin,
> handling cases for negative values, etc.
>
> Changing to call nextDown for the origin
On Wed, 26 Jan 2022 14:58:43 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: a5a11f14
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/a5a11f14b9ccc8c25f8a4232e9de23f47fbfb400
Stats: 91
On Wed, 26 Jan 2022 17:05:33 GMT, Yasser Bazzi wrote:
>> src/java.base/share/classes/jdk/internal/util/random/RandomWrapper.java line
>> 41:
>>
>>> 39: @SuppressWarnings("serial")
>>> 40: public class RandomWrapper extends Random implements RandomGenerator {
>>> 41: private final
On Wed, 26 Jan 2022 15:36:28 GMT, Roger Riggs wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Wed, 26 Jan 2022 02:12:11 GMT, Joe Darcy wrote:
> Use floating-point library methods to nudge down the result if needed. The
> nextAfter(r, origin) call return the next value in the direction of origin,
> handling cases for negative values, etc.
>
> Changing to call nextDown for the origin
On Wed, 26 Jan 2022 16:02:09 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The
On Sat, 8 Jan 2022 21:00:37 GMT, Yasser Bazzi wrote:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge remote-tracking branch 'jdk18/master' into Merge_jdk18
- 8280592: Small javadoc tweaks to foreign API
The merge commit only contains trivial merges, so no merge-specific webrevs
have been generated.
Changes:
On Wed, 26 Jan 2022 02:12:11 GMT, Joe Darcy wrote:
> Use floating-point library methods to nudge down the result if needed. The
> nextAfter(r, origin) call return the next value in the direction of origin,
> handling cases for negative values, etc.
>
> Changing to call nextDown for the origin
On Mon, 24 Jan 2022 12:02:10 GMT, Andrey Turbanov wrote:
>> Test `test/java/io/File/GetXSpace.java` always failed on my machine with
>> this output:
>>
>> --System.out:(12/489)--
>> --- Testing df
>> C:/Programs/cygwin64 292848636 49695320 243153316 17% /
>> D: 59672 59672 0
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from
On Thu, 20 Jan 2022 10:55:59 GMT, Matthias Baesken wrote:
> After 8270492
> https://github.com/openjdk/jdk/commit/78b2c8419bc69436873e6fc9c542480949d140c5
> has been pushed, we should adjust
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java
>
27 matches
Mail list logo
