On Sat, 8 Jan 2022 21:00:37 GMT, Yasser Bazzi <d...@openjdk.java.net> wrote:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i > decided to use the > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html > interface to create the default method `asRandom()` that wraps around the > newer algorithms to be used on classes that do not accept the new interface. > > Some things to note as proposed by the bug report, the protected method > next(int bits) is not overrided and setSeed() method if left blank up to > discussion on what to do with it. > > Small test done on > https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4 This will also need a regression test. It should have a case to ensure that `asRandom` returns `this` if it's already an instance of `Random`. Maybe also a simple case of shuffling a list, similar to the gist. Also see if there are some tests for Random already that this can be plugged into. ------------- PR: https://git.openjdk.java.net/jdk/pull/7001
