Added ability to override description for additional launchers via
"description" property.
-
Commit messages:
- 8279995: jpackage --add-launcher option should allow overriding description
Changes: https://git.openjdk.java.net/jdk/pull/7399/files
Webrev:
On Thu, 3 Feb 2022 07:20:28 GMT, Aleksey Shipilev wrote:
> I was looking for easy things to do to improve `java.lang.invoke` cold
> performance. One of the things is inlining `VarForm.getMemberName` a bit, so
> that interpreter does not have to call through `getMemberNameOrNull`.
>
> There is
>
> I agree that it would
> be preferable for the expression to be something like this:
(int) Math.ceil(expected / 0.75)
Agree.
If we don't add a Java SE utility like "newHashMapWithExpectedSize",
> fallbacks would
> be to introduce an internal JDK utility method that is called from
On Tue, 8 Feb 2022 19:08:45 GMT, Naoto Sato wrote:
>> Following the prior discussion [1], here is the PR for the subject
>> enhancement. CSR has also been updated according to the suggestion.
>>
>> [1]
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
>
> Naoto
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has
On Tue, 8 Feb 2022 20:18:22 GMT, Brian Burkhalter wrote:
>> The work (the code) has been published here on GitHub, so afaik the
>> copyright year cannot be simply changed without modifying something (beside
>> the year itself, which would be self-justifying)
>
> @rgiulietti You are correct: no
On Tue, 8 Feb 2022 20:06:38 GMT, Raffaello Giulietti
wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>>
>> Enhanced intervals in
On Tue, 8 Feb 2022 20:09:30 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java.
This pull request has now been integrated.
Changeset: 5fb56dbb
Author:Daniel D. Daugherty
URL:
On Tue, 8 Feb 2022 20:10:38 GMT, Alexander Zvegintsev
wrote:
>> A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java.
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint and @bplb - Thanks for the lightning fast reviews!
-
PR:
On Tue, 8 Feb 2022 20:09:30 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7390
On Tue, 8 Feb 2022 20:09:30 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7390
On Tue, 8 Feb 2022 20:09:30 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java.
Marked as reviewed by azvegint (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7390
A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java.
-
Commit messages:
- 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java
Changes: https://git.openjdk.java.net/jdk/pull/7390/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7390=00
On Tue, 8 Feb 2022 19:51:53 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti Also the copyright year. So no further substantive updates
>> needed?
>
> @bplb Why the copyright year? Nothing is expected to change, except for the
> test mentioned.
@rgiulietti Well you know I am not sure about the
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 8 Feb 2022 19:41:48 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti Should we expect any more commits from you in this PR? Thanks.
>
> @bplb The last commit was pushed on Nov 15.
> I guess I would have to merge against the latest master because of
>
On Tue, 8 Feb 2022 19:47:25 GMT, Brian Burkhalter wrote:
>> @bplb The last commit was pushed on Nov 15.
>> I guess I would have to merge against the latest master because of
>> test/langtools/tools/javac/sym/ElementStructureTest.java
>> and the intervening switch from JDK18 to JDK19.
>
>
On Tue, 8 Feb 2022 19:23:54 GMT, Brian Burkhalter wrote:
>> En attendant go! go!
>
> @rgiulietti Should we expect any more commits from you in this PR? Thanks.
@bplb The last commit was pushed on Nov 15.
I guess I would have to merge against the latest master because of
On Tue, 8 Feb 2022 17:11:45 GMT, Aleksey Shipilev wrote:
>> I was looking for easy things to do to improve `java.lang.invoke` cold
>> performance. One of the things is inlining `VarForm.getMemberName` a bit, so
>> that interpreter does not have to call through `getMemberNameOrNull`.
>>
>>
On Tue, 11 Jan 2022 09:30:49 GMT, Raffaello Giulietti
wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>>
>> Enhanced intervals in
On Tue, 8 Feb 2022 18:56:02 GMT, Alan Bateman wrote:
>>> I'm almost tempted to have getInputStream(ZipEntry) be re-specified to
>>> throw IAE if the zip entry name is null.
>>
>> I personally think it is best to continue throw the NPE as that provides
>> symmetry with ZipFile::getInputStream,
> Following the prior discussion [1], here is the PR for the subject
> enhancement. CSR has also been updated according to the suggestion.
>
> [1]
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
Naoto Sato has updated the pull request incrementally with one
On Tue, 8 Feb 2022 18:11:38 GMT, Lance Andersen wrote:
> I personally think it is best to continue throw the NPE as that provides
> symmetry with ZipFile::getInputStream, aligns with the current javadoc where
> a null parameter will throw an NPE unless specified elsewhere, there are
>
On Mon, 7 Feb 2022 21:22:12 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified per suggestions on the PR
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
> line
On Tue, 8 Feb 2022 00:39:04 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified per suggestions on the PR
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
> line
> Following the prior discussion [1], here is the PR for the subject
> enhancement. CSR has also been updated according to the suggestion.
>
> [1]
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
Naoto Sato has updated the pull request incrementally with one
On Tue, 8 Feb 2022 15:55:50 GMT, Alan Bateman wrote:
> ze can't be null here.
Actually it can be: Consider the following:
try (JarFile jf = new JarFile(SIGNED_VALID_ENTRY_NAME_JAR.toFile(),
true)) {
var ze = new ZipEntry("org/gotham/Batcave.class");
var ex=
On Tue, 8 Feb 2022 18:05:25 GMT, Lance Andersen wrote:
>> ze can't be null here.
>
>> ze can't be null here.
>
> Actually it can be: Consider the following:
>
>
> try (JarFile jf = new JarFile(SIGNED_VALID_ENTRY_NAME_JAR.toFile(),
> true)) {
> var ze = new
On Tue, 8 Feb 2022 15:31:51 GMT, Sean Mullan wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce Exception checking to JarFile::verifiableEntry
>
> src/java.base/share/classes/java/util/jar/JarFile.java line
On Tue, 8 Feb 2022 18:06:52 GMT, Lance Andersen wrote:
>> Ah, yes - good catch!
>
> Will do.
> I'm almost tempted to have getInputStream(ZipEntry) be re-specified to throw
> IAE if the zip entry name is null.
I personally think it is best to continue throw the NPE as that provides
symmetry
On Tue, 8 Feb 2022 16:15:20 GMT, Sean Mullan wrote:
>> if ZipEntry is extended and getName() overridden then you can't trust the
>> name. So I think you'll have extract the name rather than calling
>> ZipEntry::getName twice. I'm almost tempted to have getInputStream(ZipEntry)
>> be
On Wed, 2 Feb 2022 20:21:54 GMT, Christian Stein wrote:
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
This pull request has
On Fri, 4 Feb 2022 22:29:45 GMT, Christian Stein wrote:
>> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
>> parent directories (here `a/b`) on the default file system before storing
>> the JAR file (here `foo.jar`) in the destination directory.
>
> Christian Stein
On Tue, 8 Feb 2022 17:39:37 GMT, Mandy Chung wrote:
> This change looks okay. One biggest cold startup overhead we measured for JEP
> 416 is due to the overhead of spinning and loading classes of MH/VH. This
> micro-optimization focuses on the performance of VH invocation. Do you see
> class
On Tue, 8 Feb 2022 17:11:45 GMT, Aleksey Shipilev wrote:
>> I was looking for easy things to do to improve `java.lang.invoke` cold
>> performance. One of the things is inlining `VarForm.getMemberName` a bit, so
>> that interpreter does not have to call through `getMemberNameOrNull`.
>>
>>
On Tue, 8 Feb 2022 17:11:45 GMT, Aleksey Shipilev wrote:
>> I was looking for easy things to do to improve `java.lang.invoke` cold
>> performance. One of the things is inlining `VarForm.getMemberName` a bit, so
>> that interpreter does not have to call through `getMemberNameOrNull`.
>>
>>
On Tue, 8 Feb 2022 14:16:15 GMT, Vladimir Ivanov wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
> I was looking for easy things to do to improve `java.lang.invoke` cold
> performance. One of the things is inlining `VarForm.getMemberName` a bit, so
> that interpreter does not have to call through `getMemberNameOrNull`.
>
> There is direct VarHandle benchmark in our corpus:
>
>
> $
On Tue, 8 Feb 2022 15:57:00 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 871:
>>
>>> 869: }
>>> 870: // ZipEntry::getName should not return null
>>> 871: if(ze.getName() != null) {
>>
>> Nit, add space after "if"
>
> if
On Tue, 8 Feb 2022 15:27:46 GMT, Sean Mullan wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce Exception checking to JarFile::verifiableEntry
>
> src/java.base/share/classes/java/util/jar/JarFile.java line
On Mon, 7 Feb 2022 23:02:54 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the attached patch to address
>>
>> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
>> parameter
>> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
On Thu, 3 Feb 2022 07:20:28 GMT, Aleksey Shipilev wrote:
> I was looking for easy things to do to improve `java.lang.invoke` cold
> performance. One of the things is inlining `VarForm.getMemberName` a bit, so
> that interpreter does not have to call through `getMemberNameOrNull`.
>
> There is
On Tue, 8 Feb 2022 13:41:28 GMT, Martin Balao wrote:
>>> @martinuy This pull request has been inactive for more than 4 weeks and
>>> will be automatically closed if another 4 weeks passes without any
>>> activity. To avoid this, simply add a new comment to the pull request. Feel
>>> free to
On Thu, 16 Dec 2021 01:23:11 GMT, Martin Balao wrote:
>> Hi @AlekseiEfimov
>>
>> Can you please review the CSR [1]?
>>
>> Thanks,
>> Martin.-
>>
>> --
>> [1] - https://bugs.openjdk.java.net/browse/JDK-8276959
>
>> @martinuy This pull request has been inactive for more than 4 weeks and will
On Tue, 8 Feb 2022 07:19:16 GMT, Aleksey Shipilev wrote:
> Thanks. Any more reviews needed, or I am pushing?
I think you're good to push. I suspect some might question making the code ever
so little less obvious/maintainable on behalf of interpreter performance, but I
think it's
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Thu, 16 Dec 2021 01:23:11 GMT, Martin Balao wrote:
>> Hi @AlekseiEfimov
>>
>> Can you please review the CSR [1]?
>>
>> Thanks,
>> Martin.-
>>
>> --
>> [1] - https://bugs.openjdk.java.net/browse/JDK-8276959
>
>> @martinuy This pull request has been inactive for more than 4 weeks and will
47 matches
Mail list logo
