On Tue, 22 Mar 2022 21:25:28 GMT, Valerie Peng wrote:
>> It's been several years since we increased the default key sizes. Before
>> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
>> the Commercial National Security Algorithm Suite which suggests:
>>
>> - SHA-384
On Wed, 23 Mar 2022 02:01:08 GMT, ExE Boss wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add exception message
>
> src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java line 424:
>
>> 422:
On Thu, 17 Mar 2022 13:40:53 GMT, Severin Gehwolf wrote:
> Please review this container test improvement. The test in question only
> makes sense iff the total swap space size as reported by the container aware
> OperatingSystemMXBean is `0`. If that's not the case, then something else
>
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 21:58:27 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/Character.java line 740:
>>
>>> 738: public static final class UnicodeBlock extends Subset {
>>> 739: /**
>>> 740: * 737 - the expected number of entities
>>
>> Just a quibble
On Wed, 23 Mar 2022 02:03:26 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On Tue, 22 Mar 2022 17:55:13 GMT, Mandy Chung wrote:
>> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
>> receiver check rather than NPE thrown by `Object::getClass`. The message of
>> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>>
On Wed, 23 Mar 2022 01:57:25 GMT, Fei Yang wrote:
>> src/hotspot/cpu/riscv/disassembler_riscv.hpp line 18:
>>
>>> 16: *
>>> 17: * You should have received a copy of the GNU General Public License
>>> version
>>> 18: * 2 along with this work; if not, write to the Free Software
>>>
On Tue, 22 Mar 2022 17:34:18 GMT, Vladimir Kozlov wrote:
>> Fei Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/cpu/riscv/disassembler_riscv.hpp line 18:
>
>> 16: *
>> 17: * You should
On Tue, 22 Mar 2022 14:01:28 GMT, Roger Riggs wrote:
> The test/jdk files look ok. (I didn't look at the rest)
Thank you for looking at that part.
-
PR: https://git.openjdk.java.net/jdk/pull/6294
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests
On Tue, 22 Mar 2022 21:25:28 GMT, Valerie Peng wrote:
>> It's been several years since we increased the default key sizes. Before
>> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
>> the Commercial National Security Algorithm Suite which suggests:
>>
>> - SHA-384
> If AbstractStringBuilder only grow, the inflated value which has been encoded
> in UTF16 can't be compressed.
> toString() can skip compression in this case. This can save an
> ArrayAllocation in StringUTF16::compress().
>
> java.io.BufferedRead::readLine() is a case that StringBuilder grows
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at
> Change `CallSite` to a sealed class, as `CallSite` is an abstract class which
> does not allow direct subclassing by users per its documentation. Since I
> don't have a JBS account, I posted the content for the CSR in a GitHub Gist
> at https://gist.github.com/150d5aa7f8b13a4deddf95969ad39d73
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at
On Tue, 22 Mar 2022 21:55:34 GMT, Mandy Chung wrote:
> I created CSR (https://bugs.openjdk.java.net/browse/JDK-8283530). I took the
> liberty to adjust the CSR to include only the needed information. Since I'm
> the RE for this CSR (you don't have JBS account), you will need another
>
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Naoto Sato has updated the pull request incrementally with
On Tue, 22 Mar 2022 21:42:04 GMT, Stuart Marks wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Comment adjusted per review suggestion
>
> src/java.base/share/classes/java/lang/Character.java line 740:
>
>> 738:
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Thanks
On Mar 22, 2022, at 12:28 PM, Volker Simonis
mailto:volker.simo...@gmail.com>> wrote:
On Mon, Mar 21, 2022 at 8:24 PM Lance Andersen
mailto:lance.ander...@oracle.com>> wrote:
Hi Lance,
Thanks for looking into this issue. Please find my answers inline:
Hi Volker,
I have read through what
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at
> It's been several years since we increased the default key sizes. Before
> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
> the Commercial National Security Algorithm Suite which suggests:
>
> - SHA-384 for secure hashing
> - AES-256 for symmetric encryption
> -
On Tue, 22 Mar 2022 19:07:12 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Marked
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Marked
Fixing the out-of-date number of entries in
`Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
renamed and now repurposed just to examine whether the `NUM_ENTITIES` correctly
has the `map.size()` value.
-
Commit messages:
- 8283465:
Please review this change to the java/util/prefs/AddNodeChangeListener.jar test.
Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh
Preferences on each test run, MacOS does not seem to honor this, and still
stores prefs in Library/.
This test has long suffered
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
> helpful but not in this case.
Mandy Chung has updated the
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On Tue, 22 Mar 2022 14:04:07 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 22 Mar 2022 00:01:59 GMT, Joe Darcy wrote:
> As part of updating the core libraries to be sealed, the package-access
> AbstractStringBuilder, implementation superclass of StringBuilder and
> StringBuffer, can be marked as sealed with those two subclasses on its
> permits list.
This
On Mon, Mar 21, 2022 at 8:24 PM Lance Andersen
wrote:
Hi Lance,
Thanks for looking into this issue. Please find my answers inline:
> Hi Volker,
>
> I have read through what you have provided/pointed to, thank you, and on the
> surface what you are suggesting sounds reasonable.
>
> That being
On Fri, 4 Mar 2022 17:54:20 GMT, Jim Laskey wrote:
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
>
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On Mon, 21 Mar 2022 17:36:53 GMT, Maurizio Cimadamore
wrote:
>> make/modules/java.base/Lib.gmk line 217:
>>
>>> 215: CXXFLAGS := $(CXXFLAGS_JDKLIB), \
>>> 216: LDFLAGS := $(LDFLAGS_JDKLIB) -Wl$(COMMA)--no-as-needed, \
>>> 217: LIBS := $(LIBCXX) -lc -lm -ldl, \
>>
>> Instead
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement
On Tue, 22 Mar 2022 12:56:02 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/runtime/Carrier.java line 574:
>>
>>> 572: try {
>>> 573: Lookup lookup = MethodHandles.lookup();
>>> 574: return lookup.defineHiddenClass(bytes, false,
>>>
On Tue, 22 Mar 2022 13:00:14 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Tue, 22 Mar 2022 00:01:59 GMT, Joe Darcy wrote:
> As part of updating the core libraries to be sealed, the package-access
> AbstractStringBuilder, implementation superclass of StringBuilder and
> StringBuffer, can be marked as sealed with those two subclasses on its
> permits list.
LGTM.
On 22/03/2022 4:56 pm, Rémi Forax wrote:
On Tue, 22 Mar 2022 04:38:15 GMT, ExE Boss wrote:
javac should be changed to allow fully qualified access to private inner
classes in the permits clause of an enclosing class.
This is not how private works, private means accessible between the '{'
On Mon, 21 Mar 2022 18:02:07 GMT, ExE Boss wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commits since
On Tue, 22 Mar 2022 10:20:15 GMT, Daniel Fuchs wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commits
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Tue, 22 Mar 2022 12:08:01 GMT, Fei Yang wrote:
>> make/autoconf/libraries.m4 line 152:
>>
>>> 150: fi
>>> 151:
>>> 152: # Programs which use C11 or C++11 atomics, like #include ,
>>
>> Use of C++ atomics is not allowed in hotspot code base. See the style guide:
>>
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On Mon, Mar 21, 2022 at 8:19 PM Alan Bateman wrote:
>
Hi Alan,
Thanks for looking at this issue. Please find my answers to your
questions inline:
> On 04/03/2022 10:04, Volker Simonis wrote:
> > :
> >
> > 1. Relax the specification of `InflaterInputStream::read(..)` and
> > specifically note
On Tue, 22 Mar 2022 04:13:17 GMT, David Holmes wrote:
>> Fei Yang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>>
On Tue, 22 Mar 2022 05:12:46 GMT, David Holmes wrote:
> Hi,
>
> I've looked at everything that is not a RISC-V specific file, except for the
> C1 changes as the compiler folk will need to approve those.
>
> Some copyrights will need updating to 2022 on the Oracle copyright line
> please.
Hi
On Tue, 22 Mar 2022 03:31:16 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Tue, 22 Mar 2022 06:54:35 GMT, Xin Liu wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1008:
>>
>>> 1006: this.count = newCount;
>>> 1007: putStringAt(start, str);
>>> 1008: if (end - start > 0) {
>>
>> regardless of value of `end -
On Tue, 22 Mar 2022 08:05:35 GMT, Xin Liu wrote:
>> If AbstractStringBuilder only grow, the inflated value which has been
>> encoded in UTF16 can't be compressed.
>> toString() can skip compression in this case. This can save an
>> ArrayAllocation in StringUTF16::compress().
>>
>>
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
> The current vector `"NEG"` is implemented with substraction a vector by zero
> in case the architecture does not support the negation instruction. And to
> fit the predicate feature for architectures that support it, the masked
> vector `"NEG" ` is implemented with pattern `"v.not(m).add(1,
On Sat, 19 Mar 2022 03:11:12 GMT, Jie Fu wrote:
>>> Note that in terms of Java semantics, negation of floating point values
>>> needs to be implemented as subtraction from negative zero rather than
>>> positive zero:
>>>
>>> double negate(double arg) {return -0.0 - arg; }
>>>
>>> This is to
> If AbstractStringBuilder only grow, the inflated value which has been encoded
> in UTF16 can't be compressed.
> toString() can skip compression in this case. This can save an
> ArrayAllocation in StringUTF16::compress().
>
> java.io.BufferedRead::readLine() is a case that StringBuilder grows
On Fri, 18 Mar 2022 20:19:08 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
I mean _inside method body_ itself.It's only declared, but no code in
the method refers to this parameter.
Andrey Turbanov
вт, 22 мар. 2022 г. в 01:37, Mandy Chung :
>
> VersionProps::print(boolean err, boolean newln) is called by
> VersionProps::println(boolean) and
On Tue, 15 Mar 2022 23:25:17 GMT, Claes Redestad wrote:
>> Xin Liu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change growOnly to maybeLatin.
>>
>> This patch also copys over the attribute from the other
>>
On Tue, 22 Mar 2022 04:38:15 GMT, ExE Boss wrote:
> javac should be changed to allow fully qualified access to private inner
> classes in the permits clause of an enclosing class.
This is not how private works, private means accessible between the '{' and the
'}' of the class.
The permits
72 matches
Mail list logo
