On Thu, 7 Apr 2022 00:56:42 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package
On Fri, 1 Apr 2022 15:38:36 GMT, Andrew Haley wrote:
>> Will this patch change `java.lang.Math`, `java.lang.StrictMath` or both?
>> I've noticed differences in iterative machine learning algorithms using exp
>> & log across different JVMs and architectures which we try to track in
>>
On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
>>
>>> 61: Locale.of("it", "IT", "EURO"),
>>> 62: Locale.forLanguageTag("de-AT"),
>>> 63: Locale.forLanguageTag("fr-CH"),
>>
>> Use the
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
>>
>>> 79:
>>> 80: /**
>>> 81: * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
>>
>> Locale.France?
>
> The test code parses the input string
We recently updated our ASM version to 9.2 and just this week version 9.3 was
announced with support for JDK19 so it makes sense to update to this last
version.
Thanks in advance for the reviews,
Vicente
-
Commit messages:
- updating test ValidateJarWithSealedAndRecord
-
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which now marks `CollectionView` as
> a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as
> the sub-classes? This change corresponds to
>
On Thu, 7 Apr 2022 00:09:58 GMT, Joe Wang wrote:
>> This is a follow-on task after deprecating the Locale constructors
>> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
>> simple replacements to Locale constructors with `Locale.of()` or Locale
>> constants, such
> Created a test called NullCallerGetResource to test
> Module::getResourceAsStream and Class::getResourceAsStream from the native
> level.
>
> At the java level the test builds a test module called 'n' which opens the
> package 'open' to everyone. There is also a package 'closed' which is
Created a test called NullCallerGetResource to test Module::getResourceAsStream
and Class::getResourceAsStream from the native level.
At the java level the test builds a test module called 'n' which opens the
package 'open' to everyone. There is also a package 'closed' which is neither
opened
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
- Original Message -
> From: "Ceki Gülcü"
> To: "core-libs-dev"
> Sent: Thursday, April 7, 2022 1:04:11 AM
> Subject: Re: fast way to infer caller
> Hi Jason,
>
> Yes, the code was mentioned in SLF4J PR 271.
>
> The benchmark can be found at
>
>
> On Apr 6, 2022, at 3:54 PM, Remi Forax wrote:
>
> - Original Message -
>> From: "Ceki Gülcü"
>> To: "core-libs-dev"
>> Sent: Wednesday, April 6, 2022 11:26:39 PM
>> Subject: Re: fast way to infer caller
>
>> Hi Rémi,
>>
>
> Now, i don't think there is a real solution to you
Hi Jason,
Yes, the code was mentioned in SLF4J PR 271.
The benchmark can be found at
https://github.com/ceki/logback-perf/tree/master/src/main/java/ch/qos/logback/perf/caller
Here is the gist of the StackWalker variant:
public class CallerCompute {
static private StackWalker WALKER =
- Original Message -
> From: "Ceki Gülcü"
> To: "core-libs-dev"
> Sent: Wednesday, April 6, 2022 11:26:39 PM
> Subject: Re: fast way to infer caller
> Hi Rémi,
>
> Thank you for your answer.
>
> According to some benchmarks on a i7-8565U Intel CPU (quite average
> CPU), here are the
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
Ceki,
Looks like the benchmark code is from https://github.com/qos-ch/slf4j/pull/271
Looks like the benchmark code is doing a collection so perhaps that is some of
the performance hit?
Have you benchmarked java.util.LogRecord.getSourceClassName() to compare with
your StackWalker benchmark?
On Wed, 6 Apr 2022 17:43:34 GMT, John R Rose wrote:
>> Paul Sandoz has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc and test updates.
>
> test/jdk/java/lang/AbstractCompressExpandTest.java line 104:
>
>> 102: abstract long
> Add support to compress bits and expand bits of `int` and `long` values, see
> Hacker's Delight (2nd edition), section 7.4.
>
> Compressing or expanding bits of an `int` or `long` value can be composed to
> enable general permutations, and the "sheep and goats" operation (SAG) see
> Hacker's
Hi Rémi,
Thank you for your answer.
According to some benchmarks on a i7-8565U Intel CPU (quite average
CPU), here are the costs of computing the caller class via different
methods:
using new Throwable().getStackTrace: 11 microseconds per call
using StackWalker API: 1.8 microseconds per call
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - revert xalan changes
> - revert icu changes
JFR changes look fine,
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Tue, 5 Apr 2022 22:05:19 GMT, Paul Sandoz wrote:
> Add support to compress bits and expand bits of `int` and `long` values, see
> Hacker's Delight (2nd edition), section 7.4.
>
> Compressing or expanding bits of an `int` or `long` value can be composed to
> enable general permutations, and
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - revert xalan changes
> - revert icu changes
The changes look fine
On Wed, 6 Apr 2022 14:12:49 GMT, Daniel Jeliński wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 63:
>>
>>> 61: message.creating-association-with-null-extension=Creating association
>>> with null extension.
>>> 62:
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - revert xalan changes
> - revert icu changes
The `jpackage` part of
This is a follow-on task after deprecating the Locale constructors
(https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
simple replacements to Locale constructors with `Locale.of()` or Locale
constants, such as `Locale.US`.
-
Commit messages:
- 8283698:
On Wed, 6 Apr 2022 14:58:37 GMT, Alan Bateman wrote:
>> Add support to compress bits and expand bits of `int` and `long` values, see
>> Hacker's Delight (2nd edition), section 7.4.
>>
>> Compressing or expanding bits of an `int` or `long` value can be composed to
>> enable general
On Wed, 6 Apr 2022 00:46:01 GMT, Vladimir Kozlov wrote:
> I have few comments.
Thank you Vladimir (@vnkozlov) for suggesting the changes! Will incorporate the
suggestions and push an update in few hours.
-
PR: https://git.openjdk.java.net/jdk/pull/7572
On Tue, 5 Apr 2022 15:40:29 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
>>
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the autovectorizer, the complexity of doing it by hand is
On Wed, 6 Apr 2022 16:48:38 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
>>
>>> 61: * http://www.ietf.org/rfc/rfc3454.txt;>RFC 3454.
>>> 62: * StringPrep prepares Unicode strings for use in network protocols.
>>> 63: * Profiles of
On Wed, 6 Apr 2022 15:49:06 GMT, Naoto Sato wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert liblcms changes
>
> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
>
>> 61: *
> This patch adds missing `r` in `string`s
Daniel Jeliński has updated the pull request incrementally with two additional
commits since the last revision:
- revert xalan changes
- revert icu changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8125/files
- new:
On Wed, 6 Apr 2022 15:54:30 GMT, Naoto Sato wrote:
> Looks good to me. This would have been a premiere example for switch pattern
> match, but hey.
Yeah, totally understand the urge to use new features.
-
PR: https://git.openjdk.java.net/jdk/pull/8116
On Tue, 29 Mar 2022 12:43:25 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave
On Wed, 6 Apr 2022 16:02:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use (double) DEFAULT_LOAD_FACTOR instead of 0.75
There be another
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Wed, 6 Apr 2022 15:57:55 GMT, Alan Bateman wrote:
> I suspect the core-libs label was added when you created it but you've
> expanded it greatly since.
Is there a way for making the bot re-calculate the labels?
-
PR: https://git.openjdk.java.net/jdk/pull/7928
On Wed, 6 Apr 2022 15:55:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - drop CalculateHashMapCapacityTestJMH
> - refine javadoc for
On Wed, 6 Apr 2022 02:38:17 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes in jdk.compile
>
> src/java.base/share/classes/java/util/HashMap.java line 2556:
>
>> 2554: */
>>
On Wed, 6 Apr 2022 15:47:50 GMT, XenoAmess wrote:
> I plan to include these changes to issue JDK-8186958, as I don't think it
> better to flood about 50 P5 issues and do them seperately in every places.
>
> That would be a nightmare for reviewers.
I didn't ask for 50 PRs, I just asked if you
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
use (double) DEFAULT_LOAD_FACTOR instead of 0.75
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
-
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Wed, 6 Apr 2022 00:54:41 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes in jdk.compile
>
> src/java.base/share/classes/java/util/LinkedHashMap.java line 792:
>
>> 790:
>> 791:
On Wed, 6 Apr 2022 14:27:45 GMT, Alan Bateman wrote:
> The current patch touches usages all over the JDK. Is that for illustration
> purposes or are you planning to include them with the methods?
@AlanBateman
I plan to include these changes to issue JDK-8186958, as I don't think it
better to
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- drop CalculateHashMapCapacityTestJMH
- refine javadoc for LinkedHashMap#newLinkedHashMap
-
Changes:
- all:
On Wed, 6 Apr 2022 14:12:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert liblcms changes
- Original Message -
> From: "Ceki Gülcü"
> To: "core-libs-dev"
> Sent: Wednesday, April 6, 2022 5:30:51 PM
> Subject: fast way to infer caller
> Hello,
Hello,
>
> As you are probably aware, one of the important primitives used in
> logging libraries is inferring the caller of a
Hello,
As you are probably aware, one of the important primitives used in
logging libraries is inferring the caller of a given logging statement.
The current common practice is to create a throwable and process its
stack trace. This is rather wasteful and rather slow. As an alternative,
I have
On Tue, 5 Apr 2022 22:05:19 GMT, Paul Sandoz wrote:
> Add support to compress bits and expand bits of `int` and `long` values, see
> Hacker's Delight (2nd edition), section 7.4.
>
> Compressing or expanding bits of an `int` or `long` value can be composed to
> enable general permutations, and
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in jdk.compile
The current patch touches usages all over
On Mon, 4 Apr 2022 09:58:35 GMT, Claes Redestad wrote:
> As an alternative to #7667 I took a look at injecting an empty class array
> from the VM. Turns out we already do this for exception types - see
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/oops/method.cpp#L918
> - and
On Mon, 4 Apr 2022 09:58:35 GMT, Claes Redestad wrote:
> As an alternative to #7667 I took a look at injecting an empty class array
> from the VM. Turns out we already do this for exception types - see
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/oops/method.cpp#L918
> - and
On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert liblcms changes
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
> This patch adds missing `r` in `string`s
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Revert liblcms changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8125/files
- new:
On Wed, 6 Apr 2022 13:38:03 GMT, Alexey Ivanov wrote:
>> This patch adds missing `r` in `string`s
>
> src/java.desktop/share/native/liblcms/cmstypes.c line 3668:
>
>> 3666: // Auxiliary, read an string specified as count + string
>> 3667: static
>> 3668: cmsBool ReadCountAndString(struct
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote:
> This patch adds missing `r` in `string`s
src/java.desktop/share/native/liblcms/cmstypes.c line 3668:
> 3666: // Auxiliary, read an string specified as count + string
> 3667: static
> 3668: cmsBool ReadCountAndString(struct
On Mon, 4 Apr 2022 09:58:35 GMT, Claes Redestad wrote:
> As an alternative to #7667 I took a look at injecting an empty class array
> from the VM. Turns out we already do this for exception types - see
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/oops/method.cpp#L918
> - and
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote:
> This patch adds missing `r` in `string`s
This PR cuts across many areas, so will need multiple reviewers. Regarding the
LCMS file, we typically don't make these kind of changes in third-party code,
since it will cause our code to
This patch adds missing `r` in `string`s
-
Commit messages:
- Fix sting typo
Changes: https://git.openjdk.java.net/jdk/pull/8125/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8125=00
Issue: https://bugs.openjdk.java.net/browse/JDK-828
Stats: 25 lines in 8 files
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote:
> Add missing `exit(exitCode)` call.
> Add relevant unit test.
This pull request has now been integrated.
Changeset: b9cc3bc1
Author:Alexey Semenyuk
URL:
On Wed, 6 Apr 2022 09:42:21 GMT, Claes Redestad wrote:
> Do I need a second reviewer for the hotspot changes?
FWIW, I think hotspot changes are quite simple, so maybe no need for second
reviewer?
-
PR: https://git.openjdk.java.net/jdk/pull/8089
On Tue, 5 Apr 2022 10:37:26 GMT, Kevin Walls wrote:
> A sanity check using "jcmd VM.info" to catch the signal handler modification
> warning: it should never trigger during this test.
(adding a note to trigger email notification, as that appears lost...)
-
PR:
On Wed, 6 Apr 2022 07:58:33 GMT, Aleksey Shipilev wrote:
>> As an alternative to #7667 I took a look at injecting an empty class array
>> from the VM. Turns out we already do this for exception types - see
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/oops/method.cpp#L918
>>
On Fri, 25 Mar 2022 11:54:52 GMT, Alan Bateman wrote:
>> Dongbo He has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Get date by 'date +%Y-%m-%dT%H:%M:%S%:z'
>
> The existing tests for the jmod tool are in test/jdk/tools/jmod.
>
On Mon, 4 Apr 2022 09:58:35 GMT, Claes Redestad wrote:
> As an alternative to #7667 I took a look at injecting an empty class array
> from the VM. Turns out we already do this for exception types - see
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/oops/method.cpp#L918
> - and
On Fri, 1 Apr 2022 08:10:48 GMT, Aleksey Shipilev wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also update LastModified
>
> Any other reviews? I would like someone else to confirm my investigation that
>
On Mon, 4 Apr 2022 07:24:12 GMT, Vamsi Parasa wrote:
>> Also need a jtreg test for this.
>
>> Also need a jtreg test for this.
>
> Thanks Sandhya for the review. Made the suggested changes and added jtreg
> tests as well.
Hi @vamsi-parasa , thanks for addressing my comments, looks good to me
On Wed, 6 Apr 2022 06:02:07 GMT, Vamsi Parasa wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
74 matches
Mail list logo
