On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote:
>> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
>> `merge` would throw CME if the functions modified the map itself, and there
>> are corresponding specification changes.
>
> liach has updated the pull request
On Wed, 20 Apr 2022 17:24:56 GMT, Paul Sandoz wrote:
> We can raise attention to that:
>
> ```
> /** Produce {@code a>>>(n&(ESIZE*8-1))}
> * (The operand and result are converted if the operand type is {@code byte}
> or {@code short}, see below). Integral only.
> * ...
> */
> ```
It
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object)))
> to mention such behavior.
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by
> `LSHR` will be different from that of
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass,
> the interfaces are iterated twice. The two passes can be merged into one,
> yielding the whole proxy definition context (module, package, whether there's
> package-private interface) when determining the module.
>
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
On Thu, 21 Apr 2022 01:01:25 GMT, Stuart Marks wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Thu, 21 Apr 2022 00:00:47 GMT, Stuart Marks wrote:
>
> I think it's a vanishingly small possibility that anything is relying on the
> synchronization in these methods. Synchronization here would provide proper
> memory visibility effects across threads. To use input streams from multiple
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
Fixing performance regression caused by the fix to
https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra
looping through the resource map multiple times which was not necessary. The
execution time of the tool now got back on par with close to JDK18.
-
Commit
On Wed, 20 Apr 2022 20:08:01 GMT, Joe Wang wrote:
> Patch note:
>
> A previous patch had a bug that missed the boundary check, that will cause
> StringIndexOutOfBoundsException to be thrown instead of
> XPathExpressionException as expected.
>
> Fix: the fix is to check the boundaries of
On Wed, 20 Apr 2022 21:53:46 GMT, Joe Wang wrote:
>> Patch note:
>>
>> A previous patch had a bug that missed the boundary check, that will cause
>> StringIndexOutOfBoundsException to be thrown instead of
>> XPathExpressionException as expected.
>>
>> Fix: the fix is to check the
> Patch note:
>
> A previous patch had a bug that missed the boundary check, that will cause
> StringIndexOutOfBoundsException to be thrown instead of
> XPathExpressionException as expected.
>
> Fix: the fix is to check the boundaries of the parameter "index".
> Objects.checkIndex is
On Wed, 20 Apr 2022 21:19:14 GMT, Roger Riggs wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove = check
>
> Can you run the JMH against the code before either change (or an existing
> JDK).
> It would be
Thanks a lot for your feedback! My original message was a bit vague in parts,
sorry for that.
The proposal consists of the following:
1. Forbidding usage of `break`, `continue`, `yield` and `return` in `finally`
blocks
2. Adding exceptions as suppressed exceptions:
If exception E1 led to
On Wed, 20 Apr 2022 21:08:19 GMT, XenoAmess wrote:
>> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
>> https://github.com/openjdk/jdk/pull/8292/
>>
>> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
>> continue;
>>
On Wed, 20 Apr 2022 20:56:50 GMT, Roger Riggs wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add jmh test
>
> Thanks for the JMH tests and data.
>
> The only part needed from the JMH run is the last 9 lines. The
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
>
> should be changed to
>
> if (((u1
On Wed, 20 Apr 2022 20:09:06 GMT, XenoAmess wrote:
>> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
>> https://github.com/openjdk/jdk/pull/8292/
>>
>> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
>> continue;
>>
On Wed, 20 Apr 2022 14:50:42 GMT, Vicente Romero wrote:
> nit: just ran langtools tests as part of my routine and these seem to be
> failing, `CheckExamples.java` due to:
>
> ```
> test/langtools/tools/javac/diags/examples/FeatureTotalPatternsInInstanceof.java
> and
>
On Wed, 20 Apr 2022 20:08:01 GMT, Joe Wang wrote:
> Patch note:
>
> A previous patch had a bug that missed the boundary check, that will
> cause StringIndexOutOfBoundsException to be thrown instead of
> XPathExpressionException as expected.
>
> Fix: the fix is to check the boundaries
On Wed, 20 Apr 2022 20:09:06 GMT, XenoAmess wrote:
>> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
>> https://github.com/openjdk/jdk/pull/8292/
>>
>> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
>> continue;
>>
Patch note:
A previous patch had a bug that missed the boundary check, that will cause
StringIndexOutOfBoundsException to be thrown instead of
XPathExpressionException as expected.
Fix: the fix is to check the boundaries of the parameter "index".
Objects.checkIndex is removed as it's
On Tue, 19 Apr 2022 21:15:29 GMT, XenoAmess wrote:
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
>
> should be changed to
>
> if (((u1
On Wed, 20 Apr 2022 18:40:13 GMT, Alan Bateman wrote:
> Thanks for the update. I can't think how anything could depend on this but
> unfortunately it's been like that since early JDK releases. We will need a
> release note, I'm sure Joe will give his opinion on whether a CSR should be
>
On Wed, 2022-04-20 at 12:38 -0400, Alexey Semenyuk wrote:
>
> On 4/18/2022 7:06 PM, Hiran Chaudhuri wrote:
> > On Mon, 2022-04-18 at 18:41 -0400, Alexey Semenyuk wrote:
> > > I've filed [1] and [2] CRs to track the issues.
> > >
> > > [1] https://bugs.openjdk.java.net/browse/JDK-8284973
> > > [2]
1. No need to call `String.substring` if you need need to compare start of
string with some constant. `String.startWith` suites better.
2. Unused String array is allocated in `childrenNamesSpi` method
-
Commit messages:
- [PATCH] Avoid redundant allocations in WindowsPreferences
-
> as title.
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add more replaces
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8302/files
- new:
On Wed, 20 Apr 2022 17:40:24 GMT, Joe Wang wrote:
> Patch note:
>
> The previous patch changed all literal tokens to use constants. However,
> replacing "." with Token.DOT introduced this bug.
> While tokens with a single char are inherently of type char, due to the
> different
> as title.
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add more replaces
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8302/files
- new:
> as title.
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- add more replaces
- add more replaces
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8302/files
- new:
On Wed, 20 Apr 2022 00:32:25 GMT, Brent Christian wrote:
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a
On Wed, 20 Apr 2022 00:32:25 GMT, Brent Christian wrote:
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a
On Tue, 19 Apr 2022 18:12:04 GMT, Stuart Marks wrote:
> The test `java/lang/Enum/ConstantDirectoryOptimalCapacity.java` was
> problem-listed by
> [JDK-8281631](https://bugs.openjdk.java.net/browse/JDK-8281631) and
> essentially superseded by
>
On Wed, 20 Apr 2022 18:28:19 GMT, Joe Wang wrote:
>> Patch note:
>>
>> The previous patch changed all literal tokens to use constants. However,
>> replacing "." with Token.DOT introduced this bug.
>> While tokens with a single char are inherently of type char, due to the
>> different
On Wed, 20 Apr 2022 18:18:25 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 20 Apr 2022 18:28:19 GMT, Joe Wang wrote:
>> Patch note:
>>
>> The previous patch changed all literal tokens to use constants. However,
>> replacing "." with Token.DOT introduced this bug.
>> While tokens with a single char are inherently of type char, due to the
>> different
> Patch note:
>
> The previous patch changed all literal tokens to use constants. However,
> replacing "." with Token.DOT introduced this bug.
> While tokens with a single char are inherently of type char, due to the
> different implementation of the overloaded method "tokenIs" that takes
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
Patch note:
The previous patch changed all literal tokens to use constants. However,
replacing "." with Token.DOT introduced this bug.
While tokens with a single char are inherently of type char, due to the
different implementation of the overloaded method "tokenIs" that takes String
or char,
On Tue, 19 Apr 2022 21:15:29 GMT, XenoAmess wrote:
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
On Wed, 20 Apr 2022 16:50:06 GMT, Roger Riggs wrote:
> Point 1 make sense. Point 2 adds a branch and branches aren't free. Can you
> show some jmh data for these cases?
@RogerRiggs
Bad news is I don't know how to make a jmh benchmark for a not-public class...
-
PR:
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
On Tue, 19 Apr 2022 18:47:16 GMT, Jan Lahoda wrote:
>> This is a (preliminary) patch for javac implementation for the third preview
>> of pattern matching for switch (type patterns in switches).
>>
>> Draft JLS:
>>
On Thu, 7 Apr 2022 00:38:07 GMT, Tim Prinzing wrote:
> Created a test called NullCallerGetResource to test
> Module::getResourceAsStream and Class::getResourceAsStream from the native
> level.
>
> At the java level the test builds a test module called 'n' which opens the
> package 'open' to
On Wed, 20 Apr 2022 01:03:23 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package
On Tue, 19 Apr 2022 21:15:29 GMT, XenoAmess wrote:
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add documents
-
Changes:
- all:
On Wed, 20 Apr 2022 16:35:25 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove uselsee MIN_SKIP_BUFFER_SIZE
>
> src/java.base/share/classes/java/io/InputStream.java line 62:
>
>> 60:
>> 61:
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
skipBufferReference(long) -> skipBufferReference(int)
-
Changes:
-
On Wed, 20 Apr 2022 16:30:19 GMT, XenoAmess wrote:
>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove uselsee
On Tue, 19 Apr 2022 22:37:21 GMT, jmehrens wrote:
>>> > @jmehrens what about this then? I think it safe now(actually this
>>> > mechanism is learned from Reader)
>>>
>>> Reader uses a lock object and it appears that InputStream locks on this
>>> (per make/reset) I would assume now that you
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
comment added.
-
Changes:
- all:
On 4/18/2022 7:06 PM, Hiran Chaudhuri wrote:
On Mon, 2022-04-18 at 18:41 -0400, Alexey Semenyuk wrote:
I've filed [1] and [2] CRs to track the issues.
[1] https://bugs.openjdk.java.net/browse/JDK-8284973
[2] https://bugs.openjdk.java.net/browse/JDK-8284974
- Alexey
Sounds great. Thank
On Wed, 20 Apr 2022 16:16:05 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove useless skipBuffer
>
> src/java.base/share/classes/java/io/InputStream.java line 57:
>
>> 55: private static final
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
remove uselsee MIN_SKIP_BUFFER_SIZE
-
Changes:
- all:
On Tue, 19 Apr 2022 23:34:01 GMT, Joe Darcy wrote:
> Simple refactoring to use new-in19 library code.
This pull request has now been integrated.
Changeset: e6c5f288
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/e6c5f2886c39a95e660dd3d83d894fd3761b7468
Stats: 10
On Wed, 20 Apr 2022 16:07:17 GMT, XenoAmess wrote:
>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove useless
On Tue, 19 Apr 2022 22:17:54 GMT, liach wrote:
> Need to add apiNote documentation section to capacity-based constructors like
> for maps.
@liach done.
-
PR: https://git.openjdk.java.net/jdk/pull/8302
> as title.
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add apiNote s
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8302/files
- new: https://git.openjdk.java.net/jdk/pull/8302/files/f051c1fa..26bb5792
On Tue, 19 Apr 2022 23:34:01 GMT, Joe Darcy wrote:
> Simple refactoring to use new-in19 library code.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8310
On Tue, 19 Apr 2022 20:15:08 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains two new
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
remove useless skipBuffer
-
Changes:
- all:
On Tue, 19 Apr 2022 22:47:42 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change to liach operation.
>
> src/java.base/share/classes/java/io/InputStream.java line 62:
>
>> 60:
>> 61: /** Skip
some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
https://github.com/openjdk/jdk/pull/8292/
if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
continue;
}
should be changed to
if (((u1 == c1) ?
On Tue, 19 Apr 2022 18:47:16 GMT, Jan Lahoda wrote:
>> This is a (preliminary) patch for javac implementation for the third preview
>> of pattern matching for switch (type patterns in switches).
>>
>> Draft JLS:
>>
> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
> of `java.io.FilterInputStream`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8284930: Also remove synchronized keyword from mark() and reset()
On Tue, 19 Apr 2022 18:47:16 GMT, Jan Lahoda wrote:
>> This is a (preliminary) patch for javac implementation for the third preview
>> of pattern matching for switch (type patterns in switches).
>>
>> Draft JLS:
>>
On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov wrote:
> I found [yet another
> typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948)
> ...
I didn't think "JVMInvokeMethodSlack" was a typo. I think it's the idea of
"slack space" meaning leftover space.
On Wed, 20 Apr 2022 11:56:20 GMT, Jaikiran Pai wrote:
> I wonder if it should be removed from InputStream at the same time.
I took the presence of synchronized on those empty methods as a hint to
subclasses that they too should be synchronized.
-
PR:
On Wed, 20 Apr 2022 11:56:20 GMT, Jaikiran Pai wrote:
> As for the changes to `FilterInputStream`, would this change require a CSR?
There might be a case where a subclass of `FilterInputStream` has overridden
all other methods to add `synchronized` but has not overridden `mark` and
`reset`,
On Wed, 20 Apr 2022 07:33:14 GMT, Alan Bateman wrote:
> I wonder if it should be removed from InputStream at the same time.
Interesting. I hadn't noticed `InputStream` had those two methods synchronized.
I suspect removing synchronization from those two methods on `InputStream` is
probably a
On 4/20/22 10:15, sminervini.prism wrote:
> To the Java Community Process, and OpenJDK community,
>
> A number of us have been waiting on serious consideration for
apprehension of
>
> core-libs-dev Digest Vol 180 Issue 174 Topic 1
>
> since we have posted, but not received an addressal and
On Wed, 20 Apr 2022 01:03:23 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package
On Tue, 19 Apr 2022 23:26:44 GMT, Brian Burkhalter wrote:
> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
> of `java.io.FilterInputStream`.
I wonder if it should be removed from InputStream at the same time.
-
PR:
On Mon, 18 Apr 2022 09:07:31 GMT, xpbob wrote:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory &
On Mon, 18 Apr 2022 09:07:31 GMT, xpbob wrote:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory &
86 matches
Mail list logo
