Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Christian Stein
On Tue, 24 May 2022 04:50:58 GMT, Jaikiran Pai wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.base/share/classes/java/util/spi/ToolProvider.java >> >> Co-authored-by: Anthony

Re: RFR: 8285401: Proxy class initializer should use 3-arg `Class.forName` to avoid unnecessary class initialization [v3]

2022-05-23 Thread Jaikiran Pai
On Fri, 20 May 2022 18:22:47 GMT, liach wrote: >> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of >> `Class.forName(String)`. `make test >> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new >> `LazyInitializationTest` failing the eager initialization

Re: RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen wrote: > Hi all, > > This PR addresses the performance issue that is described in JDK-8287162. > > With this fix, the ZipFileSystem methods: initOwner, initGroup, and > initPermissions will not be invoked unless

Re: RFR: 8287121: Fix typo in jlink's description resource key lookup

2022-05-23 Thread Jaikiran Pai
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote: > Commit > https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640 > for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) > added an optional description accessor on the `ToolProvider`

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Jaikiran Pai
On Mon, 23 May 2022 10:38:43 GMT, Christian Stein wrote: >> This commit adds an API note to ToolProvider about being reusable/reentrant. > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Update

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Joe Darcy
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote: > This is the implementation of JEP 428: Structured Concurrency (Incubator). > > This is a non-final API that provides a gentle on-ramp to structure a task as > a family of concurrent subtasks, and to coordinate the subtasks as a unit.

Re: RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-23 Thread Jaikiran Pai
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen wrote: > Hi all, > > This PR addresses the performance issue that is described in JDK-8287162. > > With this fix, the ZipFileSystem methods: initOwner, initGroup, and > initPermissions will not be invoked unless

Re: RFR: 8286849: Use @Stable for generic repositories

2022-05-23 Thread liach
On Tue, 17 May 2022 04:40:50 GMT, liach wrote: > Generic repositories, the implementation detail for generic information in > core reflection, can be updated to use the `@Stable` annotation to replace > their `volatile` access. Their existing accessor code is already safe, > reading the cache

Re: RFR: 8286849: Use @Stable for generic repositories

2022-05-23 Thread Sergey Bylokhov
On Tue, 17 May 2022 04:40:50 GMT, liach wrote: > Generic repositories, the implementation detail for generic information in > core reflection, can be updated to use the `@Stable` annotation to replace > their `volatile` access. Their existing accessor code is already safe, > reading the cache

Integrated: 8285973: x86_64: Improve fp comparison and cmove for eq/ne

2022-05-23 Thread Quan Anh Mai
On Wed, 4 May 2022 01:59:17 GMT, Quan Anh Mai wrote: > Hi, > > This patch optimises the matching rules for floating-point comparison with > respects to eq/ne on x86-64 > > 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF` > is always set, so we don't need

Re: RFR: 8285973: x86_64: Improve fp comparison and cmove for eq/ne [v3]

2022-05-23 Thread Quan Anh Mai
On Sat, 21 May 2022 10:31:25 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch optimises the matching rules for floating-point comparison with >> respects to eq/ne on x86-64 >> >> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF` >> is always set, so we don't need

Re: RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller

2022-05-23 Thread Mikhailo Seledtsov
On Mon, 23 May 2022 22:11:47 GMT, Ioi Lam wrote: > This PR fixes a bug found on an Ubuntu host that's mostly running with > cgroupv2, but there's a controller (freezer) that is mounted in cgroupv1 mode. > > The container support code in the VM and JDK checks if we have simultaneously >

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v8]

2022-05-23 Thread Vladimir Kozlov
On Fri, 20 May 2022 09:51:24 GMT, Jatin Bhateja wrote: >> Hi All, >> >> Patch adds the planned support for new vector operations and APIs targeted >> for [JEP 426: Vector API (Fourth >> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173) >> >> Following is the brief summary of

RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller

2022-05-23 Thread Ioi Lam
This PR fixes a bug found on an Ubuntu host that's mostly running with cgroupv2, but there's a controller (freezer) that is mounted in cgroupv1 mode. The container support code in the VM and JDK checks if we have simultaneously mounted v1 and v2 containers. If so, we revert to "hybrid" mode

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v8]

2022-05-23 Thread Vladimir Ivanov
On Fri, 20 May 2022 09:51:24 GMT, Jatin Bhateja wrote: >> Hi All, >> >> Patch adds the planned support for new vector operations and APIs targeted >> for [JEP 426: Vector API (Fourth >> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173) >> >> Following is the brief summary of

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts

2022-05-23 Thread Brian Goetz
This work is quite timely as we are now paving the way for primitive type patterns over in Project Amber, and also has a nontrivial connection with Valhalla.  If you'll pardon a brief digression... Instanceof and casting work together in a familiar way: before you cast, you first ask

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Maurizio Cimadamore
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote: > This is the implementation of JEP 428: Structured Concurrency (Incubator). > > This is a non-final API that provides a gentle on-ramp to structure a task as > a family of concurrent subtasks, and to coordinate the subtasks as a unit.

RFR: 8287181: Avoid redundant HashMap.containsKey calls in InternalLocaleBuilder.setExtension

2022-05-23 Thread Andrey Turbanov
No need to separately perform `HashMap.containsKey` before `HashMap.remove` call. If key is present - it will be removed anyway. If it's not present, nothing will be deleted. - Commit messages: - [PATCH] Avoid redundant HashMap.containsKey calls in InternalLocaleBuilder Changes:

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v2]

2022-05-23 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The

Re: RFR: 8285973: x86_64: Improve fp comparison and cmove for eq/ne [v3]

2022-05-23 Thread Sandhya Viswanathan
On Sat, 21 May 2022 10:31:25 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch optimises the matching rules for floating-point comparison with >> respects to eq/ne on x86-64 >> >> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF` >> is always set, so we don't need

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v3]

2022-05-23 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: Update copyright to 2022

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults [v2]

2022-05-23 Thread Roger Riggs
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote: >> JDK-6725221 Standardize obtaining boolean properties with defaults > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Alan and Jamil comments

RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-23 Thread Lance Andersen
Hi all, This PR addresses the performance issue that is described in JDK-8287162. With this fix, the ZipFileSystem methods: initOwner, initGroup, and initPermissions will not be invoked unless enablePosixFileAttributes=true. Mach5 tiers1-3 are currently running and have not encountered any

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-05-23 Thread Severin Gehwolf
On Mon, 23 May 2022 09:24:19 GMT, Severin Gehwolf wrote: >> Also, I think the current PR could produce the wrong answer, if systemd is >> indeed running inside the container, and we have: >> >> >> "/user.slice/user-1000.slice/session-50.scope",// root_path >>

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Paul Sandoz
On Sat, 21 May 2022 16:25:57 GMT, Alan Bateman wrote: >> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/StructuredTaskScope.java >> line 1172: >> >>> 1170: } >>> 1171: }; >>> 1172: return AccessController.doPrivileged(pa); >> >> It 

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Paul Sandoz
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote: > This is the implementation of JEP 428: Structured Concurrency (Incubator). > > This is a non-final API that provides a gentle on-ramp to structure a task as > a family of concurrent subtasks, and to coordinate the subtasks as a unit.

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults [v2]

2022-05-23 Thread Mark Powers
On Mon, 23 May 2022 18:34:41 GMT, Roger Riggs wrote: >> You are right. The old way maps the null string to true, and the new way >> maps it to false. I did not notice that. At this point, I see no value in >> making the "true".equals and "false".equals changes. Too much can break. >> I'll

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults [v2]

2022-05-23 Thread Mark Powers
> JDK-6725221 Standardize obtaining boolean properties with defaults Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Alan and Jamil comments - Merge - reverse true.equals and false.equals changes -

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v5]

2022-05-23 Thread Raffaello Giulietti
> Add a family of "safe" cast methods. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8279986: methods Math::asXExact for safely checked primitive casts - Changes: - all:

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v4]

2022-05-23 Thread kristylee88
On Mon, 23 May 2022 18:37:26 GMT, Raffaello Giulietti wrote: >> Add a family of "safe" cast methods. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8279986: methods Math::asXExact for safely checked primitive

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-23 Thread Roger Riggs
On Tue, 10 May 2022 19:24:24 GMT, Mark Powers wrote: >> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777: >> >>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) { >>> 776: printStackWhenAccessFails = GetBooleanAction. >>> 777:

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v4]

2022-05-23 Thread Raffaello Giulietti
> Add a family of "safe" cast methods. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8279986: methods Math::asXExact for safely checked primitive casts - Changes: - all:

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration [v3]

2022-05-23 Thread Aleksey Shipilev
> [JDK-8284161](https://bugs.openjdk.java.net/browse/JDK-8284161) broke a lot > of x86_32 code. The x86_32 porting is done under > [JDK-8286642](https://bugs.openjdk.java.net/browse/JDK-8286642). Meanwhile, > we can problemlist the failing tests to get cleaner runs for other patches. > This

Re: Stream.fromForEach(Consumer>)

2022-05-23 Thread Steven Schlansker
> On May 23, 2022, at 5:53 AM, Brian Goetz wrote: > > This is a nice use of `mapMulti` to create a stream whose contents are > dynamically generated. It is one step short of generators (which we hope > Loom will eventually give us), in that it is restricted to a generator method > that

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration [v2]

2022-05-23 Thread Aleksey Shipilev
> [JDK-8284161](https://bugs.openjdk.java.net/browse/JDK-8284161) broke a lot > of x86_32 code. The x86_32 porting is done under > [JDK-8286642](https://bugs.openjdk.java.net/browse/JDK-8286642). Meanwhile, > we can problemlist the failing tests to get cleaner runs for other patches. > This

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v3]

2022-05-23 Thread Joe Darcy
On Tue, 10 May 2022 13:47:35 GMT, Raffaello Giulietti wrote: >> Add a family of "safe" cast methods. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8279986: methods Math::asXExact for safely checked primitive

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Maurizio Cimadamore
On Mon, 23 May 2022 15:36:01 GMT, Aleksey Shipilev wrote: >> Okay, so the issue is SpliteratorTest uses preview APIs and having the >> configuration in TEST.properties means that all the streams tests are run >> with this option. > > Yes, `TEST.properties` is way too broad. I'd keep the

Re: RFR: 8287158: Explicitly reject unsupported call shapes on macos-aarch64 in mainline

2022-05-23 Thread Maurizio Cimadamore
On Mon, 23 May 2022 12:27:40 GMT, Jorn Vernee wrote: > Bring in changes from the panama-foreign repo > > These changes pertain to explicitly rejecting unsupported call shapes on > macos-aarch64. > > Original PRs: > 1. https://github.com/openjdk/panama-foreign/pull/676 > 2.

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v3]

2022-05-23 Thread Jatin Bhateja
On Thu, 12 May 2022 23:56:49 GMT, Vladimir Ivanov wrote: >> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 11 commits: >> >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960 >> - 8284960:

Integrated: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate

2022-05-23 Thread Naoto Sato
On Thu, 3 Mar 2022 19:33:31 GMT, Naoto Sato wrote: > Supporting `IsoFields` temporal fields in chronologies that are similar to > ISO chronology. Corresponding CSR has also been drafted. This pull request has now been integrated. Changeset: ef7a9f81 Author:Naoto Sato URL:

Integrated: 8286956: Loom: Define test groups for development/porting use

2022-05-23 Thread Aleksey Shipilev
On Wed, 18 May 2022 11:10:58 GMT, Aleksey Shipilev wrote: > It would be beneficial to bring over the Loom-specific test groups from the > loom repo to aid development/porting work. > > https://github.com/openjdk/loom/blob/fibers/test/jdk/TEST.groups#L97-L108 >

Re: RFR: 8286956: Loom: Define test groups for development/porting use

2022-05-23 Thread Aleksey Shipilev
On Wed, 18 May 2022 11:10:58 GMT, Aleksey Shipilev wrote: > It would be beneficial to bring over the Loom-specific test groups from the > loom repo to aid development/porting work. > > https://github.com/openjdk/loom/blob/fibers/test/jdk/TEST.groups#L97-L108 >

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Aleksey Shipilev
On Mon, 23 May 2022 15:34:11 GMT, Alan Bateman wrote: >> Those tests *do* run with preview enabled: >> https://github.com/openjdk/jdk/blob/master/test/jdk/java/util/stream/test/TEST.properties#L10-L11 >> -- and I know that because I basically copy-pasted all jtreg failures that >> lead to

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 15:18:10 GMT, Aleksey Shipilev wrote: >> test/jdk/ProblemList.txt line 894: >> >>> 892: >>> java/util/stream/test/org/openjdk/tests/java/util/stream/CollectionAndMapModifyStreamTest.java >>> 8286642 generic-i586 >>> 893: >>>

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Phil Race
On Mon, 23 May 2022 12:28:30 GMT, Aleksey Shipilev wrote: > [JDK-8284161](https://bugs.openjdk.java.net/browse/JDK-8284161) broke a lot > of x86_32 code. The x86_32 porting is done under > [JDK-8286642](https://bugs.openjdk.java.net/browse/JDK-8286642). Meanwhile, > we can problemlist the

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Aleksey Shipilev
On Mon, 23 May 2022 15:13:02 GMT, Alan Bateman wrote: >> [JDK-8284161](https://bugs.openjdk.java.net/browse/JDK-8284161) broke a lot >> of x86_32 code. The x86_32 porting is done under >> [JDK-8286642](https://bugs.openjdk.java.net/browse/JDK-8286642). Meanwhile, >> we can problemlist the

Re: RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 12:28:30 GMT, Aleksey Shipilev wrote: > [JDK-8284161](https://bugs.openjdk.java.net/browse/JDK-8284161) broke a lot > of x86_32 code. The x86_32 porting is done under > [JDK-8286642](https://bugs.openjdk.java.net/browse/JDK-8286642). Meanwhile, > we can problemlist the

RFR: 8287137: Problemlist failing x86_32 tests after Loom integration

2022-05-23 Thread Aleksey Shipilev
[JDK-8284161](https://bugs.openjdk.java.net/browse/JDK-8284161) broke a lot of x86_32 code. The x86_32 porting is done under [JDK-8286642](https://bugs.openjdk.java.net/browse/JDK-8286642). Meanwhile, we can problemlist the failing tests to get cleaner runs for other patches. This should also

Re: RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-23 Thread Raffaello Giulietti
On Sun, 22 May 2022 20:19:38 GMT, Andrey Turbanov wrote: >> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a >> rounding error to accumulate at the tail of the distribution (probably >> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes >> that by

RFR: 8287158: Explicitly reject unsupported call shapes on macos-aarch64 in mainline

2022-05-23 Thread Jorn Vernee
Bring in changes from the panama-foreign repo These changes pertain to explicitly rejecting unsupported call shapes on macos-aarch64. Testing: `jdk_foreign` on linux-aarch64-debug, macosx-aarch64-debug, linux-x64-debug, macosx-x64-debug, and windows-x64-debug - Commit messages:

Re: RFR: 8287158: Explicitly reject unsupported call shapes on macos-aarch64 in mainline

2022-05-23 Thread Jorn Vernee
On Mon, 23 May 2022 12:27:40 GMT, Jorn Vernee wrote: > Bring in changes from the panama-foreign repo > > These changes pertain to explicitly rejecting unsupported call shapes on > macos-aarch64. > > Testing: `jdk_foreign` on linux-aarch64-debug, macosx-aarch64-debug, > linux-x64-debug,

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Daniel Fuchs
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote: > This is the implementation of JEP 428: Structured Concurrency (Incubator). > > This is a non-final API that provides a gentle on-ramp to structure a task as > a family of concurrent subtasks, and to coordinate the subtasks as a unit.

Re: Stream.fromForEach(Consumer>)

2022-05-23 Thread Brian Goetz
This is a nice use of `mapMulti` to create a stream whose contents are dynamically generated.  It is one step short of generators (which we hope Loom will eventually give us), in that it is restricted to a generator method that generates all of the elements in one invocation.  This is still

Re: RFR: 8286956: Loom: Define test groups for development/porting use

2022-05-23 Thread Zhengyu Gu
On Wed, 18 May 2022 11:10:58 GMT, Aleksey Shipilev wrote: > It would be beneficial to bring over the Loom-specific test groups from the > loom repo to aid development/porting work. > > https://github.com/openjdk/loom/blob/fibers/test/jdk/TEST.groups#L97-L108 >

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread ExE Boss
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote: > This is the implementation of JEP 428: Structured Concurrency (Incubator). > > This is a non-final API that provides a gentle on-ramp to structure a task as > a family of concurrent subtasks, and to coordinate the subtasks as a unit.

Re: RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Alan Bateman
On Sat, 21 May 2022 14:09:59 GMT, ExE Boss wrote: >> This is the implementation of JEP 428: Structured Concurrency (Incubator). >> >> This is a non-final API that provides a gentle on-ramp to structure a task >> as a family of concurrent subtasks, and to coordinate the subtasks as a unit. > >

RFR: 8284199: Implementation of Structured Concurrency (Incubator)

2022-05-23 Thread Alan Bateman
This is the implementation of JEP 428: Structured Concurrency (Incubator). This is a non-final API that provides a gentle on-ramp to structure a task as a family of concurrent subtasks, and to coordinate the subtasks as a unit. - Commit messages: - @ignore StructuredThreadDumpTest

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v10]

2022-05-23 Thread Adam Sotona
> Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand of a > compound assignment is not assignment

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v9]

2022-05-23 Thread Adam Sotona
> Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand of a > compound assignment is not assignment

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Christian Stein
On Mon, 23 May 2022 10:32:09 GMT, Anthony Vanelverdinghe wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.base/share/classes/java/util/spi/ToolProvider.java >> >> Co-authored-by: Anthony

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Anthony Vanelverdinghe
On Mon, 23 May 2022 10:34:51 GMT, Christian Stein wrote: >> This commit adds an API note to ToolProvider about being reusable/reentrant. > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Update

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Christian Stein
> This commit adds an API note to ToolProvider about being reusable/reentrant. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/java/util/spi/ToolProvider.java Co-authored-by: Anthony

Re: RFR: 8287121: Fix typo in jlink's description resource key lookup

2022-05-23 Thread Lance Andersen
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote: > Commit > https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640 > for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) > added an optional description accessor on the `ToolProvider`

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant

2022-05-23 Thread Lance Andersen
On Mon, 23 May 2022 08:49:27 GMT, Christian Stein wrote: > This commit adds an API note to ToolProvider about being reusable/reentrant. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8833

Integrated: 8286825: Linker naming cleanup

2022-05-23 Thread Jorn Vernee
On Wed, 18 May 2022 16:54:06 GMT, Jorn Vernee wrote: > This patch is a batch naming cleanup for the foreign linker implementation. > > The naming changes are as follows: > > - ProgrammableInvoker -> DowncallLinker > - ProgrammableUpcallHandler -> UpcallLinker > - 'native invoker' ->

Re: RFR: 8286825: Linker naming cleanup [v2]

2022-05-23 Thread Jorn Vernee
On Fri, 20 May 2022 10:57:44 GMT, Jorn Vernee wrote: >> This patch is a batch naming cleanup for the foreign linker implementation. >> >> The naming changes are as follows: >> >> - ProgrammableInvoker -> DowncallLinker >> - ProgrammableUpcallHandler -> UpcallLinker >> - 'native invoker'

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-05-23 Thread Severin Gehwolf
On Thu, 19 May 2022 20:18:50 GMT, Ioi Lam wrote: >> I am wondering if the problem is this: >> >> We have systemd running on the host, and a different copy of systemd that >> runs inside the container. >> >> - They both set up `/user.slice/user-1000.slice/session-??.scope` within >> their own

Re: RFR: 8287121: Fix typo in jlink's description resource key lookup

2022-05-23 Thread Alan Bateman
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote: > Commit > https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640 > for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) > added an optional description accessor on the `ToolProvider`

RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant

2022-05-23 Thread Christian Stein
This commit adds an API note to ToolProvider about being reusable/reentrant. - Commit messages: - 8286815: Add API note to ToolProvider about being reusable/reentrant Changes: https://git.openjdk.java.net/jdk/pull/8833/files Webrev:

Integrated: 8286715: Generalize MemorySegment::ofBuffer

2022-05-23 Thread Maurizio Cimadamore
On Fri, 13 May 2022 12:33:10 GMT, Maurizio Cimadamore wrote: > This patch makes MemorySegment::ofBuffer more general, by allowing clients to > pass *any* `Buffer` instance, not just `ByteBuffer`. > This allows us to match expressiveness of JNI API, where JNI clients can > obtain the address

Integrated: 8287053: Avoid redundant HashMap.containsKey calls in ZoneInfoFile.getZoneInfo0

2022-05-23 Thread Andrey Turbanov
On Sat, 30 Apr 2022 17:00:03 GMT, Andrey Turbanov wrote: > Instead of pair `HashMap.containsKey`/`HashMap.get` method calls, we can use > single call `HashMap.getOrDefault`. > It's faster and clearer. This pull request has now been integrated. Changeset: 01916e19 Author:Andrey Turbanov

Re: RFR: 8286571: java source launcher from a minimal jdk image containing jdk.compiler fails with --enable-preview option [v3]

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 07:29:56 GMT, Adam Sotona wrote: > Sorry, I wrongly assumed it was `java.compiler` (the library module), but > this is about `jdk.compiler` (the tool)... Nevertheless, the same question > applies: Does `jdk.compiler` have any meaningful functionality even without >

Re: RFR: 8286571: java source launcher from a minimal jdk image containing jdk.compiler fails with --enable-preview option [v3]

2022-05-23 Thread Adam Sotona
On Sun, 22 May 2022 17:04:30 GMT, Peter Levart wrote: > > My humble opinion: if java.compiler needs jdk.zipfs for full > > functionality > > Sorry, I wrongly assumed it was `java.compiler` (the library module), but > this is about `jdk.compiler` (the tool)... Nevertheless, the same

Re: RFR: 8286825: Linker naming cleanup [v2]

2022-05-23 Thread Robbin Ehn
On Fri, 20 May 2022 10:57:44 GMT, Jorn Vernee wrote: >> This patch is a batch naming cleanup for the foreign linker implementation. >> >> The naming changes are as follows: >> >> - ProgrammableInvoker -> DowncallLinker >> - ProgrammableUpcallHandler -> UpcallLinker >> - 'native invoker'

Re: Stream.fromForEach(Consumer>)

2022-05-23 Thread forax
- Original Message - > From: "Tagir Valeev" > To: "Remi Forax" > Cc: "core-libs-dev" > Sent: Monday, May 23, 2022 8:01:44 AM > Subject: Re: Stream.fromForEach(Consumer>) > Hello! > > There's a Stream.builder for this purpose: > > var builder = Stream.builder(); > new Parser("1 2

Re: Stream.fromForEach(Consumer>)

2022-05-23 Thread Tagir Valeev
Hello! There's a Stream.builder for this purpose: var builder = Stream.builder(); new Parser("1 2 3").parse(builder); builder.build().forEach(System.out::println); A little bit more verbose than your suggestion but this way it's more clear that the whole stream content will be buffered. With